test ts-check

Author: walker-sean

src/frontend/src/tests/pages/ChangeRequestDetailPage/ChangeRequestDetails.test.tsx

@@ -10,17 +10,16 @@ import {
   exampleActivationChangeRequest as exActivationCR,
   exampleStandardChangeRequest as exStandardCR
 } from '../../test-support/test-data/change-requests.stub';
-import {
-  exampleAdminUser,
-  exampleAdminUser2,
-  exampleGuestUser,
-  exampleMemberUser
-} from '../../test-support/test-data/users.stub';
 import { render, screen, routerWrapperBuilder, fireEvent } from '../../test-support/test-utils';
 import { mockUseQueryResult, mockAuth } from '../../test-support/test-data/test-utils.stub';
 import { useSingleChangeRequest } from '../../../hooks/change-requests.hooks';
 import { useAuth } from '../../../hooks/auth.hooks';
 import ChangeRequestDetails from '../../../pages/ChangeRequestDetailPage/ChangeRequestDetails';
+import {
+  exampleAuthenticatedAdminUser,
+  exampleAuthenticatedGuestUser,
+  exampleAuthenticatedMemberUser
+} from '../../test-support/test-data/authenticated-user.stub';
 
 vi.mock('../../../hooks/change-requests.hooks');
 
@@ -34,7 +33,7 @@ vi.mock('../../../hooks/auth.hooks');
 
 const mockedUseAuth = useAuth as jest.Mock<Auth>;
 
-const mockAuthHook = (user = exampleAdminUser) => {
+const mockAuthHook = (user = exampleAuthenticatedAdminUser) => {
   mockedUseAuth.mockReturnValue(mockAuth(false, user));
 };
 
@@ -62,39 +61,39 @@ describe.skip('change request details container', () => {
 
   it('enables review if the user is an admin', () => {
     mockSingleCRHook(false, false, exActivationCR);
-    mockAuthHook(exampleAdminUser2);
+    mockAuthHook(exampleAuthenticatedAdminUser);
     renderComponent();
 
     expect(screen.getByText('Review')).not.toHaveAttribute('aria-disabled');
   });
 
   it("disables review of admin's own change requests", () => {
     mockSingleCRHook(false, false, exActivationCR);
-    mockAuthHook(exampleAdminUser);
+    mockAuthHook(exampleAuthenticatedAdminUser);
     renderComponent();
 
     expect(screen.getByText('Review')).toHaveAttribute('aria-disabled');
   });
 
   it('disables reviewing change requests for guests', () => {
     mockSingleCRHook(false, false, exActivationCR);
-    mockAuthHook(exampleGuestUser);
+    mockAuthHook(exampleAuthenticatedGuestUser);
     renderComponent();
 
     expect(screen.getByText('Review')).toHaveAttribute('aria-disabled');
   });
 
   it('disables reviewing change requests for member users', () => {
     mockSingleCRHook(false, false, exActivationCR);
-    mockAuthHook(exampleMemberUser);
+    mockAuthHook(exampleAuthenticatedMemberUser);
     renderComponent();
 
     expect(screen.getByText('Review')).toHaveAttribute('aria-disabled');
   });
 
   it('enables implementing if the user is an admin', () => {
     mockSingleCRHook(false, false, exStandardCR);
-    mockAuthHook(exampleAdminUser);
+    mockAuthHook(exampleAuthenticatedAdminUser);
     renderComponent();
 
     fireEvent.click(screen.getByText('Implement Change Request'));
@@ -104,7 +103,7 @@ describe.skip('change request details container', () => {
 
   it('disables implementing change requests for guests', () => {
     mockSingleCRHook(false, false, exStandardCR);
-    mockAuthHook(exampleGuestUser);
+    mockAuthHook(exampleAuthenticatedGuestUser);
     renderComponent();
 
     fireEvent.click(screen.getByText('Implement Change Request'));

src/frontend/src/tests/pages/ChangeRequestDetailPage/ChangeRequestDetailsView.test.tsx

@@ -22,6 +22,7 @@ import {
   mockLogUserInDevReturnValue,
   mockGetCurrentUserValue
 } from '../../test-support/mock-hooks';
+import { exampleAuthenticatedAdminUser } from '../../test-support/test-data/authenticated-user.stub';
 
 vi.mock('../../../hooks/projects.hooks');
 vi.mock('../../../hooks/users.hooks');
@@ -72,7 +73,7 @@ describe('Implement change request permission tests', () => {
       onboardedTeamTypeIds: [],
       onboardingTeamTypeIds: []
     });
-    vi.spyOn(authHooks, 'useAuth').mockReturnValue(mockAuth(false, exampleAdminUser));
+    vi.spyOn(authHooks, 'useAuth').mockReturnValue(mockAuth(false, exampleAuthenticatedAdminUser));
     vi.spyOn(userHooks, 'useGetCurrentUser').mockReturnValue(mockGetCurrentUserValue);
   });