#3945 changed fix to services only

Author: getheobald

src/backend/src/services/tasks.services.ts

@@ -122,7 +122,8 @@ export default class TasksService {
 
     const newTask = taskTransformer(createdTask);
 
-    await sendSlackTaskAssignedNotificationToUsers(newTask, assignees, organization.organizationId, createdBy.userId);
+    const nonSelfAssigneeIds = assignees.filter((id) => id !== createdBy.userId);
+    await sendSlackTaskAssignedNotificationToUsers(newTask, nonSelfAssigneeIds, organization.organizationId);
 
     return newTask;
   }
@@ -254,7 +255,8 @@ export default class TasksService {
       })
     );
 
-    await sendSlackTaskAssignedNotificationToUsers(updatedTask, newAssigneeIds, organization.organizationId, user.userId);
+    const nonSelfAssigneeIds = newAssigneeIds.filter((id) => id !== user.userId);
+    await sendSlackTaskAssignedNotificationToUsers(updatedTask, nonSelfAssigneeIds, organization.organizationId);
 
     return updatedTask;
   }

src/backend/src/utils/tasks.utils.ts

@@ -22,17 +22,15 @@ export const convertTaskStatus = (status: Task_Status): TaskStatus =>
  * @param task the task the users are assigned to
  * @param assigneeIds the user ids of the users assigned to the task
  * @param orgainzationId the organization id of the current user
- * @param assignerId the user id of the user who assigned the task
  */
 export const sendSlackTaskAssignedNotificationToUsers = async (
   task: Task,
   assigneeIds: string[],
-  orgainzationId: string,
-  assignerId: string
+  orgainzationId: string
 ) => {
   const assigneeSettings = await prisma.user_Settings.findMany({ where: { userId: { in: assigneeIds } } });
   assigneeSettings.forEach(async (settings) => {
-    if (settings.slackId && settings.userId !== assignerId) {
+    if (settings.slackId) {
       await sendSlackTaskAssignedNotification(settings.slackId, task, orgainzationId);
     }
   });