#3936 service returns nothing, remove caps for route

Author: chrisdicono

src/backend/src/routes/recruitment.routes.ts

@@ -64,6 +64,6 @@ recruitmentRouter.post(
   RecruitmentController.createGuestDefinition
 );
 
-recruitmentRouter.delete('/guestDefinition/:definitionId/delete', RecruitmentController.deleteGuestDefinition);
+recruitmentRouter.delete('/guestdefinition/:definitionId/delete', RecruitmentController.deleteGuestDefinition);
 
 export default recruitmentRouter;

src/backend/src/services/recruitment.services.ts

@@ -259,7 +259,7 @@ export default class RecruitmentServices {
    * @param deleter the user requesting to delete the guestDefinition
    * @param organizationId the organization ID of the deleter
    */
-  static async deleteGuestDefinition(deleter: User, definitionId: string, organization: Organization) {
+  static async deleteGuestDefinition(deleter: User, definitionId: string, organization: Organization): Promise<void> {
     if (!(await userHasPermission(deleter.userId, organization.organizationId, isAdmin))) {
       throw new AccessDeniedAdminOnlyException('delete a guestDefinition');
     }
@@ -273,7 +273,5 @@ export default class RecruitmentServices {
       where: { definitionId },
       data: { dateDeleted: new Date(), userDeletedId: deleter.userId }
     });
-
-    return def;
   }
 }