#4148: renamed method and fixed req.params access

Author: jasperpinkus

src/backend/src/controllers/recruitment.controllers.ts

@@ -116,9 +116,11 @@ export default class RecruitmentController {
     }
   }
 
-  static async getGuestDefinition(req: Request, res: Response, next: NextFunction) {
+  static async getSingleGuestDefinition(req: Request, res: Response, next: NextFunction) {
     try {
-      const definition = await RecruitmentServices.getGuestDefinition(req.organization, req.params.definitionId as string);
+      const { defenitionId } = req.params as Record<string, string>;
+
+      const definition = await RecruitmentServices.getSingleGuestDefinition(req.organization, defenitionId);
       res.status(200).json(definition);
     } catch (error: unknown) {
       next(error);

src/backend/src/routes/recruitment.routes.ts

@@ -64,7 +64,7 @@ recruitmentRouter.post(
   RecruitmentController.createGuestDefinition
 );
 
-recruitmentRouter.get('/guestdefinition/:definitionId', RecruitmentController.getGuestDefinition);
+recruitmentRouter.get('/guestdefinition/:definitionId', RecruitmentController.getSingleGuestDefinition);
 
 recruitmentRouter.post(
   '/guestDefinition/:guestId/edit',

src/backend/src/services/recruitment.services.ts

@@ -346,7 +346,7 @@ export default class RecruitmentServices {
    * @returns a definition
    * @throws if the definition is not found in the db
    */
-  static async getGuestDefinition(organization: Organization, definitionId: string) {
+  static async getSingleGuestDefinition(organization: Organization, definitionId: string) {
     const guest = await prisma.guest_Definition.findUnique({
       where: { organization, definitionId }
     });

src/backend/tests/unit/recruitment.test.ts

@@ -392,14 +392,14 @@ describe('Recruitment Tests', () => {
         'buttonTxt',
         'buttonLink'
       );
-      const result = await RecruitmentServices.getGuestDefinition(organization, guestDefinition.definitionId);
+      const result = await RecruitmentServices.getSingleGuestDefinition(organization, guestDefinition.definitionId);
       expect(result).toStrictEqual(guestDefinition);
     });
 
     it('Get a single guest definition fails', async () => {
       const nonExistingDefinitionId = 'nonExistingDefinition';
       await expect(async () =>
-        RecruitmentServices.getGuestDefinition(organization, nonExistingDefinitionId)
+        RecruitmentServices.getSingleGuestDefinition(organization, nonExistingDefinitionId)
       ).rejects.toThrow(new NotFoundException('Guest Definition', nonExistingDefinitionId));
     });
   });