tests

Author: chpy04

src/backend/src/services/reimbursement-requests.services.ts

@@ -1052,12 +1052,12 @@ export default class ReimbursementRequestService {
   }
 
   /**
-   * Adds a reimbursement status with type pending finance to the given reimbursement request
+   * Adds a reimbursement status with type Leadership Approved to the given reimbursement request
    *
    * @param reimbursementRequestId The id of the reimbursement request to approve
    * @param submitter The person approving the reimbursement request
    * @param organizationId The organization the user is currently in
-   * @returns The Pending Finance reimbursement status
+   * @returns The Leadership Approved reimbursement status
    */
   static async leadershipApproveReimbursementRequest(
     reimbursementRequestId: string,
@@ -1082,7 +1082,7 @@ export default class ReimbursementRequestService {
 
     if (
       reimbursementRequest.reimbursementStatuses.some(
-        (reimbursementStatus) => reimbursementStatus.type === Reimbursement_Status_Type.PENDING_FINANCE
+        (reimbursementStatus) => reimbursementStatus.type === Reimbursement_Status_Type.LEADERSHIP_APPROVED
       )
     )
       throw new HttpException(400, 'This reimbursement request has already been approved by leadership');
@@ -1140,10 +1140,15 @@ export default class ReimbursementRequestService {
       throw new InvalidOrganizationException('Reimbursement Request');
 
     if (
-      !reimbursementRequest.reimbursementStatuses.some((status) => status.type === ReimbursementStatusType.PENDING_FINANCE)
+      !reimbursementRequest.reimbursementStatuses.some((status) => status.type === ReimbursementStatusType.LEADERSHIP_APPROVED)
     ) {
       throw new HttpException(400, 'This reimbursement request has not been approved by leadership');
     }
+    if (
+      !reimbursementRequest.reimbursementStatuses.some((status) => status.type === ReimbursementStatusType.PENDING_FINANCE)
+    ) {
+      throw new HttpException(400, 'This reimbursement request has not been set as pending finance');
+    }
     if (
       reimbursementRequest.reimbursementStatuses.some(
         (status) => status.type === ReimbursementStatusType.PENDING_SABO_SUBMISSION
@@ -1491,6 +1496,14 @@ export default class ReimbursementRequestService {
     return accountCodeTransformer(accountCode);
   }
 
+  /**
+   * Adds a reimbursement status with type pending finance to the given reimbursement request
+   *
+   * @param reimbursementRequestId The id of the reimbursement request to approve
+   * @param submitter The person approving the reimbursement request
+   * @param organizationId The organization the user is currently in
+   * @returns The Pending Finance reimbursement status
+   */
   static async markPendingFinance(
     user: User,
     reimbursementRequestId: string,

src/backend/tests/test-data/users.test-data.ts

@@ -98,6 +98,24 @@ export const member: CreateTestUserParams = {
   role: RoleEnum.MEMBER
 };
 
+export const robinMember: CreateTestUserParams = {
+  firstName: 'Dick',
+  lastName: 'Grayson',
+  email: 'robin@gmail.com',
+  emailId: 'robin',
+  role: RoleEnum.MEMBER,
+  googleAuthId: 'robin'
+};
+
+export const cyborgMember: CreateTestUserParams = {
+  firstName: 'Victor',
+  lastName: 'Stone',
+  email: 'cyborg@gmail.com',
+  emailId: 'cyborg',
+  role: RoleEnum.MEMBER,
+  googleAuthId: 'cyborg'
+};
+
 export const batmanSettings: User_Settings = {
   id: 'bm',
   userId: '1',

src/backend/tests/test-utils.ts

@@ -123,6 +123,7 @@ export const resetUsers = async () => {
   await prisma.assembly.deleteMany();
   await prisma.team.deleteMany();
   await prisma.user_Secure_Settings.deleteMany();
+  await prisma.receipt.deleteMany();
   await prisma.reimbursement_Product.deleteMany();
   await prisma.reimbursement_Status.deleteMany();
   await prisma.reimbursement_Request_Comment.deleteMany();

src/backend/tests/unmocked/organization.test.ts

@@ -1,6 +1,6 @@
 import { LinkCreateArgs } from 'shared';
 import { AccessDeniedAdminOnlyException, HttpException, NotFoundException } from '../../src/utils/errors.utils';
-import { batmanAppAdmin, supermanAdmin, wonderwomanGuest } from '../test-data/users.test-data';
+import { batmanAppAdmin, flashAdmin, supermanAdmin, wonderwomanGuest } from '../test-data/users.test-data';
 import { createTestLinkType, createTestOrganization, createTestUser, resetUsers } from '../test-utils';
 import prisma from '../../src/prisma/prisma';
 import { testLink1 } from '../test-data/organizations.test-data';
@@ -285,4 +285,77 @@ describe('Organization Tests', () => {
       expect(updatedOrg.sponsorshipNotificationsSlackChannelId).toEqual('sponsorshipNotifId');
     });
   });
+
+  describe('Get Finance Delegates', () => {
+    it('Succeeds and returns empty array when no delegates', async () => {
+      const delegates = await OrganizationsService.getFinanceDelegates(orgId);
+
+      expect(delegates).not.toBeNull();
+      expect(delegates.length).toBe(0);
+    });
+
+    it('Succeeds and returns all finance delegates', async () => {
+      const testBatman = await createTestUser(batmanAppAdmin, orgId);
+      const testSuperman = await createTestUser(supermanAdmin, orgId);
+
+      await OrganizationsService.setFinanceDelegates(testBatman, orgId, [testSuperman.userId]);
+
+      const delegates = await OrganizationsService.getFinanceDelegates(orgId);
+
+      expect(delegates).not.toBeNull();
+      expect(delegates.length).toBe(1);
+      expect(delegates[0].userId).toBe(testSuperman.userId);
+      expect(delegates[0].firstName).toBe('Clark');
+      expect(delegates[0].lastName).toBe('Kent');
+    });
+  });
+
+  describe('Set Finance Delegates', () => {
+    it('Fails if user is not admin', async () => {
+      const testWonderwoman = await createTestUser(wonderwomanGuest, orgId);
+      const testSuperman = await createTestUser(supermanAdmin, orgId);
+
+      await expect(OrganizationsService.setFinanceDelegates(testWonderwoman, orgId, [testSuperman.userId])).rejects.toThrow(
+        new AccessDeniedAdminOnlyException('set finance delegates')
+      );
+    });
+
+    it('Fails if one or more user IDs do not exist', async () => {
+      const testBatman = await createTestUser(batmanAppAdmin, orgId);
+
+      await expect(OrganizationsService.setFinanceDelegates(testBatman, orgId, ['nonexistent-user-id'])).rejects.toThrow(
+        new NotFoundException('User', 'one or more user IDs')
+      );
+    });
+
+    it('Succeeds and sets finance delegates', async () => {
+      const testBatman = await createTestUser(batmanAppAdmin, orgId);
+      const testSuperman = await createTestUser(supermanAdmin, orgId);
+      const testFlash = await createTestUser(flashAdmin, orgId);
+
+      const delegates = await OrganizationsService.setFinanceDelegates(testBatman, orgId, [
+        testSuperman.userId,
+        testFlash.userId
+      ]);
+
+      expect(delegates).not.toBeNull();
+      expect(delegates.length).toBe(2);
+      expect(delegates.some((delegate) => delegate.userId === testSuperman.userId)).toBeTruthy();
+      expect(delegates.some((delegate) => delegate.userId === testFlash.userId)).toBeTruthy();
+    });
+
+    it('Succeeds and replaces existing finance delegates', async () => {
+      const testBatman = await createTestUser(batmanAppAdmin, orgId);
+      const testSuperman = await createTestUser(supermanAdmin, orgId);
+      const testFlash = await createTestUser(flashAdmin, orgId);
+
+      await OrganizationsService.setFinanceDelegates(testBatman, orgId, [testSuperman.userId]);
+
+      const updatedDelegates = await OrganizationsService.setFinanceDelegates(testBatman, orgId, [testFlash.userId]);
+
+      expect(updatedDelegates).not.toBeNull();
+      expect(updatedDelegates.length).toBe(1);
+      expect(updatedDelegates[0].userId).toBe(testFlash.userId);
+    });
+  });
 });