chore: fix lint

Author: BhautikChudasama

.github/workflows/ci.yaml

@@ -0,0 +1,50 @@
+name: image-build-push
+
+on:
+  push:
+
+concurrency:
+  cancel-in-progress: true
+  group: ${{ github.workflow }}-${{ github.ref }}
+
+permissions:
+  contents: read
+
+jobs:
+  image-build-push:
+    permissions:
+      contents: read
+    runs-on: ubuntu-latest
+    steps:
+      - name: checkout repository
+        uses: actions/checkout@v6
+
+      - name: Install asdf & tools
+        uses: asdf-vm/actions/install@v4
+
+      - uses: actions/cache@v5
+        with:
+          path: |
+            ~/.asdf/installs/golang
+            ~/.asdf/plugins/golang
+            ~/.asdf/installs/golang/*/packages/pkg/mod
+            ~/.cache/go-build
+            ~/.cache/golangci-lint
+          key: ${{ runner.os }}-golangci-${{ hashFiles('**/go.sum') }}
+
+      - name: Run golangci-lint
+        run: |
+          set -x
+          golangci-lint cache status
+          golangci-lint run --timeout=10m
+
+      - name: Test
+        run: |
+          set -x
+          go test -tags dev ./...
+
+      - name: Build
+        run: |
+          set -x
+          CGO_ENABLED=0	go build -trimpath -ldflags="-s -w -extldflags '-static'" -o nodeops main.go
+          ldd createos || true

.golangci.yml

@@ -0,0 +1,64 @@
+version: "2"
+
+linters:
+  enable:
+    - errcheck
+    - govet
+    - ineffassign
+    - staticcheck
+    - unused
+    - bodyclose
+    - gocritic
+    - misspell
+    - noctx
+    - prealloc
+    - revive
+    - unconvert
+    - unparam
+    - whitespace
+    - gosec
+    - copyloopvar
+    - errorlint
+
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  settings:
+    goimports:
+      local-prefixes:
+        - github.com/NodeOps-app/createos-cli
+
+linters-settings:
+  errcheck:
+    check-type-assertions: true
+    check-blank: true
+  govet:
+    enable-all: true
+    disable:
+      - fieldalignment
+  revive:
+    rules:
+      - name: exported
+        disabled: false
+      - name: error-return
+        disabled: false
+      - name: error-strings
+        disabled: false
+      - name: indent-error-flow
+        disabled: false
+  gosec:
+    excludes:
+      - G304
+
+issues:
+  exclude-rules:
+    - path: _test\.go
+      linters:
+        - errcheck
+        - gocritic
+  max-issues-per-linter: 0
+  max-same-issues: 0
+
+run:
+  timeout: 5m

.tool-versions

@@ -1 +1,2 @@
 golang 1.26.0
+golangci-lint 2.11.3

Makefile

@@ -1,4 +1,4 @@
-.PHONY: build clean install run test help
+.PHONY: build clean install run test lint lint-fix fmt deps help
 
 # Binary name
 BINARY_NAME=createos
@@ -63,7 +63,12 @@ fmt:
 # Run linter
 lint:
 	@echo "Running linter..."
-	golangci-lint run
+	golangci-lint run ./...
+
+# Run linter and auto-fix issues
+lint-fix:
+	@echo "Running linter with auto-fix..."
+	golangci-lint run --fix ./...
 
 # Show help
 help:
@@ -77,4 +82,5 @@ help:
 	@echo "  deps       - Download and tidy dependencies"
 	@echo "  fmt        - Format code"
 	@echo "  lint       - Run linter"
+	@echo "  lint-fix   - Run linter and auto-fix issues"
 	@echo "  help       - Show this help message"

cmd/auth/login.go

@@ -1,13 +1,15 @@
+// Package auth provides authentication commands.
 package auth
 
 import (
 	"fmt"
 	"time"
 
-	"github.com/NodeOps-app/createos-cli/internal/config"
-	internaloauth "github.com/NodeOps-app/createos-cli/internal/oauth"
 	"github.com/pterm/pterm"
 	"github.com/urfave/cli/v2"
+
+	"github.com/NodeOps-app/createos-cli/internal/config"
+	internaloauth "github.com/NodeOps-app/createos-cli/internal/oauth"
 )
 
 const (

cmd/auth/logout.go

@@ -3,17 +3,18 @@ package auth
 import (
 	"fmt"
 
-	"github.com/NodeOps-app/createos-cli/internal/config"
 	"github.com/pterm/pterm"
 	"github.com/urfave/cli/v2"
+
+	"github.com/NodeOps-app/createos-cli/internal/config"
 )
 
 // NewLogoutCommand creates the logout command
 func NewLogoutCommand() *cli.Command {
 	return &cli.Command{
 		Name:  "logout",
 		Usage: "Sign out from CreateOS",
-		Action: func(c *cli.Context) error {
+		Action: func(_ *cli.Context) error {
 			if !config.IsLoggedIn() {
 				return fmt.Errorf("you're not signed in")
 			}

cmd/auth/whoami.go

@@ -4,9 +4,10 @@ import (
 	"fmt"
 	"time"
 
-	"github.com/NodeOps-app/createos-cli/internal/api"
 	"github.com/pterm/pterm"
 	"github.com/urfave/cli/v2"
+
+	"github.com/NodeOps-app/createos-cli/internal/api"
 )
 
 // NewWhoamiCommand creates the whoami command
@@ -15,7 +16,7 @@ func NewWhoamiCommand() *cli.Command {
 		Name:  "whoami",
 		Usage: "Show the currently authenticated user",
 		Action: func(c *cli.Context) error {
-			client, ok := c.App.Metadata[api.ClientKey].(*api.ApiClient)
+			client, ok := c.App.Metadata[api.ClientKey].(*api.APIClient)
 			if !ok {
 				return fmt.Errorf("you're not signed in — run 'createos login' to get started")
 			}
@@ -51,4 +52,3 @@ func NewWhoamiCommand() *cli.Command {
 		},
 	}
 }
-

cmd/oauth/clients.go

@@ -1,3 +1,4 @@
+// Package oauth provides OAuth client management commands.
 package oauth
 
 import "github.com/urfave/cli/v2"

cmd/oauth/create.go

@@ -3,9 +3,10 @@ package oauth
 import (
 	"fmt"
 
-	"github.com/NodeOps-app/createos-cli/internal/api"
 	"github.com/pterm/pterm"
 	"github.com/urfave/cli/v2"
+
+	"github.com/NodeOps-app/createos-cli/internal/api"
 )
 
 func newCreateCommand() *cli.Command {

cmd/oauth/helpers.go

@@ -5,13 +5,14 @@ import (
 	"net/url"
 	"strings"
 
-	"github.com/NodeOps-app/createos-cli/internal/api"
 	"github.com/pterm/pterm"
 	"github.com/urfave/cli/v2"
+
+	"github.com/NodeOps-app/createos-cli/internal/api"
 )
 
-func getClient(c *cli.Context) (*api.ApiClient, error) {
-	client, ok := c.App.Metadata[api.ClientKey].(*api.ApiClient)
+func getClient(c *cli.Context) (*api.APIClient, error) {
+	client, ok := c.App.Metadata[api.ClientKey].(*api.APIClient)
 	if !ok {
 		return nil, fmt.Errorf("you're not signed in — run 'createos login' to get started")
 	}