feat: add spinner in upgrade

Author: BhautikChudasama

cmd/upgrade/upgrade.go

@@ -113,16 +113,13 @@ func runUpgrade() error {
 		return fmt.Errorf("checksum URL failed validation: %w", err)
 	}
 
-	spinner, _ := pterm.DefaultSpinner.Start(fmt.Sprintf("Downloading %s...", assetName))
-
-	tmp, err := downloadToTemp(downloadURL)
+	tmp, err := downloadToTemp(downloadURL, assetName)
 	if err != nil {
-		spinner.Fail("Download failed")
 		return fmt.Errorf("could not download update: %w", err)
 	}
 	defer os.Remove(tmp) //nolint:errcheck
 
-	spinner.UpdateText("Verifying checksum...")
+	spinner, _ := pterm.DefaultSpinner.Start("Verifying checksum...")
 
 	expectedHash, err := fetchChecksum(checksumURL)
 	if err != nil {
@@ -135,7 +132,7 @@ func runUpgrade() error {
 		return err
 	}
 
-	spinner.Success("Downloaded and verified")
+	spinner.Success("Checksum verified")
 
 	exe, err := os.Executable()
 	if err != nil {
@@ -208,7 +205,22 @@ func binaryAssetName() string {
 	return name
 }
 
-func downloadToTemp(rawURL string) (string, error) {
+// progressWriter tracks bytes written and updates a pterm progress bar in KB increments.
+type progressWriter struct {
+	bar *pterm.ProgressbarPrinter
+	buf int64
+}
+
+func (pw *progressWriter) Write(p []byte) (int, error) {
+	pw.buf += int64(len(p))
+	for pw.buf >= 1024 {
+		pw.bar.Add(1)
+		pw.buf -= 1024
+	}
+	return len(p), nil
+}
+
+func downloadToTemp(rawURL, assetName string) (string, error) {
 	ctx, cancel := context.WithTimeout(context.Background(), downloadTimeout)
 	defer cancel()
 
@@ -234,7 +246,30 @@ func downloadToTemp(rawURL string) (string, error) {
 	}
 	defer tmp.Close() //nolint:errcheck
 
-	if _, err := io.Copy(tmp, io.LimitReader(resp.Body, maxBinarySize)); err != nil {
+	limited := io.LimitReader(resp.Body, maxBinarySize)
+
+	totalBytes := resp.ContentLength
+	if totalBytes > 0 {
+		totalKB := int(totalBytes / 1024)
+		bar, _ := pterm.DefaultProgressbar.
+			WithTotal(totalKB).
+			WithTitle(fmt.Sprintf("Downloading %s (%.1f MB)", assetName, float64(totalBytes)/1024/1024)).
+			Start()
+		pw := &progressWriter{bar: bar}
+		_, err = io.Copy(tmp, io.TeeReader(limited, pw))
+		_, _ = bar.Stop()
+	} else {
+		// Content-Length unknown — fall back to spinner
+		spinner, _ := pterm.DefaultSpinner.Start(fmt.Sprintf("Downloading %s...", assetName))
+		_, err = io.Copy(tmp, limited)
+		if err != nil {
+			spinner.Fail("Download failed")
+		} else {
+			spinner.Success("Downloaded")
+		}
+	}
+
+	if err != nil {
 		_ = os.Remove(tmp.Name())
 		return "", err
 	}

install.sh

@@ -109,9 +109,15 @@ resolve_version() {
     info "Fetching latest stable release..."
     LATEST_URL="https://api.github.com/repos/${GITHUB_REPO}/releases/latest"
     if command -v curl > /dev/null 2>&1; then
-        VERSION="$(curl -fsSL "${LATEST_URL}" | grep '"tag_name"' | sed 's/.*"tag_name": *"\([^"]*\)".*/\1/')"
+        RELEASE_JSON="$(curl -fsSL --retry 3 "${LATEST_URL}" 2>&1)" || {
+            fatal "No stable release found. If you want the nightly build, run:\n  curl -sfL https://raw.githubusercontent.com/${GITHUB_REPO}/main/install.sh | CREATEOS_CHANNEL=nightly sh -"
+        }
+        VERSION="$(printf '%s' "${RELEASE_JSON}" | grep '"tag_name"' | sed 's/.*"tag_name": *"\([^"]*\)".*/\1/')"
     elif command -v wget > /dev/null 2>&1; then
-        VERSION="$(wget -qO- "${LATEST_URL}" | grep '"tag_name"' | sed 's/.*"tag_name": *"\([^"]*\)".*/\1/')"
+        RELEASE_JSON="$(wget -qO- "${LATEST_URL}")" || {
+            fatal "No stable release found. If you want the nightly build, run:\n  curl -sfL https://raw.githubusercontent.com/${GITHUB_REPO}/main/install.sh | CREATEOS_CHANNEL=nightly sh -"
+        }
+        VERSION="$(printf '%s' "${RELEASE_JSON}" | grep '"tag_name"' | sed 's/.*"tag_name": *"\([^"]*\)".*/\1/')"
     else
         fatal "curl or wget is required to download createos."
     fi
@@ -169,9 +175,11 @@ resolve_install_dir() {
 }
 
 # ---------------------------------------------------------------------------
-# Download helper (curl or wget)
+# Download helpers (curl or wget)
 # ---------------------------------------------------------------------------
-download() {
+
+# download_silent: no progress output — used for small files (checksums, API calls)
+download_silent() {
     URL="$1"
     DEST="$2"
     if command -v curl > /dev/null 2>&1; then
@@ -183,6 +191,19 @@ download() {
     fi
 }
 
+# download_progress: shows progress bar — used for the binary
+download_progress() {
+    URL="$1"
+    DEST="$2"
+    if command -v curl > /dev/null 2>&1; then
+        curl -fL --retry 3 --retry-delay 2 --progress-bar -o "${DEST}" "${URL}"
+    elif command -v wget > /dev/null 2>&1; then
+        wget --show-progress -qO "${DEST}" "${URL}" 2>&1
+    else
+        fatal "curl or wget is required."
+    fi
+}
+
 # ---------------------------------------------------------------------------
 # Verify SHA256 checksum
 # ---------------------------------------------------------------------------
@@ -230,11 +251,10 @@ install_binary() {
     trap 'rm -rf "${TMP_DIR}"' EXIT
 
     info "Downloading ${ASSET}..."
-    download "${BINARY_URL}" "${TMP_BINARY}" \
+    download_progress "${BINARY_URL}" "${TMP_BINARY}" \
         || fatal "Failed to download binary from ${BINARY_URL}"
 
-    info "Downloading checksum..."
-    download "${CHECKSUM_URL}" "${TMP_CHECKSUM}" \
+    download_silent "${CHECKSUM_URL}" "${TMP_CHECKSUM}" \
         || fatal "Failed to download checksum from ${CHECKSUM_URL}"
 
     EXPECTED_HASH="$(cat "${TMP_CHECKSUM}" | tr -d '[:space:]')"