Skip to content

Commit 4e5ac69

Browse files
committed
removing return None statement
1 parent 116042a commit 4e5ac69

1 file changed

Lines changed: 3 additions & 108 deletions

File tree

KCSD.py

Lines changed: 3 additions & 108 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,6 @@ def validate(self, ele_pos, pots):
4141
positions of electrodes
4242
pots : numpy array
4343
potentials measured by electrodes
44-
45-
Returns
46-
-------
47-
None
4844
"""
4945
if ele_pos.shape[0] != pots.shape[0]:
5046
raise Exception("Number of measured potentials is not equal "
@@ -54,7 +50,6 @@ def validate(self, ele_pos, pots):
5450
1+ele_pos.shape[1])
5551
if utils.check_for_duplicated_electrodes(ele_pos) is False:
5652
raise Exception("Error! Duplicated electrode!")
57-
return
5853

5954
def sanity(self, true_csd, pos_csd):
6055
"""Useful for comparing TrueCSD with reconstructed CSD. Computes, the RMS error
@@ -97,10 +92,6 @@ def parameters(self, **kwargs):
9792
----------
9893
**kwargs
9994
Same as those passed to initialize the Class
100-
101-
Returns
102-
-------
103-
None
10495
"""
10596
self.src_type = kwargs.pop('src_type', 'gauss')
10697
self.sigma = kwargs.pop('sigma', 1.0)
@@ -124,7 +115,6 @@ def parameters(self, **kwargs):
124115
self.gdz = kwargs.pop('gdz', 0.01*(self.zmax - self.zmin))
125116
if kwargs:
126117
raise TypeError('Invalid keyword arguments:', kwargs.keys())
127-
return
128118

129119
def method(self):
130120
"""Actual sequence of methods called for KCSD
@@ -134,32 +124,23 @@ def method(self):
134124
Parameters
135125
----------
136126
None
137-
138-
Returns
139-
-------
140-
None
141127
"""
142128
self.create_lookup() #Look up table
143129
self.update_b_pot() #update kernel
144130
self.update_b_src() #update crskernel
145131
self.update_b_interp_pot() #update pot interp
146-
return
147132

148133
def create_lookup(self, dist_table_density=20):
149134
"""Creates a table for easy potential estimation from CSD.
150135
Updates and Returns the potentials due to a
151136
given basis source like a lookup
152-
table whose shape=(dist_table_density,)--> set in KCSD2D_Helpers.py
137+
table whose shape=(dist_table_density,)
153138
154139
Parameters
155140
----------
156141
dist_table_density : int
157142
number of distance values at which potentials are computed.
158143
Default 100
159-
160-
Returns
161-
-------
162-
None
163144
"""
164145
xs = np.logspace(0., np.log10(self.dist_max+1.), dist_table_density)
165146
xs = xs - 1.0 #starting from 0
@@ -171,7 +152,6 @@ def create_lookup(self, dist_table_density=20):
171152
self.sigma,
172153
self.basis)
173154
self.interpolate_pot_at = interpolate.interp1d(xs, dist_table, kind='cubic')
174-
return
175155

176156
def update_b_pot(self):
177157
"""Updates the b_pot - array is (#_basis_sources, #_electrodes)
@@ -184,15 +164,10 @@ def update_b_pot(self):
184164
Parameters
185165
----------
186166
None
187-
188-
Returns
189-
-------
190-
None
191167
"""
192168
self.b_pot = self.interpolate_pot_at(self.src_ele_dists)
193169
self.k_pot = np.dot(self.b_pot.T, self.b_pot) #K(x,x') Eq9,Jan2012
194170
self.k_pot /= self.n_src
195-
return
196171

197172
def update_b_src(self):
198173
"""Updates the b_src in the shape of (#_est_pts, #_basis_sources)
@@ -204,15 +179,10 @@ def update_b_src(self):
204179
Parameters
205180
----------
206181
None
207-
208-
Returns
209-
-------
210-
None
211182
"""
212183
self.b_src = self.basis(self.src_estm_dists, self.R).T
213184
self.k_interp_cross = np.dot(self.b_src, self.b_pot) #K_t(x,y) Eq17
214185
self.k_interp_cross /= self.n_src
215-
return
216186

217187
def update_b_interp_pot(self):
218188
"""Compute the matrix of potentials generated by every source
@@ -223,15 +193,10 @@ def update_b_interp_pot(self):
223193
Parameters
224194
----------
225195
None
226-
227-
Returns
228-
-------
229-
None
230196
"""
231197
self.b_interp_pot = self.interpolate_pot_at(self.src_estm_dists).T
232198
self.k_interp_pot = np.dot(self.b_interp_pot, self.b_pot)
233199
self.k_interp_pot /= self.n_src
234-
return
235200

236201
def values(self, estimate='CSD'):
237202
"""Computes the values of the quantity of interest
@@ -284,35 +249,25 @@ def process_estimate(self, estimation):
284249
return estimation
285250

286251
def update_R(self, R):
287-
"""Used in Cross validation
252+
"""Update the width of the basis fuction - Used in Cross validation
288253
289254
Parameters
290255
----------
291256
R : float
292-
293-
Returns
294-
-------
295-
None
296257
"""
297258
self.R = R
298259
self.dist_max = max(np.max(self.src_ele_dists),
299260
np.max(self.src_estm_dists)) + self.R
300261
self.method()
301-
return
302262

303263
def update_lambda(self, lambd):
304-
"""Used in Cross validation
264+
"""Update the lambda parameter of regularization, Used in Cross validation
305265
306266
Parameters
307267
----------
308268
lambd : float
309-
310-
Returns
311-
-------
312-
None
313269
"""
314270
self.lambd = lambd
315-
return
316271

317272
def cross_validate(self, lambdas=None, Rs=None):
318273
"""Method defines the cross validation.
@@ -441,10 +396,6 @@ def __init__(self, ele_pos, pots, **kwargs):
441396
regularization parameter for ridge regression
442397
Defaults to 0.
443398
444-
Returns
445-
-------
446-
None
447-
448399
Raises
449400
------
450401
LinAlgException
@@ -464,16 +415,11 @@ def estimate_at(self):
464415
Parameters
465416
----------
466417
None
467-
468-
Returns
469-
-------
470-
None
471418
"""
472419
nx = (self.xmax - self.xmin)/self.gdx
473420
self.estm_x = np.mgrid[self.xmin:self.xmax:np.complex(0,nx)]
474421
self.n_estm = self.estm_x.size
475422
self.ngx = self.estm_x.shape[0]
476-
return
477423

478424
def place_basis(self):
479425
"""Places basis sources of the defined type.
@@ -489,10 +435,6 @@ def place_basis(self):
489435
Parameters
490436
----------
491437
None
492-
493-
Returns
494-
-------
495-
None
496438
"""
497439
source_type = self.src_type
498440
try:
@@ -506,18 +448,13 @@ def place_basis(self):
506448
self.R_init )
507449
self.n_src = self.src_x.size
508450
self.nsx = self.src_x.shape
509-
return
510451

511452
def create_src_dist_tables(self):
512453
"""Creates distance tables between sources, electrode and estm points
513454
514455
Parameters
515456
----------
516457
None
517-
518-
Returns
519-
-------
520-
None
521458
"""
522459
src_loc = np.array((self.src_x.ravel()))
523460
src_loc = src_loc.reshape((len(src_loc), 1))
@@ -526,7 +463,6 @@ def create_src_dist_tables(self):
526463
self.src_ele_dists = distance.cdist(src_loc, self.ele_pos, 'euclidean')
527464
self.src_estm_dists = distance.cdist(src_loc, est_loc, 'euclidean')
528465
self.dist_max = max(np.max(self.src_ele_dists), np.max(self.src_estm_dists)) + self.R
529-
return
530466

531467
def forward_model(self, x, R, h, sigma, src_type):
532468
"""FWD model functions
@@ -631,10 +567,6 @@ def __init__(self, ele_pos, pots, **kwargs):
631567
regularization parameter for ridge regression
632568
Defaults to 0.
633569
634-
Returns
635-
-------
636-
None
637-
638570
Raises
639571
------
640572
LinAlgError
@@ -654,18 +586,13 @@ def estimate_at(self):
654586
Parameters
655587
----------
656588
None
657-
658-
Returns
659-
-------
660-
None
661589
"""
662590
nx = (self.xmax - self.xmin)/self.gdx
663591
ny = (self.ymax - self.ymin)/self.gdy
664592
self.estm_x, self.estm_y = np.mgrid[self.xmin:self.xmax:np.complex(0,nx),
665593
self.ymin:self.ymax:np.complex(0,ny)]
666594
self.n_estm = self.estm_x.size
667595
self.ngx, self.ngy = self.estm_x.shape
668-
return
669596

670597
def place_basis(self):
671598
"""Places basis sources of the defined type.
@@ -681,10 +608,6 @@ def place_basis(self):
681608
Parameters
682609
----------
683610
None
684-
685-
Returns
686-
-------
687-
None
688611
"""
689612
source_type = self.src_type
690613
try:
@@ -700,25 +623,19 @@ def place_basis(self):
700623
self.R_init )
701624
self.n_src = self.src_x.size
702625
self.nsx, self.nsy = self.src_x.shape
703-
return
704626

705627
def create_src_dist_tables(self):
706628
"""Creates distance tables between sources, electrode and estm points
707629
708630
Parameters
709631
----------
710632
None
711-
712-
Returns
713-
-------
714-
None
715633
"""
716634
src_loc = np.array((self.src_x.ravel(), self.src_y.ravel()))
717635
est_loc = np.array((self.estm_x.ravel(), self.estm_y.ravel()))
718636
self.src_ele_dists = distance.cdist(src_loc.T, self.ele_pos, 'euclidean')
719637
self.src_estm_dists = distance.cdist(src_loc.T, est_loc.T, 'euclidean')
720638
self.dist_max = max(np.max(self.src_ele_dists), np.max(self.src_estm_dists)) + self.R
721-
return
722639

723640
def forward_model(self, x, R, h, sigma, src_type):
724641
"""FWD model functions
@@ -833,9 +750,6 @@ def __init__(self, ele_pos, pots, **kwargs):
833750
MoI_iters : int
834751
Number of interations in method of images.
835752
Default is 20
836-
Returns
837-
-------
838-
None
839753
"""
840754
self.MoI_iters = kwargs.pop('MoI_iters', 20)
841755
self.sigma_S = kwargs.pop('sigma_S', 5.0)
@@ -957,10 +871,6 @@ def __init__(self, ele_pos, pots, **kwargs):
957871
regularization parameter for ridge regression
958872
Defaults to 0.
959873
960-
Returns
961-
-------
962-
None
963-
964874
Raises
965875
------
966876
LinAlgError
@@ -980,10 +890,6 @@ def estimate_at(self):
980890
Parameters
981891
----------
982892
None
983-
984-
Returns
985-
-------
986-
None
987893
"""
988894
nx = (self.xmax - self.xmin)/self.gdx
989895
ny = (self.ymax - self.ymin)/self.gdy
@@ -993,7 +899,6 @@ def estimate_at(self):
993899
self.zmin:self.zmax:np.complex(0,nz)]
994900
self.n_estm = self.estm_x.size
995901
self.ngx, self.ngy, self.ngz = self.estm_x.shape
996-
return
997902

998903
def place_basis(self):
999904
"""Places basis sources of the defined type.
@@ -1009,10 +914,6 @@ def place_basis(self):
1009914
Parameters
1010915
----------
1011916
None
1012-
1013-
Returns
1014-
-------
1015-
None
1016917
"""
1017918
source_type = self.src_type
1018919
try:
@@ -1031,18 +932,13 @@ def place_basis(self):
1031932

1032933
self.n_src = self.src_x.size
1033934
self.nsx, self.nsy, self.nsz = self.src_x.shape
1034-
return
1035935

1036936
def create_src_dist_tables(self):
1037937
"""Creates distance tables between sources, electrode and estm points
1038938
1039939
Parameters
1040940
----------
1041941
None
1042-
1043-
Returns
1044-
-------
1045-
None
1046942
"""
1047943
src_loc = np.array((self.src_x.ravel(),
1048944
self.src_y.ravel(),
@@ -1053,7 +949,6 @@ def create_src_dist_tables(self):
1053949
self.src_ele_dists = distance.cdist(src_loc.T, self.ele_pos, 'euclidean')
1054950
self.src_estm_dists = distance.cdist(src_loc.T, est_loc.T, 'euclidean')
1055951
self.dist_max = max(np.max(self.src_ele_dists), np.max(self.src_estm_dists)) + self.R
1056-
return
1057952

1058953
def forward_model(self, x, R, h, sigma, src_type):
1059954
"""FWD model functions

0 commit comments

Comments
 (0)