From c1746637b840049e14029c52d5a956d7922194dc Mon Sep 17 00:00:00 2001 From: Cory Rylan Date: Fri, 31 Jul 2026 15:40:34 -0500 Subject: [PATCH] fix(core): size height calculation - only set explicit computed height when size is applied, prevents specificity and rounding errors on standard single selects Signed-off-by: Cory Rylan --- projects/core/.visual/pagination.dark.png | 4 ++-- projects/core/.visual/pagination.png | 4 ++-- projects/core/.visual/select.dark.png | 4 ++-- projects/core/.visual/select.png | 4 ++-- projects/core/src/select/select.css | 8 ++++++-- 5 files changed, 14 insertions(+), 10 deletions(-) diff --git a/projects/core/.visual/pagination.dark.png b/projects/core/.visual/pagination.dark.png index 1358893f9..a14fb4933 100644 --- a/projects/core/.visual/pagination.dark.png +++ b/projects/core/.visual/pagination.dark.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:250a084f548e8deb75819f8be3c4c82b8969c41c1949d3ab643a20f2569813b0 -size 15903 +oid sha256:640e83f556161ce3881611f5d145befc3cec50d5d64f00227f403e04aaa69b9c +size 15770 diff --git a/projects/core/.visual/pagination.png b/projects/core/.visual/pagination.png index 06768f636..66a346660 100644 --- a/projects/core/.visual/pagination.png +++ b/projects/core/.visual/pagination.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:087ae06f0a3d0ff4f794542a6c070028b7101944b27c9e99728853952717005e -size 15337 +oid sha256:1fa7669b7ccb636b048c54a0fea7e375e39716c47de9bbb9c05de25cac019d41 +size 15208 diff --git a/projects/core/.visual/select.dark.png b/projects/core/.visual/select.dark.png index b8a19c51c..08f7b9086 100644 --- a/projects/core/.visual/select.dark.png +++ b/projects/core/.visual/select.dark.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:f416092d0c6cc6b78e0f45a5a41744fe25b00f895b6c1aae9903810bb09a7bbd -size 54914 +oid sha256:2f7d61859b1fe6bfdf88f7d9372430076047ecf1acf88340ffff6f6e06e1db38 +size 54656 diff --git a/projects/core/.visual/select.png b/projects/core/.visual/select.png index 254bc5002..0a7fd3bdd 100644 --- a/projects/core/.visual/select.png +++ b/projects/core/.visual/select.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:60bb957f7720434f776cc5089733a2818d657c69cf46d12572e8f51e841ecdd6 -size 51555 +oid sha256:9b5a086676af009876702a974509cb59b6455df89dd9bf133db978a63fdfb66c +size 51212 diff --git a/projects/core/src/select/select.css b/projects/core/src/select/select.css index cc2aa282e..b19941094 100644 --- a/projects/core/src/select/select.css +++ b/projects/core/src/select/select.css @@ -23,8 +23,7 @@ --_icon-color: var(--color); --_gap: var(--gap); --size: 1; - --_row-height: calc(var(--height) * var(--size) + var(--gap) * (var(--size) - 1)); - --_height: calc(var(--_row-height) + var(--nve-ref-border-width-md) * 2); + --_height: var(--height); contain: initial; width: var(--width); max-width: var(--max-width); @@ -139,6 +138,11 @@ opacity: 0 !important; } +:host(:state(size)) { + --_row-height: calc(var(--height) * var(--size) + var(--gap) * (var(--size) - 1)); + --_height: calc(var(--_row-height) + var(--nve-ref-border-width-md) * 2); +} + :host(:state(size)) [input] { overflow: auto; display: block;