Skip to content

Commit 1bfdf64

Browse files
committed
fix: select one docs metapackage for dependent tags [skip ci]
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
1 parent fe26e2c commit 1bfdf64

2 files changed

Lines changed: 18 additions & 1 deletion

File tree

‎ci/tools/download-wheels‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,10 +87,12 @@ else
8787
ARTIFACT_PATTERN="${COMPONENT}*"
8888
fi
8989

90+
# Dependent-tag docs also select one metapackage using the resolved toolkit.
9091
IS_BINDINGS_RELEASE=false
9192
if [[ "$COMPONENT" != "all" \
9293
&& "$COMPONENT" =~ ^cuda-(bindings|python)$ \
93-
&& "$GIT_TAG" == v* ]]; then
94+
&& ( "$GIT_TAG" == v* \
95+
|| ( "$COMPONENT" == "cuda-python" && -n "$RESOLVED_BINDINGS_PACKAGE_JSON" ) ) ]]; then
9496
IS_BINDINGS_RELEASE=true
9597
fi
9698

‎ci/tools/tests/test_download_wheels.py‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,21 @@ def test_release_stages_only_wheels_for_its_exact_toolkit(tmp_path, component, m
7979
assert {path.name for path in (tmp_path / "dist").iterdir()} == {f"{expected}.whl"}
8080

8181

82+
@pytest.mark.parametrize("tag", ["cuda-core-v1.3.0", "cuda-pathfinder-v1.5.0"])
83+
@pytest.mark.agent_authored(model="gpt-6")
84+
def test_dependent_tag_docs_stage_one_metapackage_for_resolved_toolkit(tmp_path, tag):
85+
expected = "cuda-python-wheel-cuda13.4.2"
86+
result = run_download(
87+
tmp_path,
88+
["cuda-python-wheel-cuda12.9.1", expected],
89+
"cuda-python",
90+
package={"toolkit_version": "13.4.2"},
91+
tag=tag,
92+
)
93+
assert result.returncode == 0, result.stderr
94+
assert {path.name for path in (tmp_path / "dist").iterdir()} == {f"{expected}.whl"}
95+
96+
8297
@pytest.mark.parametrize("component", ["cuda-bindings", "cuda-python"])
8398
@pytest.mark.agent_authored(model="gpt-6.1-sol")
8499
def test_release_cannot_stage_another_toolkit_or_test_artifacts(tmp_path, component):

0 commit comments

Comments
 (0)