CCM-9689: Fix lambda descriptions for variables and outputs

sidnhs · sidnhs · commit c9a4ae3988ff · 2025-05-28T11:58:44.000+01:00
diff --git a/infrastructure/modules/amp_branch/outputs.tf b/infrastructure/modules/amp_branch/outputs.tf
@@ -1,4 +1,4 @@
 output "name" {
   description = "Name of the Amplify branch"
-  value = aws_amplify_branch.main.branch_name
+  value       = aws_amplify_branch.main.branch_name
 }
diff --git a/infrastructure/modules/amp_branch/variables.tf b/infrastructure/modules/amp_branch/variables.tf
@@ -68,7 +68,7 @@ variable "branch" {
 variable "display_name" {
   description = "The display name of the branch app being deployed"
   type        = string
-  default = null
+  default     = null
 }
 
 variable "enable_auto_build" {
diff --git a/infrastructure/modules/aws-backup-source/backup_plan_dynamodb.tf b/infrastructure/modules/aws-backup-source/backup_plan_dynamodb.tf
@@ -2,7 +2,7 @@
 resource "aws_backup_plan" "dynamodb" {
   count = var.backup_plan_config_dynamodb.enable ? 1 : 0
 
-  name  = "${local.csi}-dynamodb"
+  name = "${local.csi}-dynamodb"
 
   dynamic "rule" {
     for_each = var.backup_plan_config_dynamodb.rules
diff --git a/infrastructure/modules/aws-backup-source/backup_report_plan_copy_jobs.tf b/infrastructure/modules/aws-backup-source/backup_report_plan_copy_jobs.tf
@@ -1,5 +1,5 @@
 resource "aws_backup_report_plan" "copy_jobs" {
-  count       = var.backup_copy_vault_arn != "" && var.backup_copy_vault_account_id != "" ? 1 : 0
+  count = var.backup_copy_vault_arn != "" && var.backup_copy_vault_account_id != "" ? 1 : 0
 
   name        = "${local.csi_underscore}_copy_jobs"
   description = "Report for showing whether copies ran successfully in the last 24 hours"
diff --git a/infrastructure/modules/aws-backup-source/backup_report_plan_resource_compliance.tf b/infrastructure/modules/aws-backup-source/backup_report_plan_resource_compliance.tf
@@ -3,7 +3,7 @@ resource "aws_backup_report_plan" "resource_compliance" {
   description = "Report for showing whether resources are compliant with the framework"
 
   report_delivery_channel {
-    formats = ["JSON"]
+    formats        = ["JSON"]
     s3_bucket_name = var.reports_bucket
     s3_key_prefix  = "resource_compliance"
   }
@@ -19,6 +19,6 @@ resource "aws_backup_report_plan" "resource_compliance" {
       var.backup_plan_config_s3.enable ? [aws_backup_framework.s3[0].arn] : []
     ))
 
-    report_template      = "RESOURCE_COMPLIANCE_REPORT"
+    report_template = "RESOURCE_COMPLIANCE_REPORT"
   }
 }
diff --git a/infrastructure/modules/aws-backup-source/iam_role_backup.tf b/infrastructure/modules/aws-backup-source/iam_role_backup.tf
@@ -1,5 +1,5 @@
 resource "aws_iam_role" "backup" {
-  name               = "${local.csi}"
+  name               = local.csi
   assume_role_policy = data.aws_iam_policy_document.assume_role.json
 }
 
diff --git a/infrastructure/modules/aws-backup-source/locals.tf b/infrastructure/modules/aws-backup-source/locals.tf
@@ -9,12 +9,12 @@ locals {
     var.name
   )
 
-  csi_underscore = replace(local.csi,"-","_")
+  csi_underscore = replace(local.csi, "-", "_")
 
   default_tags = merge(
     var.default_tags,
     {
-      Name = local.csi
+      Name   = local.csi
       Module = local.module
     },
   )
diff --git a/infrastructure/modules/eventpub/archive_file_lambda.tf b/infrastructure/modules/eventpub/archive_file_lambda.tf
@@ -1,6 +1,6 @@
 resource "archive_file" "lambda" {
-  type        = "zip"
-  source_dir  = "${path.module}/lambda/eventpub/src"
+  type       = "zip"
+  source_dir = "${path.module}/lambda/eventpub/src"
 
   # Timestamp in path to resolve https://github.com/hashicorp/terraform-provider-archive/issues/39
   output_path = "${path.module}/lambda/eventpub_${timestamp()}.zip"
diff --git a/infrastructure/modules/eventpub/iam_role_lambda.tf b/infrastructure/modules/eventpub/iam_role_lambda.tf
@@ -67,7 +67,7 @@ data "aws_iam_policy_document" "lambda" {
     ]
   }
 
-    statement {
+  statement {
     sid    = "DLQPutMessage"
     effect = "Allow"
 
diff --git a/infrastructure/modules/kms/outputs.tf b/infrastructure/modules/kms/outputs.tf
@@ -1,19 +1,19 @@
 output "key_arn" {
   description = "ARN of the KMS key"
-  value = aws_kms_key.main.arn
+  value       = aws_kms_key.main.arn
 }
 
 output "key_id" {
   description = "ID of the KMS key"
-  value = aws_kms_key.main.key_id
+  value       = aws_kms_key.main.key_id
 }
 
 output "admin_policy_arn" {
   description = "ARN of the admin IAM policy"
-  value = aws_iam_policy.admin.arn
+  value       = aws_iam_policy.admin.arn
 }
 
 output "user_policy_arn" {
   description = "ARN of the user IAM policy"
-  value = aws_iam_policy.user.arn
+  value       = aws_iam_policy.user.arn
 }
diff --git a/infrastructure/modules/lambda/outputs.tf b/infrastructure/modules/lambda/outputs.tf
@@ -1,39 +1,39 @@
 output "function_name" {
   description = "Name of the Lambda function"
-  value = aws_lambda_function.main.function_name
+  value       = aws_lambda_function.main.function_name
 }
 
 output "function_arn" {
   description = "ARN of the Lambda function"
-  value = aws_lambda_function.main.arn
+  value       = aws_lambda_function.main.arn
 }
 
 output "function_invoke_arn" {
   description = "Invoke ARN of the Lambda function"
-  value = aws_lambda_function.main.invoke_arn
+  value       = aws_lambda_function.main.invoke_arn
 }
 
 output "function_qualified_arn" {
   description = "Qualified ARN of the Lambda function, including version or alias"
-  value = aws_lambda_function.main.qualified_arn
+  value       = aws_lambda_function.main.qualified_arn
 }
 
 output "function_env_vars" {
   description = "Environment variables for the Lambda function"
-  value = length(var.lambda_env_vars) == 0 ? {} : aws_lambda_function.main.environment[0].variables
+  value       = length(var.lambda_env_vars) == 0 ? {} : aws_lambda_function.main.environment[0].variables
 }
 
 output "iam_role_name" {
   description = "Name of the IAM role associated with the Lambda function"
-  value = aws_iam_role.main.name
+  value       = aws_iam_role.main.name
 }
 
 output "iam_role_arn" {
   description = "ARN of the IAM role associated with the Lambda function"
-  value = aws_iam_role.main.arn
+  value       = aws_iam_role.main.arn
 }
 
 output "cloudwatch_log_group_name" {
   description = "Name of the CloudWatch Log Group for the Lambda function"
-  value = aws_cloudwatch_log_group.main.name
+  value       = aws_cloudwatch_log_group.main.name
 }
diff --git a/infrastructure/modules/obs-datasource/variables.tf b/infrastructure/modules/obs-datasource/variables.tf
@@ -73,7 +73,7 @@ variable "metric_configuration" {
 }
 
 variable "resource_types" {
-  type = list(string)
+  type        = list(string)
   description = "The resource types to include in the OAM link."
   default = [
     "AWS::CloudWatch::Metric",
diff --git a/infrastructure/modules/s3bucket/outputs.tf b/infrastructure/modules/s3bucket/outputs.tf
@@ -1,44 +1,44 @@
 output "acl" {
   description = "The ACL of the S3 bucket. If the object ownership is set to 'BucketOwnerEnforced', the ACL will be 'private'. Otherwise, it will reflect the ACL set in the aws_s3_bucket_acl resource."
-  value = var.object_ownership == "BucketOwnerEnforced" ? "private" : aws_s3_bucket_acl.main[0].acl
+  value       = var.object_ownership == "BucketOwnerEnforced" ? "private" : aws_s3_bucket_acl.main[0].acl
 }
 
 output "arn" {
   description = "The ARN of the S3 bucket"
-  value = aws_s3_bucket.main.arn
+  value       = aws_s3_bucket.main.arn
 }
 
 output "bucket" {
   description = "The name of the S3 bucket"
-  value = aws_s3_bucket.main.bucket
+  value       = aws_s3_bucket.main.bucket
 }
 
 output "bucket_domain_name" {
   description = "The domain name of the S3 bucket"
-  value = aws_s3_bucket.main.bucket_domain_name
+  value       = aws_s3_bucket.main.bucket_domain_name
 }
 
 output "bucket_regional_domain_name" {
   description = "The regional domain name of the S3 bucket"
-  value = aws_s3_bucket.main.bucket_regional_domain_name
+  value       = aws_s3_bucket.main.bucket_regional_domain_name
 }
 
 output "hosted_zone_id" {
   description = "The hosted zone ID of the S3 bucket"
-  value = aws_s3_bucket.main.hosted_zone_id
+  value       = aws_s3_bucket.main.hosted_zone_id
 }
 
 output "id" {
   description = "The ID of the S3 bucket"
-  value = aws_s3_bucket.main.id
+  value       = aws_s3_bucket.main.id
 }
 
 output "policy" {
   description = "The policy of the S3 bucket"
-  value = aws_s3_bucket_policy.main.policy
+  value       = aws_s3_bucket_policy.main.policy
 }
 
 output "region" {
   description = "The AWS region where the S3 bucket is located"
-  value = aws_s3_bucket.main.region
+  value       = aws_s3_bucket.main.region
 }
diff --git a/infrastructure/modules/sqs/outputs.tf b/infrastructure/modules/sqs/outputs.tf
@@ -1,29 +1,29 @@
 output "sqs_queue_url" {
   description = "The URL of the SQS queue"
-  value = aws_sqs_queue.sqs_queue.id
+  value       = aws_sqs_queue.sqs_queue.id
 }
 
 output "sqs_queue_arn" {
   description = "The ARN of the SQS queue"
-  value = aws_sqs_queue.sqs_queue.arn
+  value       = aws_sqs_queue.sqs_queue.arn
 }
 
 output "sqs_dlq_url" {
   description = "The URL of the SQS dead-letter queue"
-  value = var.create_dlq ? aws_sqs_queue.deadletter_queue[0].id : null
+  value       = var.create_dlq ? aws_sqs_queue.deadletter_queue[0].id : null
 }
 
 output "sqs_dlq_arn" {
   description = "The ARN of the SQS dead-letter queue"
-  value = var.create_dlq ? aws_sqs_queue.deadletter_queue[0].arn : null
+  value       = var.create_dlq ? aws_sqs_queue.deadletter_queue[0].arn : null
 }
 
 output "sqs_queue_name" {
   description = "The name of the SQS queue"
-  value = "${local.csi}-queue"
+  value       = "${local.csi}-queue"
 }
 
 output "sqs_dlq_name" {
   description = "The name of the SQS dead-letter queue"
-  value = var.create_dlq ? aws_sqs_queue.deadletter_queue[0].name : null
+  value       = var.create_dlq ? aws_sqs_queue.deadletter_queue[0].name : null
 }

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`	`1`	`output "name" {`
`2`	`2`	`description = "Name of the Amplify branch"`
`3`		`- value = aws_amplify_branch.main.branch_name`
	`3`	`+ value = aws_amplify_branch.main.branch_name`
`4`	`4`	`}`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ variable "branch" {`
`68`	`68`	`variable "display_name" {`
`69`	`69`	`description = "The display name of the branch app being deployed"`
`70`	`70`	`type = string`
`71`		`- default = null`
	`71`	`+ default = null`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`variable "enable_auto_build" {`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ resource "aws_backup_report_plan" "resource_compliance" {`
`3`	`3`	`description = "Report for showing whether resources are compliant with the framework"`
`4`	`4`
`5`	`5`	`report_delivery_channel {`
`6`		`- formats = ["JSON"]`
	`6`	`+ formats = ["JSON"]`
`7`	`7`	`s3_bucket_name = var.reports_bucket`
`8`	`8`	`s3_key_prefix = "resource_compliance"`
`9`	`9`	`}`
`@@ -19,6 +19,6 @@ resource "aws_backup_report_plan" "resource_compliance" {`
`19`	`19`	`var.backup_plan_config_s3.enable ? [aws_backup_framework.s3[0].arn] : []`
`20`	`20`	`))`
`21`	`21`
`22`		`- report_template = "RESOURCE_COMPLIANCE_REPORT"`
	`22`	`+ report_template = "RESOURCE_COMPLIANCE_REPORT"`
`23`	`23`	`}`
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`resource "aws_iam_role" "backup" {`
`2`		`- name = "${local.csi}"`
	`2`	`+ name = local.csi`
`3`	`3`	`assume_role_policy = data.aws_iam_policy_document.assume_role.json`
`4`	`4`	`}`
`5`	`5`
Original file line number	Diff line number	Diff line change
`@@ -9,12 +9,12 @@ locals {`
`9`	`9`	`var.name`
`10`	`10`	`)`
`11`	`11`
`12`		`- csi_underscore = replace(local.csi,"-","_")`
	`12`	`+ csi_underscore = replace(local.csi, "-", "_")`
`13`	`13`
`14`	`14`	`default_tags = merge(`
`15`	`15`	`var.default_tags,`
`16`	`16`	`{`
`17`		`- Name = local.csi`
	`17`	`+ Name = local.csi`
`18`	`18`	`Module = local.module`
`19`	`19`	`},`
`20`	`20`	`)`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ data "aws_iam_policy_document" "lambda" {`
`67`	`67`	`]`
`68`	`68`	`}`
`69`	`69`
`70`		`- statement {`
	`70`	`+ statement {`
`71`	`71`	`sid = "DLQPutMessage"`
`72`	`72`	`effect = "Allow"`
`73`	`73`
Original file line number	Diff line number	Diff line change
`@@ -1,19 +1,19 @@`
`1`	`1`	`output "key_arn" {`
`2`	`2`	`description = "ARN of the KMS key"`
`3`		`- value = aws_kms_key.main.arn`
	`3`	`+ value = aws_kms_key.main.arn`
`4`	`4`	`}`
`5`	`5`
`6`	`6`	`output "key_id" {`
`7`	`7`	`description = "ID of the KMS key"`
`8`		`- value = aws_kms_key.main.key_id`
	`8`	`+ value = aws_kms_key.main.key_id`
`9`	`9`	`}`
`10`	`10`
`11`	`11`	`output "admin_policy_arn" {`
`12`	`12`	`description = "ARN of the admin IAM policy"`
`13`		`- value = aws_iam_policy.admin.arn`
	`13`	`+ value = aws_iam_policy.admin.arn`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`output "user_policy_arn" {`
`17`	`17`	`description = "ARN of the user IAM policy"`
`18`		`- value = aws_iam_policy.user.arn`
	`18`	`+ value = aws_iam_policy.user.arn`
`19`	`19`	`}`