Merge pull request #150 from NHSDigital/CCM-14029_CentralisePrecommitGHAs

CCM-14029 centralise precommit gh as

Author: aidenvaines-cgi

.github/actions/check-english-usage/action.yaml

@@ -7,4 +7,4 @@ runs:
       shell: bash
       run: |
         export BRANCH_NAME=origin/${{ github.event.repository.default_branch }}
-        check=branch ./scripts/githooks/check-english-usage.sh
+        check=branch ${{ github.action_path }}/check-english-usage.sh

scripts/githooks/check-english-usage.sh …eck-english-usage/check-english-usage.shscripts/githooks/check-english-usage.sh renamed to .github/actions/check-english-usage/check-english-usage.sh scripts/githooks/check-english-usage.sh renamed to .github/actions/check-english-usage/check-english-usage.sh

@@ -7,4 +7,4 @@ runs:
       shell: bash
       run: |
         export BRANCH_NAME=origin/${{ github.event.repository.default_branch }}
-        check=branch ./scripts/githooks/check-file-format.sh
+        check=branch ${{ github.action_path }}/check-file-format.sh

.github/actions/check-file-format/action.yaml

@@ -7,4 +7,4 @@ runs:
       shell: bash
       run: |
         export BRANCH_NAME=origin/${{ github.event.repository.default_branch }}
-        check=branch ./scripts/githooks/check-markdown-format.sh
+        check=branch ${{ github.action_path }}/check-markdown-format.sh

scripts/githooks/check-file-format.sh …s/check-file-format/check-file-format.shscripts/githooks/check-file-format.sh renamed to .github/actions/check-file-format/check-file-format.sh scripts/githooks/check-file-format.sh renamed to .github/actions/check-file-format/check-file-format.sh

@@ -7,4 +7,4 @@ runs:
       shell: bash
       run: |
         export BRANCH_NAME=origin/${{ github.event.repository.default_branch }}
-        check=branch ./scripts/githooks/check-todos.sh
+        check=branch ${{ github.action_path }}/check-todos.sh

.github/actions/check-markdown-format/action.yaml

@@ -25,22 +25,39 @@ set -euo pipefail
 
 # ==============================================================================
 
-EXCLUDED_FILES=(
-  ".devcontainer/devcontainer.json"
-  ".tool-versions"
-  ".vscode/extensions.json"
-  "infrastructure/terraform/bin/terraform.sh"
-  "Makefile"
-  "project.code-workspace"
-  "src/jekyll-devcontainer/src/.devcontainer/devcontainer.json"
-)
-
-EXCLUDED_DIRS=(
-  ".git/"
-  ".venv/"
-  "docs/"
-  "node_modules/"
-)
+CONFIG_FILE="scripts/config/check-todos-ignore.conf"
+
+# Arrays to be populated from config file
+EXCLUDED_FILES=()
+EXCLUDED_DIRS=()
+
+
+# Load exclusions from configuration file
+function load_exclusions_from_config() {
+  local config_file="$1"
+  local section=""
+
+  while IFS= read -r line || [ -n "$line" ]; do
+    # Skip empty lines and comments
+    [[ -z "$line" || "$line" =~ ^[[:space:]]*# ]] && continue
+
+    # Check for section headers
+    if [[ "$line" =~ ^\[([^]]+)\]$ ]]; then
+      section="${BASH_REMATCH[1]}"
+      continue
+    fi
+
+    # Add entries to appropriate arrays based on current section
+    case "$section" in
+      files)
+        EXCLUDED_FILES+=("$line")
+        ;;
+      directories)
+        EXCLUDED_DIRS+=("$line")
+        ;;
+    esac
+  done < "$config_file"
+}
 
 
 # Get files to check based on mode
@@ -68,12 +85,7 @@ function get_files_to_check() {
 
 
 function build_exclude_args() {
-  local args=(
-    --exclude=".github/actions/check-todo-usage/action.yaml"
-    --exclude=".github/workflows/stage-1-commit.yaml"
-    --exclude="scripts/config/pre-commit.yaml"
-    --exclude="scripts/githooks/check-todos.sh"
-  ) # Exclude this script and its references by default, as it naturally contains TODOs. Todo todo todo <- see?
+  local args=() # Exclusions are now loaded from config file
 
   if [ ${#EXCLUDED_DIRS[@]} -gt 0 ]; then
     for dir in "${EXCLUDED_DIRS[@]}"; do
@@ -203,6 +215,9 @@ function print_output() {
 function main() {
   cd "$(git rev-parse --show-toplevel)"
 
+  # Load exclusions from config file
+  load_exclusions_from_config "$CONFIG_FILE"
+
   local check_mode="${check:-working-tree-changes}"
   local exclude_args=$(build_exclude_args)
   local todos=$(search_todos "$check_mode" $exclude_args)

scripts/githooks/check-markdown-format.sh …markdown-format/check-markdown-format.shscripts/githooks/check-markdown-format.sh renamed to .github/actions/check-markdown-format/check-markdown-format.sh scripts/githooks/check-markdown-format.sh renamed to .github/actions/check-markdown-format/check-markdown-format.sh

@@ -15,7 +15,7 @@ runs:
     - name: "Check Terraform format"
       shell: bash
       run: |
-        check_only=true scripts/githooks/check-terraform-format.sh
+        check_only=true ${{ github.action_path }}/check-terraform-format.sh
     - name: "Validate Terraform"
       shell: bash
       run: |