Merge pull request #126 from NHSDigital/feature/CCM-12059_Improve_Eventpub_Lambda_Build

CCM-12059: Improve Eventpub Lambda Build

Author: jamesthompson26-nhs

infrastructure/modules/eventpub/archive_file_lambda.tf

@@ -1,14 +1,15 @@
-resource "archive_file" "lambda" {
-  type       = "zip"
-  source_dir = "${path.module}/../../../lambda/eventpub/src"
+data "archive_file" "lambda" {
+  type        = "zip"
+  source_dir  = "${path.module}/lambda/eventpub/src"
+  output_path = "${path.module}/lambda/${local.csi}_eventpub.zip"
 
-  # Timestamp in path to resolve https://github.com/hashicorp/terraform-provider-archive/issues/39
-  output_path = "${path.module}/../../../lambda/eventpub_${timestamp()}.zip"
   excludes = [
     # NodeJS Exclusions
     "**/__tests__",
     "**/node_modules",
     "**/package.json",
     "**/package-lock.json",
   ]
+
+  depends_on = [null_resource.force_archive]
 }

infrastructure/modules/eventpub/lambda_function.tf

@@ -9,8 +9,8 @@ resource "aws_lambda_function" "main" {
   memory_size = 128
   timeout     = 20
 
-  filename         = archive_file.lambda.output_path
-  source_code_hash = archive_file.lambda.output_base64sha256
+  filename         = data.archive_file.lambda.output_path
+  source_code_hash = data.archive_file.lambda.output_base64sha256
 
   logging_config {
     application_log_level = var.log_level

infrastructure/modules/eventpub/null_resource_force_archive.tf

@@ -0,0 +1,9 @@
+resource "null_resource" "force_archive" {
+  triggers = {
+    always_run = timestamp()
+  }
+
+  provisioner "local-exec" {
+    command = "true"
+  }
+}