CCM-14410: Make the eventpub lambda handle unknown plane values

Author: gareth-allan

infrastructure/terraform/modules/eventpub/lambda/eventpub/src/__tests__/index.test.js

@@ -68,6 +68,19 @@ describe('SNS to EventBridge Lambda', () => {
         expect(sqsMock.calls()).toHaveLength(1);
     });
 
+    test('Event with unknown plane field is sent to DLQ', async () => {
+        const eventUnknownPlane = { ...validCloudEvent, plane: "unknown" };
+
+        const snsEventUnknownPlane = {
+            Records: [
+                { Sns: { Message: JSON.stringify(eventUnknownPlane) } }
+            ]
+        };
+
+        await handler(snsEventUnknownPlane);
+
+        expect(sqsMock.calls()).toHaveLength(1);
+    });
 
     test('Retries on EventBridge failure and sends failed events to DLQ', async () => {
       eventBridgeMock

infrastructure/terraform/modules/eventpub/lambda/eventpub/src/index.js

@@ -115,11 +115,12 @@ exports.handler = async (snsEvent) => {
 
     const dataEvents = validEvents.filter(event => event.plane === 'data');
     const controlEvents = validEvents.filter(event => event.plane === 'control');
+    const unknownEvents = validEvents.filter(event => event.plane !== 'data' && event.plane !== 'control');
 
-    console.debug(`Data events: ${dataEvents.length}, Control events: ${controlEvents.length}`);
+    console.debug(`Data events: ${dataEvents.length}, Control events: ${controlEvents.length}, Unknown events: ${unknownEvents.length}`);
 
     const failedDataEvents = await sendToEventBridge(dataEvents, DATA_PLANE_EVENT_BUS_ARN);
     const failedControlEvents = await sendToEventBridge(controlEvents, CONTROL_PLANE_EVENT_BUS_ARN);
 
-    await sendToDLQ([...failedDataEvents, ...failedControlEvents]);
+    await sendToDLQ([...failedDataEvents, ...failedControlEvents, ...unknownEvents]);
 };