CCM-10257: Implement Eventpub in Core

Author: jamesthompson26-nhs

infrastructure/modules/eventpub/README.md

@@ -11,7 +11,6 @@
 
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
-| <a name="input_alarm_prefixes"></a> [alarm\_prefixes](#input\_alarm\_prefixes) | Object containing prefixes for alarm descriptions, e.g. 'RELIABILITY:', 'SECURITY:', 'PERFORMANCE:' | <pre>object({<br/>    dlq          = string<br/>    sns_delivery = string<br/>    lambda       = string<br/>  })</pre> | <pre>{<br/>  "dlq": null,<br/>  "lambda": null,<br/>  "sns_delivery": null<br/>}</pre> | no |
 | <a name="input_aws_account_id"></a> [aws\_account\_id](#input\_aws\_account\_id) | The AWS Account ID (numeric) | `string` | n/a | yes |
 | <a name="input_component"></a> [component](#input\_component) | The name of the terraformscaffold component calling this module | `string` | n/a | yes |
 | <a name="input_control_plane_bus_arn"></a> [control\_plane\_bus\_arn](#input\_control\_plane\_bus\_arn) | Data plane event bus arn | `string` | n/a | yes |

infrastructure/modules/eventpub/cloudwatch_metric_alarm_dlq_alarm.tf

@@ -1,6 +1,6 @@
 resource "aws_cloudwatch_metric_alarm" "dlq_alarm" {
   alarm_name          = "${local.csi}-dlq-messages-alarm"
-  alarm_description   = "${var.alarm_prefixes.dlq} Alarm for messages in the DLQ"
+  alarm_description   = "RELIABILITY: Alarm for messages in the DLQ"
   comparison_operator = "GreaterThanThreshold"
   evaluation_periods  = 1
   metric_name         = "ApproximateNumberOfMessagesVisible"

infrastructure/modules/eventpub/cloudwatch_metric_alarm_lambda_errors.tf

@@ -1,6 +1,6 @@
 resource "aws_cloudwatch_metric_alarm" "lambda_errors" {
   alarm_name          = "${local.csi}-lambda-errors-alarm"
-  alarm_description   = "${var.alarm_prefixes.lambda} Alarm for Lambda function errors"
+  alarm_description   = "RELIABILITY: Alarm for Lambda function errors"
   comparison_operator = "GreaterThanOrEqualToThreshold"
   evaluation_periods  = 1
   metric_name         = "Errors"

infrastructure/modules/eventpub/cloudwatch_metric_alarm_sns_delivery_failures.tf

@@ -1,6 +1,6 @@
 resource "aws_cloudwatch_metric_alarm" "sns_delivery_failures" {
   alarm_name          = "${local.csi}-sns-delivery-failures"
-  alarm_description   = "${var.alarm_prefixes.sns_delivery} Alarm when SNS topic ${aws_sns_topic.main.name} has delivery failures"
+  alarm_description   = "RELIABILITY: Alarm for SNS topic delivery failures"
   comparison_operator = "GreaterThanThreshold"
   evaluation_periods  = 1
   metric_name         = "NumberOfNotificationsFailed"

infrastructure/modules/eventpub/variables.tf

@@ -114,17 +114,3 @@ variable "iam_permissions_boundary_arn" {
   description = "The ARN of the permissions boundary to use for the IAM role"
   default     = null
 }
-
-variable "alarm_prefixes" {
-  type = object({
-    dlq          = string
-    sns_delivery = string
-    lambda       = string
-  })
-  description = "Object containing prefixes for alarm descriptions, e.g. 'RELIABILITY:', 'SECURITY:', 'PERFORMANCE:'"
-  default = {
-    dlq          = null
-    sns_delivery = null
-    lambda       = null
-  }
-}