Merge pull request #96 from NHSDigital/feature/CCM-11097_Event_Validation

CCM-11097: Event Validation

Author: jamesthompson26-nhs

infrastructure/modules/eventpub/lambda/eventpub/src/index.js

@@ -30,22 +30,6 @@ function validateEvent(event) {
     if (!requiredFields.every(field => event.hasOwnProperty(field))) {
         return false;
     }
-    // Check nested data object and its required fields
-    const dataRequiredFields = [
-        'nhsNumber',
-        'delayedFallback',
-        'sendingGroupId',
-        'clientId',
-        'campaignId',
-        'supplierStatus',
-        'previousSupplierStatus'
-    ];
-    if (
-        typeof event.data !== 'object' ||
-        !dataRequiredFields.every(field => event.data.hasOwnProperty(field))
-    ) {
-        return false;
-    }
     return true;
 }
 

infrastructure/modules/lambda/cloudwatch_log_subscription_filter_firehose.tf

@@ -1,6 +1,6 @@
 resource "aws_cloudwatch_log_subscription_filter" "firehose" {
   count           = var.send_to_firehose ? 1 : 0 # Keeping this optional for now as don't want to break all lambdas using this, can make this mandatory later
-  name            = replace(aws_cloudwatch_log_group.main.name, "/", "-")
+  name            = trim(replace(aws_cloudwatch_log_group.main.name, "/", "-"), "-")
   log_group_name  = aws_cloudwatch_log_group.main.name
   filter_pattern  = var.filter_pattern
   destination_arn = var.log_destination_arn