fix test

Author: wildjames

packages/updatePrescriptionStatus/.jest/setEnvVars.js

@@ -1,4 +1,3 @@
 /* eslint-disable no-undef */
-process.env.TABLE_NAME = "dummy_table";
 process.env.NHS_NOTIFY_PRESCRIPTIONS_SQS_QUEUE_URL = "dummy_notify_sqs";
 process.env.AWS_REGION = "eu-west-2";

packages/updatePrescriptionStatus/src/utils/sqsClient.ts

@@ -1,7 +1,8 @@
+import {Logger} from "@aws-lambda-powertools/logger"
 import {SQSClient, SendMessageBatchCommand} from "@aws-sdk/client-sqs"
+
 import {v4} from "uuid"
 
-import {Logger} from "@aws-lambda-powertools/logger"
 import {DataItem} from "../updatePrescriptionStatus"
 
 const sqsUrl = process.env.NHS_NOTIFY_PRESCRIPTIONS_SQS_QUEUE_URL
@@ -37,11 +38,9 @@ export async function pushPrescriptionToNotificationSQS(data: Array<DataItem>, l
   const batches = chunkArray(data, 10)
 
   for (const batch of batches) {
-    // Create SQS entries. Each message is required to have an unique Id string.
-    // TODO: I'm creating a new UUID here, but am I safe to use the lineID? It looks like it should be unique
+    // Create SQS messages. For each message, generate a new UUID
     const entries = batch.map((item) => ({
       Id: v4().toUpperCase(),
-      // Id: item.LineItemID || v4().toUpperCase(),
       MessageBody: JSON.stringify(item)
     }))
 

packages/updatePrescriptionStatus/tests/testHandler.test.ts

@@ -39,7 +39,9 @@ import {QueryCommand, TransactionCanceledException, TransactWriteItemsCommand} f
 
 const {mockSend: dynamoDBMockSend} = mockDynamoDBClient()
 const {mockSend: sqsMockSend} = mockSQSClient()
+
 const {handler, logger} = await import("../src/updatePrescriptionStatus")
+
 const LAMBDA_TIMEOUT_MS = 9500 // 9.5 sec
 
 describe("Integration tests for updatePrescriptionStatus handler", () => {