Skip to content

Commit 8b4d984

Browse files
authored
Chore: [AEA-0000] - Default to using the app ID. Populate the parameter with the enabled suppliers (#2970)
## Summary - ⚠️ Potential issues that might be caused by this change ### Details This PR updates the environment variable flag so that all environments use application ID by default. It also populates the application IDs for PROD, but does not do so for any other environment. When this is deployed, we MUST check that the number of notifications being sent per minute is unaffected. Use this splunk query to do that: TODO
1 parent 3ea60be commit 8b4d984

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ jobs:
415415
ENABLE_POST_DATED_NOTIFICATIONS: false
416416
ENABLED_SYSTEMS: "CrxPatientApp"
417417
BLOCKED_SITE_ODS_CODES: "XXXXX" # Workaround empty string handling
418-
ENABLED_SUPPLIER_APPLICATION_IDS: "XXXXX"
418+
ENABLED_SUPPLIER_APPLICATION_IDS: "30c8d461-e875-4882-85d1-4d5d90f7f17b,f7a08809-09f5-4215-a5c8-e280705aba77,401b11d1-5608-4d6e-8359-9bbed6c90e7e,4b2d703f-d8bb-4c82-8340-b1a97481a46a,9331742d-ccc3-4081-b54b-22e8f946a1ce,ee353200-2b8f-47be-8b70-d0777e80d92f"
419419
NOTIFY_ROUTING_PLAN_ID: "e57fe5cc-0567-4854-abe2-b7dd9014a50c" # INT and PROD share a value
420420
NOTIFY_API_BASE_URL: "https://api.service.nhs.uk"
421421
MTLS_KEY: psu-mtls-1

SAMtemplates/functions/main.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ Resources:
137137
SQS_SALT: !Ref SQSSaltSecret
138138
# Remove this once we've confirmed that product ID based filtering is working as expected and we
139139
# no longer need the ability to switch back to the old filtering method
140-
USE_APP_ID_FOR_NOTIFICATIONS_FILTERING: false
140+
USE_APP_ID_FOR_NOTIFICATIONS_FILTERING: true
141141
ENABLED_SYSTEMS_PARAM: !Ref EnabledSystemsParam
142142
#
143143
ENABLED_APPLICATION_IDS_PARAM: !Ref EnabledSupplierApplicationIDsParam

0 commit comments

Comments
 (0)