pass in the name and fetch the parameter values from ssm in the code

Author: wildjames

.github/workflows/pull_request.yml

@@ -18,7 +18,7 @@ jobs:
 
   get_issue_number:
     runs-on: ubuntu-22.04
-    needs: quality_checks
+    # needs: quality_checks
     outputs:
       issue_number: ${{steps.get_issue_number.outputs.result}}
 

SAMtemplates/functions/main.yaml

@@ -34,13 +34,13 @@ Parameters:
     Default: none
 
   EnabledSiteODSCodesParam:
-    Type: AWS::SSM::Parameter::Value<List<String>>
+    Type: String
 
   EnabledSystemsParam:
-    Type: AWS::SSM::Parameter::Value<List<String>>
+    Type: String
 
   BlockedSiteODSCodesParam:
-    Type: AWS::SSM::Parameter::Value<List<String>>
+    Type: String
 
   LogLevel:
     Type: String
@@ -92,18 +92,9 @@ Resources:
           TABLE_NAME: !Ref PrescriptionStatusUpdatesTableName
           NHS_NOTIFY_PRESCRIPTIONS_SQS_QUEUE_URL: !Ref NHSNotifyPrescriptionsSQSQueueUrl
           SQS_SALT: !Sub "{{resolve:secretsmanager:${SQSSaltSecret}:SecretString:salt}}"
-          ENABLED_SITE_ODS_CODES:
-            Fn::Join:
-              - ","
-              - !Ref EnabledSiteODSCodesParam
-          ENABLED_SYSTEMS:
-            Fn::Join:
-              - ","
-              - !Ref EnabledSystemsParam
-          BLOCKED_SITE_ODS_CODES:
-            Fn::Join:
-              - ","
-              - !Ref BlockedSiteODSCodesParam
+          ENABLED_SITE_ODS_CODES: !Ref EnabledSiteODSCodesParam
+          ENABLED_SYSTEMS: !Ref EnabledSystemsParam
+          BLOCKED_SITE_ODS_CODES: !Ref BlockedSiteODSCodesParam
           LOG_LEVEL: !Ref LogLevel
           ENVIRONMENT: !Ref Environment
           TEST_PRESCRIPTIONS_1: "None"

packages/updatePrescriptionStatus/src/validation/notificationSiteAndSystemFilters.ts

@@ -1,17 +1,42 @@
 import {PSUDataItem} from "@PrescriptionStatusUpdate_common/commonTypes"
+import AWS from "aws-sdk"
 
-function getEnvList(name: string): Set<string> {
-  const raw = process.env[name] ?? ""
-  return new Set(raw
-    .split(",")
-    .map((s) => s.trim().toLowerCase())
-    .filter(Boolean) // Remove empty entries
+const ssm = new AWS.SSM()
+
+/**
+ * Fetches the comma-delimited StringList from SSM, normalizes & returns a Set<string>.
+ */
+async function fetchListFromSSM(paramNameEnvVar: string): Promise<Set<string>> {
+  const paramName = process.env[paramNameEnvVar]
+  if (!paramName) {
+    throw new Error(`Missing required env-var ${paramNameEnvVar}`)
+  }
+  const resp = await ssm
+    .getParameter({Name: paramName, WithDecryption: false})
+    .promise()
+
+  const raw = resp.Parameter?.Value ?? ""
+  return new Set(
+    raw
+      .split(",")
+      .map((s) => s.trim().toLowerCase())
+      .filter(Boolean)
   )
 }
 
-const enabledSiteODSCodes = getEnvList("ENABLED_SITE_ODS_CODES")
-const enabledSystems = getEnvList("ENABLED_SYSTEMS")
-const blockedSiteODSCodes = getEnvList("BLOCKED_SITE_ODS_CODES")
+const listsReady: Promise<{
+  enabledSiteODSCodes: Set<string>;
+  enabledSystems: Set<string>;
+  blockedSiteODSCodes: Set<string>;
+}> = (async () => {
+  const [enabledSiteODSCodes, enabledSystems, blockedSiteODSCodes] =
+    await Promise.all([
+      fetchListFromSSM("ENABLED_SITE_ODS_CODES"),
+      fetchListFromSSM("ENABLED_SYSTEMS"),
+      fetchListFromSSM("BLOCKED_SITE_ODS_CODES")
+    ])
+  return {enabledSiteODSCodes, enabledSystems, blockedSiteODSCodes}
+})()
 
 /**
  * Given an array of PSUDataItem, only returns those which:
@@ -21,9 +46,15 @@ const blockedSiteODSCodes = getEnvList("BLOCKED_SITE_ODS_CODES")
  * @param data - Array of PSUDataItem to be processed
  * @returns - the filtered array
  */
-export function checkSiteOrSystemIsNotifyEnabled(
+export async function checkSiteOrSystemIsNotifyEnabled(
   data: Array<PSUDataItem>
-): Array<PSUDataItem> {
+): Promise<Array<PSUDataItem>> {
+  const {
+    enabledSiteODSCodes,
+    enabledSystems,
+    blockedSiteODSCodes
+  } = await listsReady
+
   return data.filter((item) => {
     const appName = item.ApplicationName.toLowerCase()
     const odsCode = item.PharmacyODSCode.toLowerCase()