When the flag is off, don't require the post dated sqs url. Also, add a comment

Author: wildjames

packages/postDatedLambda/src/databaseClient.ts

@@ -179,6 +179,7 @@ export async function enrichMessagesWithExistingRecords(
   const postDatedItems = messages.map((m) => m.prescriptionData)
 
   const prescriptionsWithRecords = await fetchExistingRecordsForPrescriptions(postDatedItems, logger)
+  // prescription IDs are unique, even across pharmacies. so we can build a map keyed by prescription ID just fine.
   const recordsMap = new Map(prescriptionsWithRecords.map((p) => [p.postDatedData.PrescriptionID, p.existingRecords]))
   const enrichedMessages: Array<PostDatedSQSMessageWithExistingRecords> = messages.map((message) => ({
     ...message,

packages/updatePrescriptionStatus/src/utils/sqsClient.ts

@@ -230,11 +230,6 @@ export async function pushPrescriptionToNotificationSQS(
     throw new Error("Notifications SQS URL not configured")
   }
 
-  if (!postDatedSqsUrl) {
-    logger.warn("Post-dated Notifications SQS URL not found in environment variables")
-    throw new Error("Post-dated Notifications SQS URL not configured")
-  }
-
   // Only allow through sites and systems that are allowedSitesAndSystems
   const allowedSitesAndSystemsData = await checkSiteOrSystemIsNotifyEnabled(data)
 
@@ -261,6 +256,12 @@ export async function pushPrescriptionToNotificationSQS(
   let sqsPromises: Promise<Array<string>>
   if (ENABLE_POST_DATED_NOTIFICATIONS) {
     logger.info("Post-dated notifications are enabled, separating post-dated and non-post-dated items")
+
+    if (!postDatedSqsUrl) {
+      logger.warn("Post-dated Notifications SQS URL not found in environment variables")
+      throw new Error("Post-dated Notifications SQS URL not configured")
+    }
+
     // Build two arrays, one of all post dated, and one of all non-post-dated
     const postDatedItems = changedStatus.filter(item => item.PostDatedLastModifiedSetAt)
     const nonPostDatedItems = changedStatus.filter(item => !item.PostDatedLastModifiedSetAt)