Logging and function name change

Author: wildjames

packages/postDatedLambda/src/businessLogic.ts

@@ -66,7 +66,7 @@ export function processMessage(
   // NOTE: It is technically possible for the array to be empty if no existing records are found
   // This SHOULD never happen in practice, but catch it anyway
   if (message.existingRecords.length === 0) {
-    logger.error("No existing records found for post-dated prescription, cannot process", {
+    logger.error("No existing records found for post-dated prescription, cannot process. Ignoring this message", {
       badMessage: message
     })
 

packages/postDatedLambda/src/databaseClient.ts

@@ -199,12 +199,5 @@ export async function enrichMessagesWithExistingRecords(
     existingRecords: recordsMap.get(message.prescriptionData.PrescriptionID) ?? []
   }))
 
-  for (const msg of enrichedMessages) {
-    logger.info("Prescription and most recent existing record", {
-      prescriptionID: msg.prescriptionData.PrescriptionID,
-      existingRecordCount: msg.existingRecords.length
-    })
-  }
-
   return enrichedMessages
 }

packages/postDatedLambda/src/sqs.ts

@@ -238,7 +238,7 @@ export async function receivePostDatedSQSMessages(logger: Logger): Promise<Array
 /**
  * Forward matured post-dated messages to the Notify queue using the same payload as the update lambda.
  */
-export async function sendSQSMessagesToNotificationQueue(
+export async function forwardSQSMessagesToNotificationQueue(
   logger: Logger,
   messages: Array<PostDatedSQSMessage>
 ): Promise<Array<string>> {
@@ -383,7 +383,7 @@ export async function handleProcessedMessages(
   const {maturedPrescriptionUpdates, immaturePrescriptionUpdates, ignoredPrescriptionUpdates} = result
 
   // Move matured messages to the notification queue and remove them from the post-dated queue
-  await sendSQSMessagesToNotificationQueue(logger, maturedPrescriptionUpdates)
+  await forwardSQSMessagesToNotificationQueue(logger, maturedPrescriptionUpdates)
   await removeSQSMessages(logger, maturedPrescriptionUpdates)
 
   // Return failed messages to the queue