Skip to content

Commit 023366b

Browse files
wildjameswildjames
committed
Rename from product ID to app ID in a few places
1 parent c651d21 commit 023366b

7 files changed

Lines changed: 19 additions & 19 deletions

File tree

‎.github/scripts/release_code.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ sam deploy \
6969
EnabledSiteODSCodesValue="${ENABLED_SITE_ODS_CODES:-' '}" \
7070
EnablePostDatedNotifications="$ENABLE_POST_DATED_NOTIFICATIONS" \
7171
EnabledSystemsValue="${ENABLED_SYSTEMS:-' '}" \
72-
EnabledSupplierApplicationIDsValue="${ENABLED_SUPPLIER_PRODUCT_IDS:-' '}" \
72+
EnabledSupplierApplicationIDsValue="${ENABLED_SUPPLIER_APPLICATION_IDS:-' '}" \
7373
BlockedSiteODSCodesValue="${BLOCKED_SITE_ODS_CODES:-' '}" \
7474
NotifyRoutingPlanIDValue="$NOTIFY_ROUTING_PLAN_ID" \
7575
NotifyAPIBaseURLValue="$NOTIFY_API_BASE_URL" \

‎.github/workflows/ci.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ jobs:
8181
ENABLE_POST_DATED_NOTIFICATIONS: true
8282
ENABLED_SYSTEMS: "Internal Test System"
8383
BLOCKED_SITE_ODS_CODES: "B3J1Z"
84-
ENABLED_SUPPLIER_PRODUCT_IDS: "XXXXX"
84+
ENABLED_SUPPLIER_APPLICATION_IDS: "XXXXX"
8585
NOTIFY_ROUTING_PLAN_ID: "e57fe5cc-0567-4854-abe2-b7dd9014a50c"
8686
NOTIFY_API_BASE_URL: "https://int.api.service.nhs.uk"
8787
MTLS_KEY: psu-mtls-1
@@ -125,7 +125,7 @@ jobs:
125125
ENABLE_POST_DATED_NOTIFICATIONS: true
126126
ENABLED_SYSTEMS: "Internal Test System"
127127
BLOCKED_SITE_ODS_CODES: "B3J1Z"
128-
ENABLED_SUPPLIER_PRODUCT_IDS: "XXXXX" # Workaround empty string handling
128+
ENABLED_SUPPLIER_APPLICATION_IDS: "XXXXX" # Workaround empty string handling
129129
NOTIFY_ROUTING_PLAN_ID: "e57fe5cc-0567-4854-abe2-b7dd9014a50c"
130130
NOTIFY_API_BASE_URL: "https://int.api.service.nhs.uk"
131131
MTLS_KEY: psu-mtls-1
@@ -167,7 +167,7 @@ jobs:
167167
ENABLE_POST_DATED_NOTIFICATIONS: true
168168
ENABLED_SYSTEMS: "Internal Test System"
169169
BLOCKED_SITE_ODS_CODES: "B3J1Z"
170-
ENABLED_SUPPLIER_PRODUCT_IDS: "XXXXX" # Workaround empty string handling
170+
ENABLED_SUPPLIER_APPLICATION_IDS: "XXXXX" # Workaround empty string handling
171171
NOTIFY_ROUTING_PLAN_ID: "e57fe5cc-0567-4854-abe2-b7dd9014a50c"
172172
NOTIFY_API_BASE_URL: "https://int.api.service.nhs.uk"
173173
MTLS_KEY: psu-mtls-1

‎.github/workflows/pull_request.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ jobs:
118118
ENABLE_POST_DATED_NOTIFICATIONS: true
119119
ENABLED_SYSTEMS: "Internal Test System"
120120
BLOCKED_SITE_ODS_CODES: "XXXXX" # Workaround empty string handling
121-
ENABLED_SUPPLIER_PRODUCT_IDS: "XXXXX"
121+
ENABLED_SUPPLIER_APPLICATION_IDS: "XXXXX"
122122
NOTIFY_ROUTING_PLAN_ID: "e57fe5cc-0567-4854-abe2-b7dd9014a50c"
123123
NOTIFY_API_BASE_URL: "https://int.api.service.nhs.uk"
124124
MTLS_KEY: psu-mtls-1
@@ -160,7 +160,7 @@ jobs:
160160
ENABLE_NOTIFICATIONS_EXTERNAL: false
161161
ENABLED_SYSTEMS: "Internal Test System"
162162
BLOCKED_SITE_ODS_CODES: "B3J1Z"
163-
ENABLED_SUPPLIER_PRODUCT_IDS: "XXXXX" # Workaround empty string handling
163+
ENABLED_SUPPLIER_APPLICATION_IDS: "XXXXX" # Workaround empty string handling
164164
NOTIFY_ROUTING_PLAN_ID: "e57fe5cc-0567-4854-abe2-b7dd9014a50c"
165165
NOTIFY_API_BASE_URL: "https://int.api.service.nhs.uk"
166166
MTLS_KEY: psu-mtls-1

‎.github/workflows/release.yml‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ jobs:
8282
ENABLE_POST_DATED_NOTIFICATIONS: true
8383
ENABLED_SYSTEMS: "Internal Test System"
8484
BLOCKED_SITE_ODS_CODES: "XXXXX" # Workaround empty string handling
85-
ENABLED_SUPPLIER_PRODUCT_IDS: "XXXXX"
85+
ENABLED_SUPPLIER_APPLICATION_IDS: "XXXXX"
8686
NOTIFY_ROUTING_PLAN_ID: "e57fe5cc-0567-4854-abe2-b7dd9014a50c"
8787
NOTIFY_API_BASE_URL: "https://int.api.service.nhs.uk"
8888
MTLS_KEY: psu-mtls-1
@@ -129,7 +129,7 @@ jobs:
129129
ENABLE_POST_DATED_NOTIFICATIONS: false
130130
ENABLED_SYSTEMS: "Internal Test System"
131131
BLOCKED_SITE_ODS_CODES: "B3J1Z"
132-
ENABLED_SUPPLIER_PRODUCT_IDS: "XXXXX"
132+
ENABLED_SUPPLIER_APPLICATION_IDS: "XXXXX"
133133
NOTIFY_ROUTING_PLAN_ID: "e57fe5cc-0567-4854-abe2-b7dd9014a50c"
134134
NOTIFY_API_BASE_URL: "https://int.api.service.nhs.uk"
135135
MTLS_KEY: psu-mtls-1
@@ -182,7 +182,7 @@ jobs:
182182
ENABLE_POST_DATED_NOTIFICATIONS: false
183183
ENABLED_SYSTEMS: "Internal Test System, Apotec Ltd - Apotec CRM - Production, CrxPatientApp, nhsPrescriptionApp, Titan PSU Prod"
184184
BLOCKED_SITE_ODS_CODES: "B3J1Z"
185-
ENABLED_SUPPLIER_PRODUCT_IDS: "XXXXX"
185+
ENABLED_SUPPLIER_APPLICATION_IDS: "XXXXX"
186186
NOTIFY_ROUTING_PLAN_ID: "e57fe5cc-0567-4854-abe2-b7dd9014a50c"
187187
NOTIFY_API_BASE_URL: "https://int.api.service.nhs.uk"
188188
MTLS_KEY: psu-mtls-1
@@ -235,7 +235,7 @@ jobs:
235235
ENABLE_POST_DATED_NOTIFICATIONS: true
236236
ENABLED_SYSTEMS: "Internal Test System, Apotec Ltd - Apotec CRM - Production, CrxPatientApp, nhsPrescriptionApp, Titan PSU Prod"
237237
BLOCKED_SITE_ODS_CODES: "B3J1Z"
238-
ENABLED_SUPPLIER_PRODUCT_IDS: "XXXXX"
238+
ENABLED_SUPPLIER_APPLICATION_IDS: "XXXXX"
239239
NOTIFY_ROUTING_PLAN_ID: "e57fe5cc-0567-4854-abe2-b7dd9014a50c"
240240
NOTIFY_API_BASE_URL: "https://int.api.service.nhs.uk"
241241
MTLS_KEY: psu-mtls-1
@@ -281,7 +281,7 @@ jobs:
281281
ENABLE_POST_DATED_NOTIFICATIONS: true
282282
ENABLED_SYSTEMS: "CrxPatientApp"
283283
BLOCKED_SITE_ODS_CODES: "XXXXX" # Workaround empty string handling
284-
ENABLED_SUPPLIER_PRODUCT_IDS: "XXXXX"
284+
ENABLED_SUPPLIER_APPLICATION_IDS: "XXXXX"
285285
NOTIFY_ROUTING_PLAN_ID: "e57fe5cc-0567-4854-abe2-b7dd9014a50c"
286286
NOTIFY_API_BASE_URL: "https://int.api.service.nhs.uk"
287287
MTLS_KEY: psu-mtls-1
@@ -329,7 +329,7 @@ jobs:
329329
ENABLE_POST_DATED_NOTIFICATIONS: false
330330
ENABLED_SYSTEMS: "Internal Test System, Apotec Ltd - Apotec CRM - Production, CrxPatientApp, nhsPrescriptionApp, Titan PSU Prod"
331331
BLOCKED_SITE_ODS_CODES: "B3J1Z"
332-
ENABLED_SUPPLIER_PRODUCT_IDS: "XXXXX"
332+
ENABLED_SUPPLIER_APPLICATION_IDS: "XXXXX"
333333
NOTIFY_ROUTING_PLAN_ID: "e57fe5cc-0567-4854-abe2-b7dd9014a50c"
334334
NOTIFY_API_BASE_URL: "https://int.api.service.nhs.uk"
335335
MTLS_KEY: psu-mtls-1
@@ -382,7 +382,7 @@ jobs:
382382
ENABLE_POST_DATED_NOTIFICATIONS: false
383383
ENABLED_SYSTEMS: "CrxPatientApp"
384384
BLOCKED_SITE_ODS_CODES: "XXXXX" # Workaround empty string handling
385-
ENABLED_SUPPLIER_PRODUCT_IDS: "XXXXX"
385+
ENABLED_SUPPLIER_APPLICATION_IDS: "XXXXX"
386386
NOTIFY_ROUTING_PLAN_ID: "e57fe5cc-0567-4854-abe2-b7dd9014a50c" # INT and PROD share a value
387387
NOTIFY_API_BASE_URL: "https://api.service.nhs.uk"
388388
MTLS_KEY: psu-mtls-1

‎.github/workflows/run_release_code_and_api.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ on:
8585
BLOCKED_SITE_ODS_CODES:
8686
required: true
8787
type: string
88-
ENABLED_SUPPLIER_PRODUCT_IDS:
88+
ENABLED_SUPPLIER_APPLICATION_IDS:
8989
required: true
9090
type: string
9191
NOTIFY_ROUTING_PLAN_ID:
@@ -219,7 +219,7 @@ jobs:
219219
ENABLED_SITE_ODS_CODES: ${{ steps.read.outputs.ods_csv }}
220220
ENABLED_SYSTEMS: ${{ inputs.ENABLED_SYSTEMS }}
221221
BLOCKED_SITE_ODS_CODES: ${{ inputs.BLOCKED_SITE_ODS_CODES }}
222-
ENABLED_SUPPLIER_PRODUCT_IDS: ${{ inputs.ENABLED_SUPPLIER_PRODUCT_IDS }}
222+
ENABLED_SUPPLIER_APPLICATION_IDS: ${{ inputs.ENABLED_SUPPLIER_APPLICATION_IDS }}
223223
NOTIFY_ROUTING_PLAN_ID: ${{ inputs.NOTIFY_ROUTING_PLAN_ID }}
224224
NOTIFY_API_BASE_URL: ${{ inputs.NOTIFY_API_BASE_URL }}
225225
TEST_PRESCRIPTIONS_1: ${{ inputs.TEST_PRESCRIPTIONS_1 || 'noval' }}

‎Makefile‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ sam-sync: guard-AWS_DEFAULT_PROFILE guard-stack_name compile
4848
"EnabledSystemsValue=$${ENABLED_SYSTEMS:-Internal Test System}" \
4949
"EnabledSiteODSCodesValue=$${ENABLED_SITE_ODS_CODES:-A83008,FA565}" \
5050
BlockedSiteODSCodesValue=$${BLOCKED_SITE_ODS_CODES:-XXXXX} \
51-
EnabledSupplierApplicationIDsValue=$${ENABLED_SUPPLIER_PRODUCT_IDS:-XXXXX} \
51+
EnabledSupplierApplicationIDsValue=$${ENABLED_SUPPLIER_APPLICATION_IDS:-XXXXX} \
5252
NotifyRoutingPlanIDValue=$${NOTIFY_ROUTING_PLAN_ID:-e57fe5cc-0567-4854-abe2-b7dd9014a50c} \
5353
NotifyAPIBaseURLValue=$${NOTIFY_API_BASE_URL:-https://int.api.service.nhs.uk} \
5454
EnableNotificationsInternal=$${ENABLE_NOTIFICATIONS_INTERNAL:-true} \
@@ -81,7 +81,7 @@ sam-deploy: guard-AWS_DEFAULT_PROFILE guard-stack_name
8181
"EnabledSystemsValue=$${ENABLED_SYSTEMS:-Internal Test System}" \
8282
"EnabledSiteODSCodesValue=$${ENABLED_SITE_ODS_CODES:-A83008,FA565}" \
8383
BlockedSiteODSCodesValue=$${BLOCKED_SITE_ODS_CODES:-XXXXX} \
84-
EnabledSupplierApplicationIDsValue=$${ENABLED_SUPPLIER_PRODUCT_IDS:-XXXXX} \
84+
EnabledSupplierApplicationIDsValue=$${ENABLED_SUPPLIER_APPLICATION_IDS:-XXXXX} \
8585
NotifyRoutingPlanIDValue=$${NOTIFY_ROUTING_PLAN_ID:-e57fe5cc-0567-4854-abe2-b7dd9014a50c} \
8686
NotifyAPIBaseURLValue=$${NOTIFY_API_BASE_URL:-https://int.api.service.nhs.uk} \
8787
EnableNotificationsInternal=$${ENABLE_NOTIFICATIONS_INTERNAL:-true} \

‎SAMtemplates/parameters/main.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ Resources:
7777
Type: AWS::SSM::Parameter
7878
Properties:
7979
Name: !Sub ${StackName}-PSUNotifyEnabledSupplierApplicationIDs
80-
Description: "List of supplier product IDs for which notifications are enabled"
80+
Description: "List of supplier application IDs for which notifications are enabled"
8181
Type: String
8282
Value: !Ref EnabledSupplierApplicationIDsValue
8383

@@ -193,7 +193,7 @@ Outputs:
193193
Name: !Sub ${StackName}-PSUNotifyEnabledSystemsParam
194194

195195
EnabledSupplierApplicationIDsParameterName:
196-
Description: "Name of the SSM parameter holding enabled supplier product IDs"
196+
Description: "Name of the SSM parameter holding enabled supplier apigee application IDs"
197197
Value: !Ref EnabledSupplierApplicationIDsParameter
198198
Export:
199199
Name: !Sub ${StackName}-PSUNotifyEnabledSupplierApplicationIDsParam

0 commit comments

Comments
 (0)