From cba6397966a0fd5a9fa71f6ea6b3e88fde19aebf Mon Sep 17 00:00:00 2001
From: Florian Gail <gail@zeiler-technik.de>
Date: Sun, 12 Jul 2026 11:26:58 +0200
Subject: [PATCH] Colocate node icons per node and copy them during build

Align build.js with the node-red-example template: add copyIcons() to
transfer each node's src/nodes/<node>/icons into dist/nodes/<node>/icons,
drop the unused plugin/theme stubs. Move the icons out of the central
icons/ directory into their nodes, ship src/resources instead.
---
 build.js                                      | 185 ++++++++++--------
 .../nodes/sacn-in/icons}/sacn-in.svg          |   0
 .../nodes/sacn-out/icons}/sacn-out.svg        |   0
 .../icons}/scene-controller.svg               |   0
 package.json                                  |   3 +-
 resources/.gitkeep                            |   0
 src/nodes/sacn-in/icons/sacn-in.svg           |   7 +
 src/nodes/sacn-out/icons/sacn-out.svg         |   7 +
 .../icons/scene-controller.svg                |  10 +
 9 files changed, 129 insertions(+), 83 deletions(-)
 rename {icons => dist/nodes/sacn-in/icons}/sacn-in.svg (100%)
 rename {icons => dist/nodes/sacn-out/icons}/sacn-out.svg (100%)
 rename {icons => dist/nodes/scene-controller/icons}/scene-controller.svg (100%)
 create mode 100644 resources/.gitkeep
 create mode 100644 src/nodes/sacn-in/icons/sacn-in.svg
 create mode 100644 src/nodes/sacn-out/icons/sacn-out.svg
 create mode 100644 src/nodes/scene-controller/icons/scene-controller.svg

diff --git a/build.js b/build.js
index b11e3fc..8d5a854 100644
--- a/build.js
+++ b/build.js
@@ -1,33 +1,57 @@
-const { cwd } = require("process");
+const { cwd } = require("node:process");
 const ts = require("typescript");
 const {
-  cp,
   readdirSync,
-  exists,
   existsSync,
   readFileSync,
-  writeFile,
   writeFileSync,
   mkdirSync,
   realpathSync,
+  copyFileSync,
 } = require("node:fs");
-const sourcePath = cwd() + "/src";
-const targetPath = cwd() + "/dist";
+
+// directory containing the sources for nodes; defaults to `src/nodes` within the current working directory
+const nodesSourceDir = cwd() + "/src/nodes";
+// directory the generated files should be saved to; defaults to `dist/nodes` within the current working directory
+const nodesTargetDir = cwd() + "/dist/nodes";
+// path to the typescript project configuration for building the nodes
 const buildTsConfig = JSON.parse(readFileSync("build.tsconfig.json").toString());
 
 /**
- * @param node String
- * @param source String
- * @param target String
+ * Creates a directory if it does not exist
+ * @param {string} dir directory path to create
+ */
+function makeDir(dir) {
+  // bypass everything in case the directory already exists
+  if (!existsSync(dir)) {
+    const parentDir = realpathSync(`${dir}../`);
+
+    // check whether parent directory exists and create it recursively if not
+    if (!existsSync(parentDir)) {
+      makeDir(parentDir);
+    }
+
+    // finally create the directory
+    mkdirSync(dir);
+  }
+}
+
+/**
+ * Builds the form for editing a node using the Node-RED Editor.
+ *
+ * @param {string} node name of the node the form belongs to
+ * @param {string} sourcePath path of the directory containing the node's source files
+ * @param {string} targetPath path of the directory the node's generated files should be saved to
  */
-function buildNodeForm(node, source, target) {
+function buildForm(node, sourcePath, targetPath) {
   /**
    * @type {string[]}
    */
   const html = [];
-  const form = readFileSync(`${source}/form.html`).toString();
-  const docs = existsSync(`${source}/docs.html`) ? readFileSync(`${source}/docs.html`).toString() : undefined;
+  const form = readFileSync(`${sourcePath}/form.html`).toString();
+  const docs = existsSync(`${sourcePath}/docs.html`) ? readFileSync(`${sourcePath}/docs.html`).toString() : undefined;
 
+  // parse `form.html` and wrap it to the corresponding script-tag
   const formLines = form.split("\n");
   html.push(`<script type="text/html" data-template-name="${node}">`);
   formLines.forEach((line) => {
@@ -37,6 +61,7 @@ function buildNodeForm(node, source, target) {
   });
   html.push("</script>");
 
+  // parse `docs.html` and wrap it to the corresponding script-tag
   if (docs) {
     const docsLines = docs.split("\n");
     html.push(`<script type="text/html" data-help-name="${node}">`);
@@ -48,12 +73,14 @@ function buildNodeForm(node, source, target) {
     html.push("</script>");
   }
 
-  const initTS = readFileSync(`${source}/init.ts`).toString();
+  // read and transpile the node's TypeScript
+  const initTS = readFileSync(`${sourcePath}/init.ts`).toString();
   let initJS = ts
     .transpileModule(initTS, buildTsConfig)
     .outputText.replace(/export \{(?:[^\}]+)?\};/gim, "")
     .replace(/RED\.nodes\.registerType\("([^\"]+)"/i, `RED.nodes.registerType("${node}"`);
 
+  // inject the node's init logic into the node's HTML
   const initJSLines = initJS.split("\n");
   html.push('<script type="text/javascript">');
   initJSLines.forEach((line) => {
@@ -65,40 +92,47 @@ function buildNodeForm(node, source, target) {
 
   html.push("");
 
-  mkdirSync(`${target}/`, {
+  // create node's target directory
+  mkdirSync(`${targetPath}/`, {
     recursive: true,
   });
 
-  writeFileSync(`${target}/${node}.html`, html.join("\n"));
+  // save the node's editor formular
+  writeFileSync(`${targetPath}/${node}.html`, html.join("\n"));
 }
 
 /**
- * @param node String
- * @param source String
- * @param target String
+ * Copys the locale files of a node.
+ *
+ * @param {string} node name of the node the form belongs to
+ * @param {string} sourcePath path of the directory containing the node's source files
+ * @param {string} targetPath path of the directory the node's generated files should be saved to
  */
-function copyNodeLocales(node, source, target) {
-  if (!existsSync(`${source}/locales`)) {
+function copyLocales(node, sourcePath, targetPath) {
+  // skip in case directory `locales` does not exist within the nodes directory
+  if (!existsSync(`${sourcePath}/locales`)) {
     return;
   }
 
-  readdirSync(`${source}/locales`, {
+  readdirSync(`${sourcePath}/locales`, {
     recursive: false,
   })
     .filter((language) => {
+      // filter for files named as valid language codes
       return language.match(/^[a-z]{2,2}(?:-[A-Z]{2,2})?\.json$/);
     })
     .forEach((language) => {
+      // read the language code and the JSON
       const languageCode = language.match(/^([a-z]{2,2}(?:-[A-Z]{2,2})?)\.json$/i)[1];
-      const content = readFileSync(`${source}/locales/${language}`).toString();
+      const content = readFileSync(`${sourcePath}/locales/${language}`).toString();
 
       /**
        * @type {string[]}
        */
-      const json = [];
+      const json = ["{"];
 
+      // wrap locales content within a tag names like the node
       const contentLines = content.split("\n");
-      const lastElement = json.push("{");
       json.push(`  "${node}": ${contentLines[0]}`);
       contentLines.splice(1).forEach((line) => {
         if (line.length > 0) {
@@ -107,75 +141,62 @@ function copyNodeLocales(node, source, target) {
       });
       json.push("}");
 
-      mkdirSync(`${target}/locales/${languageCode}`, {
+      // create node locales target directory
+      mkdirSync(`${targetPath}/locales/${languageCode}`, {
         recursive: true,
       });
 
-      writeFileSync(`${target}/locales/${languageCode}/${node}.json`, json.join("\n"));
+      // save the node's locales
+      writeFileSync(`${targetPath}/locales/${languageCode}/${node}.json`, json.join("\n"));
     });
 }
 
-function buildNodes() {
-  readdirSync(`${sourcePath}/nodes`, {
-    recursive: false,
-  })
-    .filter((node) => {
-      const path = `${sourcePath}/nodes/${node}`;
-
-      return existsSync(`${path}/form.html`) && existsSync(`${path}/${node}.ts`);
-    })
-    .forEach((node) => {
-      console.info(`Building node ${node}`);
-
-      const source = `${sourcePath}/nodes/${node}`;
-      const target = `${targetPath}/nodes/${node}`;
-
-      buildNodeForm(node, source, target);
+/**
+ * Copy icons of a node.
+ *
+ @param {string} node name of the node the form belongs to
+ @param {string} sourcePath path of the directory containing the node's source files
+ @param {string} targetPath path of the directory the node's generated files should be saved to
+ */
+function copyIcons(node, sourcePath, targetPath) {
+  // skip in case directory `icons` does not exist within the nodes directory
+  if (!existsSync(`${sourcePath}/icons`)) {
+    return;
+  }
 
-      copyNodeLocales(node, source, target);
-    });
-}
+  // create node icons target directory
+  mkdirSync(`${targetPath}/icons`, {
+    recursive: true,
+  });
 
-function buildPlugins() {
-  readdirSync(`${sourcePath}/plugins`, {
+  // copy the node's icons
+  readdirSync(`${sourcePath}/icons`, {
     recursive: false,
-  })
-    .filter((plugin) => {
-      const path = `${sourcePath}/plugins/${plugin}`;
-
-      return existsSync(`${path}/${plugin}.ts`);
-    })
-    .forEach((plugin) => {
-      console.info(`Building plugin ${plugin}`);
-
-      // does nothing yet
-    });
+  }).forEach((icon) => {
+    copyFileSync(`${sourcePath}/icons/${icon}`, `${targetPath}/icons/${icon}`);
+  });
 }
 
-function buildThemes() {
-  readdirSync(`${sourcePath}/themes`, {
-    recursive: false,
+/*
+ * Iterate over every directory
+ */
+readdirSync(nodesSourceDir, {
+  recursive: false,
+})
+  .filter((node) => {
+    const path = `${nodesSourceDir}/${node}`;
+
+    // filter for directories containing at least a `form.html` and the nodes logic script `node.ts`
+    return existsSync(`${path}/form.html`) && existsSync(`${path}/${node}.ts`);
   })
-    .filter((theme) => {
-      const path = `${sourcePath}/themes/${theme}`;
+  .forEach((node) => {
+    const sourcePath = `${nodesSourceDir}/${node}`;
+    const targetPath = `${nodesTargetDir}/${node}`;
 
-      return existsSync(`${path}/${theme}.ts`);
-    })
-    .forEach((theme) => {
-      console.info(`Building theme ${theme}`);
-
-      // does nothing yet
-    });
-}
-
-if (existsSync(`${sourcePath}/plugins`)) {
-  buildPlugins();
-}
-
-if (existsSync(`${sourcePath}/nodes`)) {
-  buildNodes();
-}
+    // build the nodes' form for Node-RED Editor
+    buildForm(node, sourcePath, targetPath);
 
-if (existsSync(`${sourcePath}/themes`)) {
-  buildThemes();
-}
+    // copy/transfer optional assets
+    copyLocales(node, sourcePath, targetPath);
+    copyIcons(node, sourcePath, targetPath);
+  });
diff --git a/icons/sacn-in.svg b/dist/nodes/sacn-in/icons/sacn-in.svg
similarity index 100%
rename from icons/sacn-in.svg
rename to dist/nodes/sacn-in/icons/sacn-in.svg
diff --git a/icons/sacn-out.svg b/dist/nodes/sacn-out/icons/sacn-out.svg
similarity index 100%
rename from icons/sacn-out.svg
rename to dist/nodes/sacn-out/icons/sacn-out.svg
diff --git a/icons/scene-controller.svg b/dist/nodes/scene-controller/icons/scene-controller.svg
similarity index 100%
rename from icons/scene-controller.svg
rename to dist/nodes/scene-controller/icons/scene-controller.svg
diff --git a/package.json b/package.json
index ac37aab..da8c812 100644
--- a/package.json
+++ b/package.json
@@ -53,9 +53,10 @@
   },
   "main": "dist",
   "files": [
+    "src",
     "dist",
     "examples",
-    "icons",
+    "resources",
     "LICENSE",
     "README.md"
   ]
diff --git a/resources/.gitkeep b/resources/.gitkeep
new file mode 100644
index 0000000..e69de29
diff --git a/src/nodes/sacn-in/icons/sacn-in.svg b/src/nodes/sacn-in/icons/sacn-in.svg
new file mode 100644
index 0000000..829e4fe
--- /dev/null
+++ b/src/nodes/sacn-in/icons/sacn-in.svg
@@ -0,0 +1,7 @@
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24">
+  <g fill="#222222">
+    <rect x="15" y="4" width="3" height="16" rx="1"/>
+    <rect x="20" y="4" width="3" height="16" rx="1"/>
+    <path d="M2 10.5h6V7l5 5-5 5v-3.5H2z"/>
+  </g>
+</svg>
diff --git a/src/nodes/sacn-out/icons/sacn-out.svg b/src/nodes/sacn-out/icons/sacn-out.svg
new file mode 100644
index 0000000..7b5367c
--- /dev/null
+++ b/src/nodes/sacn-out/icons/sacn-out.svg
@@ -0,0 +1,7 @@
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24">
+  <g fill="#222222">
+    <rect x="1" y="4" width="3" height="16" rx="1"/>
+    <rect x="6" y="4" width="3" height="16" rx="1"/>
+    <path d="M11 10.5h6V7l5 5-5 5v-3.5h-6z"/>
+  </g>
+</svg>
diff --git a/src/nodes/scene-controller/icons/scene-controller.svg b/src/nodes/scene-controller/icons/scene-controller.svg
new file mode 100644
index 0000000..3ea7e92
--- /dev/null
+++ b/src/nodes/scene-controller/icons/scene-controller.svg
@@ -0,0 +1,10 @@
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24">
+  <g fill="#222222">
+    <rect x="4" y="3" width="2" height="18" rx="1"/>
+    <rect x="11" y="3" width="2" height="18" rx="1"/>
+    <rect x="18" y="3" width="2" height="18" rx="1"/>
+    <rect x="2" y="6" width="6" height="3" rx="1.5"/>
+    <rect x="9" y="14" width="6" height="3" rx="1.5"/>
+    <rect x="16" y="9" width="6" height="3" rx="1.5"/>
+  </g>
+</svg>