Skip to content

Commit 8b481e5

Browse files
committed
Fix path to the signtool for Windows application signing.
1 parent 588e1b2 commit 8b481e5

1 file changed

Lines changed: 3 additions & 9 deletions

File tree

.github/workflows/on-demand-deployment.yaml

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -144,15 +144,9 @@ jobs:
144144
if: runner.os == 'Windows'
145145
shell: cmd
146146
run: |
147+
rem Leaving this here for finding signtool.exe when the runner upgrades.
147148
echo "Finding signtool"
148-
149-
echo "Directory contents I:"
150-
dir /s /b "C:\Program Files (x86)\Windows Kits\10\bin\"
151-
echo "Directory contents II:"
152149
dir /s /b "C:\Program Files (x86)\Windows Kits\10\bin\signtool.exe"
153-
echo "Directory contents III:"
154-
dir /s /b "C:\Program Files (x86)\Windows Kits\10\bin\x64\signtool.exe"
155-
where signtool.exe
156150
- name: Set up Python
157151
uses: actions/setup-python@v5
158152
with:
@@ -254,7 +248,7 @@ jobs:
254248
dir C:/a/mapclient/mapclient/mapclient/res/pyinstaller/dist/MAP-Client-mapping-tools/
255249
echo "Directory contents 2:"
256250
dir C:\a\mapclient\mapclient\mapclient\res\pyinstaller\dist\MAP-Client-mapping-tools\
257-
"C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x86\signtool" sign /d "MAP Client - mapping tools" /tr http://rfc3161timestamp.globalsign.com/advanced /fd SHA256 /td SHA256 /f ev_certificate.pfx ${{ steps.create-application.outputs.file }}
251+
"C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x86\signtool" sign /d "MAP Client - mapping tools" /tr http://rfc3161timestamp.globalsign.com/advanced /fd SHA256 /td SHA256 /f ev_certificate.pfx ${{ steps.create-application.outputs.file }}
258252
259253
- name: Codesign application (macOS)
260254
if: runner.os == 'macOS'
@@ -295,7 +289,7 @@ jobs:
295289
if: runner.os == 'Windows'
296290
shell: cmd
297291
run: |
298-
"C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x86\signtool" sign /d "MAP Client - mapping tools" /tr http://rfc3161timestamp.globalsign.com/advanced /fd SHA256 /td SHA256 /f ev_certificate.pfx ${{ steps.create-installer.outputs.file }}
292+
"C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x86\signtool" sign /d "MAP Client - mapping tools" /tr http://rfc3161timestamp.globalsign.com/advanced /fd SHA256 /td SHA256 /f ev_certificate.pfx ${{ steps.create-installer.outputs.file }}
299293
rem AzureSignTool sign -kvu "${{ secrets.AZURE_KEY_VAULT_URI }}" -kvi "${{ secrets.AZURE_CLIENT_ID }}" -kvt "${{ secrets.AZURE_TENANT_ID }}" -kvs "${{ secrets.AZURE_CLIENT_SECRET }}" -kvc ${{ secrets.AZURE_CERT_NAME }} -tr http://timestamp.acs.microsoft.com -v ${{ steps.create-installer.outputs.file }}
300294
301295
- name: Notarize and Staple installer (macOS)

0 commit comments

Comments
 (0)