Skip to content

Commit 53364cf

Browse files
committed
Windows Server runner needs NSIS to be installed.
1 parent a28cd66 commit 53364cf

1 file changed

Lines changed: 14 additions & 15 deletions

File tree

.github/workflows/on-demand-deployment.yaml

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,20 @@ jobs:
151151
uses: actions/setup-python@v5
152152
with:
153153
python-version: ${{ matrix.python-version }}
154+
- name: Download NSIS Installer
155+
if: runner.os == 'Windows'
156+
run: |
157+
Invoke-WebRequest -Uri "https://sourceforge.net/projects/nsis/files/NSIS%203/3.11/nsis-3.11-setup.exe/download" -OutFile "nsis-setup.exe"
158+
dir
159+
- name: Install NSIS
160+
if: runner.os == 'Windows'
161+
run: |
162+
dir
163+
Start-Process -FilePath ".\\nsis-setup.exe" -ArgumentList "/S" -Wait
164+
- name: Verify NSIS Installation
165+
if: runner.os == 'Windows'
166+
run: |
167+
& "C:\\Program Files (x86)\\NSIS\\makensis.exe" -VERSION
154168
- name: Checkout codebase
155169
uses: actions/checkout@v4
156170
with:
@@ -241,21 +255,6 @@ jobs:
241255
rem AzureSignTool sign -kvu "${{ secrets.AZURE_KEY_VAULT_URI }}" -kvi "${{ secrets.AZURE_CLIENT_ID }}" -kvt "${{ secrets.AZURE_TENANT_ID }}" -kvs "${{ secrets.AZURE_CLIENT_SECRET }}" -kvc ${{ secrets.AZURE_CERT_NAME }} -tr http://timestamp.acs.microsoft.com -v ${{ steps.create-application.outputs.file }}
242256
"C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x86\signtool" sign /d "MAP Client - mapping tools" /tr http://rfc3161timestamp.globalsign.com/advanced /fd SHA256 /td SHA256 /f ev_certificate.pfx ${{ steps.create-application.outputs.file }}
243257
244-
- name: Download NSIS Installer
245-
if: runner.os == 'Windows'
246-
run: |
247-
Invoke-WebRequest -Uri "https://sourceforge.net/projects/nsis/files/NSIS%203/3.11/nsis-3.11-setup.exe/download" -OutFile "nsis-setup.exe"
248-
249-
- name: Install NSIS
250-
if: runner.os == 'Windows'
251-
run: |
252-
Start-Process -FilePath ".\\nsis-setup.exe" -ArgumentList "/S" -Wait
253-
254-
- name: Verify NSIS Installation
255-
if: runner.os == 'Windows'
256-
run: |
257-
& "C:\\Program Files (x86)\\NSIS\\makensis.exe" -VERSION
258-
259258
- name: Codesign application (macOS)
260259
if: runner.os == 'macOS'
261260
run: |

0 commit comments

Comments
 (0)