Skip to content

Commit 160c7be

Browse files
committed
Made shaper colorspace names more consistent with other colorspace names.
1 parent 00b5038 commit 160c7be

3 files changed

Lines changed: 17 additions & 18 deletions

File tree

aces_1.0.0/README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,12 +125,11 @@ For ease of use across a broader number of applications, the family name of each
125125
- Description: A collection of colorspaces that are used to facilitate the creation of LUTs and other basic functionality.
126126

127127
- Technical information:
128-
- The Log2 shaper, Output shaper and 'Dolby PQ Scaled' spaces cover the linear range going from 6 stops below 18% grey (0.0028125) to 6.5 stops above 18% grey (16.291740)
128+
- The 'Log2 xx nits Shaper' and 'Dolby PQ xx nits Shaper' spaces cover the linear range going centered around 18% grey. The 48 nits spaces cover -6.5 stops (0.0028125) to +6.5 stops(16.291740). The 1000 nits spaces cover -12 stops to +10 stops. The 2000 nits spaces cover -12 stops to +11 stops. The 4000 nits spaces cover -12 stops to +12 stops.
129129
- The LMT shaper spaces cover the linear range going from 10 stops below 18% grey (0.00017578125) to 6.5 stops above 18% grey (16.291740)
130130
- The colorspaces that start with "Linear - " will convert to or from a specific gamut but not apply a transfer function.
131131
- The colorspaces that start with "Curve - " will apply a transfer function but not convert between gamuts.
132132

133-
134133
### Roles
135134

136135
- Description: The role colorspaces are aliases to the colorspaces used for the OCIO 'roles' functionality.

aces_1.0.0/python/aces_ocio/colorspaces/aces.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1177,7 +1177,7 @@ def create_shapers(aces_ctl_directory,
11771177
lut_directory,
11781178
lut_resolution_1d,
11791179
cleanup,
1180-
'Log2 48nits Shaper',
1180+
'Log2 48 nits Shaper',
11811181
0.18,
11821182
-6.5,
11831183
6.5)
@@ -1191,7 +1191,7 @@ def create_shapers(aces_ctl_directory,
11911191
lut_directory,
11921192
lut_resolution_1d,
11931193
cleanup,
1194-
'Log2 1000nits Shaper',
1194+
'Log2 1000 nits Shaper',
11951195
0.18,
11961196
-12.0,
11971197
10.0)
@@ -1205,7 +1205,7 @@ def create_shapers(aces_ctl_directory,
12051205
lut_directory,
12061206
lut_resolution_1d,
12071207
cleanup,
1208-
'Log2 2000nits Shaper',
1208+
'Log2 2000 nits Shaper',
12091209
0.18,
12101210
-12.0,
12111211
11.0)
@@ -1219,7 +1219,7 @@ def create_shapers(aces_ctl_directory,
12191219
lut_directory,
12201220
lut_resolution_1d,
12211221
cleanup,
1222-
'Log2 4000nits Shaper',
1222+
'Log2 4000 nits Shaper',
12231223
0.18,
12241224
-12.0,
12251225
12.0)
@@ -1261,7 +1261,7 @@ def create_shapers(aces_ctl_directory,
12611261
lut_directory,
12621262
lut_resolution_1d,
12631263
cleanup,
1264-
'Dolby PQ 48nits Shaper',
1264+
'Dolby PQ 48 nits Shaper',
12651265
0.18,
12661266
-6.5,
12671267
6.5)
@@ -1275,7 +1275,7 @@ def create_shapers(aces_ctl_directory,
12751275
lut_directory,
12761276
lut_resolution_1d,
12771277
cleanup,
1278-
'Dolby PQ 1000nits Shaper',
1278+
'Dolby PQ 1000 nits Shaper',
12791279
0.18,
12801280
-12.0,
12811281
10.0)
@@ -1289,7 +1289,7 @@ def create_shapers(aces_ctl_directory,
12891289
lut_directory,
12901290
lut_resolution_1d,
12911291
cleanup,
1292-
'Dolby PQ 2000nits Shaper',
1292+
'Dolby PQ 2000 nits Shaper',
12931293
0.18,
12941294
-12.0,
12951295
11.0)
@@ -1303,7 +1303,7 @@ def create_shapers(aces_ctl_directory,
13031303
lut_directory,
13041304
lut_resolution_1d,
13051305
cleanup,
1306-
'Dolby PQ 4000nits Shaper',
1306+
'Dolby PQ 4000 nits Shaper',
13071307
0.18,
13081308
-12.0,
13091309
12.0)
@@ -1354,9 +1354,9 @@ def create_ODTs(aces_ctl_directory,
13541354
# Assumes shaper has variants covering the range expected by the
13551355
# 48 nit, 1000 nit, 2000 nit and 4000 nit Ouput Transforms
13561356
rrt_shaper_48nits = shaper_data[shaper_name]
1357-
rrt_shaper_1000nits = shaper_data[shaper_name.replace("48nits", "1000nits")]
1358-
rrt_shaper_2000nits = shaper_data[shaper_name.replace("48nits", "2000nits")]
1359-
rrt_shaper_4000nits = shaper_data[shaper_name.replace("48nits", "4000nits")]
1357+
rrt_shaper_1000nits = shaper_data[shaper_name.replace("48 nits", "1000 nits")]
1358+
rrt_shaper_2000nits = shaper_data[shaper_name.replace("48 nits", "2000 nits")]
1359+
rrt_shaper_4000nits = shaper_data[shaper_name.replace("48 nits", "4000 nits")]
13601360

13611361
# *RRT + ODT* combinations.
13621362
sorted_odts = sorted(odt_info.iteritems(), key=lambda x: x[1])

aces_1.0.0/python/aces_ocio/generate_config.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1134,11 +1134,11 @@ def generate_baked_LUTs(odt_info,
11341134
odt_name = odt_values['transformUserName']
11351135

11361136
if odt_name in ['P3-D60 PQ (1000 nits)']:
1137-
odt_shaper = shaper_name.replace("48nits", "1000nits")
1137+
odt_shaper = shaper_name.replace("48 nits", "1000 nits")
11381138
elif odt_name in ['P3-D60 PQ (2000 nits)']:
1139-
odt_shaper = shaper_name.replace("48nits", "2000nits")
1139+
odt_shaper = shaper_name.replace("48 nits", "2000 nits")
11401140
elif odt_name in ['P3-D60 PQ (4000 nits)']:
1141-
odt_shaper = shaper_name.replace("48nits", "4000nits")
1141+
odt_shaper = shaper_name.replace("48 nits", "4000 nits")
11421142
else:
11431143
odt_shaper = shaper_name
11441144

@@ -1342,9 +1342,9 @@ def generate_config(aces_ctl_directory,
13421342
lmt_info = aces.get_LMTs_info(aces_ctl_directory)
13431343

13441344
if shaper_base_name == 'DolbyPQ':
1345-
shaper_name = 'Dolby PQ 48nits Shaper'
1345+
shaper_name = 'Dolby PQ 48 nits Shaper'
13461346
else:
1347-
shaper_name = 'Log2 48nits Shaper'
1347+
shaper_name = 'Log2 48 nits Shaper'
13481348

13491349
config_data = create_config_data(odt_info,
13501350
lmt_info,

0 commit comments

Comments
 (0)