Make recipe inputs private, add a getter method that deep clones the array

Author: calmilamsy

station-recipes-v0/src/main/java/net/modificationstation/stationapi/impl/recipe/StationShapedRecipe.java

@@ -9,16 +9,15 @@
 import net.modificationstation.stationapi.api.registry.ItemRegistry;
 import net.modificationstation.stationapi.api.tag.TagKey;
 
-import java.util.Optional;
-import java.util.Random;
+import java.util.*;
 import java.util.function.Function;
 
 public class StationShapedRecipe implements CraftingRecipe, StationRecipe {
 
     private static final Random RANDOM = new Random();
 
     public final int width, height;
-    public final Either<TagKey<Item>, ItemStack>[] grid;
+    private final Either<TagKey<Item>, ItemStack>[] grid;
     public final ItemStack output;
 
     public StationShapedRecipe(int width, int height, Either<TagKey<Item>, ItemStack>[] grid, ItemStack output) {
@@ -103,4 +102,9 @@ public ItemStack[] getIngredients() {
     public ItemStack[] getOutputs() {
         return new ItemStack[] { output };
     }
+
+    public Either<TagKey<Item>, ItemStack>[] getGrid() {
+        //noinspection unchecked
+        return (Either<TagKey<Item>, ItemStack>[]) Arrays.stream(grid).map(entry -> entry.mapRight(ItemStack::copy)).toArray(Either[]::new);
+    }
 }

station-recipes-v0/src/main/java/net/modificationstation/stationapi/impl/recipe/StationShapelessRecipe.java

@@ -9,16 +9,14 @@
 import net.modificationstation.stationapi.api.registry.ItemRegistry;
 import net.modificationstation.stationapi.api.tag.TagKey;
 
-import java.util.BitSet;
-import java.util.Optional;
-import java.util.Random;
+import java.util.*;
 import java.util.function.Function;
 
 public class StationShapelessRecipe implements CraftingRecipe, StationRecipe {
 
     private static final Random RANDOM = new Random();
 
-    public final Either<TagKey<Item>, ItemStack>[] ingredients;
+    private final Either<TagKey<Item>, ItemStack>[] ingredients;
     public final ItemStack output;
     public final BitSet matchedIngredients;
 
@@ -92,4 +90,13 @@ public ItemStack[] getIngredients() {
     public ItemStack[] getOutputs() {
         return new ItemStack[] { output };
     }
+
+    /**
+     * To be renamed to getIngredients in a3, use with caution.
+     */
+    @Deprecated
+    public Either<TagKey<Item>, ItemStack>[] getInputs() {
+        //noinspection unchecked
+        return (Either<TagKey<Item>, ItemStack>[]) Arrays.stream(ingredients).map(entry -> entry.mapRight(ItemStack::copy)).toArray(Either[]::new);
+    }
 }