Improved Object Creation and more Tests

CelestialEvent now has 1 Constructor and Methods for changing other Values.
Fixed Falling Dimando being impossible to happen.
Added Spinning Dimando and Burning Dimando.

Author: Atilist

src/test/java/net/modificationstation/sltest/celestial/CelestialListener.java

@@ -12,16 +12,22 @@ public class CelestialListener {
 
     public static CelestialEvent flyingDimando;
     public static CelestialEvent fallingDimando;
+    public static CelestialEvent spinningDimando;
+    public static CelestialEvent burningDimando;
 
     @EventListener
     public void registerCelestialEvents(CelestialRegisterEvent event) {
         if (hasRegistered) return;
         hasRegistered = true;
         SLTest.LOGGER.info("Register celestial events for testing");
-        flyingDimando = new CelestialEvent(2, "Flying Dimando");
-        fallingDimando = new CelestialEvent(4, "Falling Dimando");
+        flyingDimando = new CelestialEvent(4, "Flying Dimando");
+        fallingDimando = new CelestialEvent(2, "Falling Dimando");
+        spinningDimando = new CelestialEvent(4, "Spinning Dimando").setDayOffset(1);
+        burningDimando = new CelestialEvent(2, "Burning Dimando").setDayOffset(1);
         flyingDimando.addIncompatibleEvent(fallingDimando);
         CelestialTimeManager.addMorningEvent(flyingDimando);
         CelestialTimeManager.addNoonEvent(fallingDimando);
+        CelestialTimeManager.addEveningEvent(spinningDimando);
+        CelestialTimeManager.addMidnightEvent(burningDimando);
     }
 }

station-world-events-v0/src/main/java/net/modificationstation/stationapi/api/celestial/CelestialEvent.java

@@ -7,34 +7,33 @@
 public class CelestialEvent {
     private final String name;
     private final int frequency;
-    private final float chance;
-    private final int dayLength;
-    private final int dayOffset;
+    private float chance = 1;
+    private int dayLength = 24000;
+    private int dayOffset = 0;
     private boolean active;
     private final List<CelestialEvent> incompatibleEvents = new LinkedList<>();
 
-    public CelestialEvent(int frequency, float chance, int dayLength, int dayOffset, String name) {
+    public CelestialEvent(int frequency, String name) {
         this.frequency = frequency;
-        this.chance = chance;
-        this.dayLength = dayLength;
-        this.dayOffset = dayOffset;
         this.name = name;
     }
 
-    public CelestialEvent(int frequency, float chance, int dayLength, String name) {
-        this(frequency, chance, dayLength, 0, name);
+    public CelestialEvent setChance(float chance) {
+        this.chance = chance;
+        return this;
     }
 
-    public CelestialEvent(int frequency, float chance, String name) {
-        this(frequency, chance, 24000, name);
+    public CelestialEvent setDayLength(int dayLength) {
+        this.dayLength = dayLength;
+        return this;
     }
 
-    public CelestialEvent(int frequency, String name) {
-        this(frequency, 1, name);
+    public CelestialEvent setDayOffset(int dayOffset) {
+        this.dayOffset = dayOffset;
+        return this;
     }
 
     public boolean activateEvent(long worldTime, Random random) {
-        System.out.println("Attempt activation for event " + name);
         if (active) {
             return true;
         }
@@ -47,11 +46,12 @@ public boolean activateEvent(long worldTime, Random random) {
         }
         long days = worldTime / dayLength + dayOffset;
         active = days % frequency == 0 && random.nextFloat() <= chance;
+        if (active) System.out.println("Starting event " + name);
         return active;
     }
 
     public void stopEvent() {
-        System.out.println("Stopping event " + name);
+        if (active) System.out.println("Stopping event " + name);
         active = false;
     }