Skip to content

Commit 0468ac9

Browse files
authored
Merge pull request #14 from SkyBlade1978/master-1.16.5
Bring baseElectric to Minecraft 1.16.5
2 parents c5c8c9e + 0f39c02 commit 0468ac9

692 files changed

Lines changed: 4058 additions & 4045 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/workflows/ci.yml‎

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ permissions:
1010
contents: read
1111

1212
concurrency:
13-
group: electricadvantage-1.16-${{ github.workflow }}-${{ github.ref }}
13+
group: baseelectric-1.16-${{ github.workflow }}-${{ github.ref }}
1414
cancel-in-progress: true
1515

1616
jobs:
@@ -31,7 +31,7 @@ jobs:
3131
set -euo pipefail
3232
power_ref="$(sed -n 's/^poweradvantage_source_ref=//p' gradle.properties | tr -d '\r')"
3333
power_sha="$(sed -n 's/^poweradvantage_deobf_sha256=//p' gradle.properties | tr -d '\r')"
34-
if [[ "$power_ref" != "bcb75bfa91c14751ebf1e31865e1ec0ffa82c0b7" || "$power_sha" != "2FB923944A456B4F26AB2F9212C646469CE3F49BFD4DAE894C15559B48908386" ]]; then
34+
if [[ ! "$power_ref" =~ ^[a-f0-9]{40}$ || ! "$power_sha" =~ ^[A-F0-9]{64}$ ]]; then
3535
echo "PowerAdvantage 1.16.5 source/deobf pin differs from the audited candidate" >&2
3636
exit 1
3737
fi
@@ -51,9 +51,8 @@ jobs:
5151
- name: Check out PowerAdvantage 1.16.5
5252
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
5353
with:
54-
repository: MinecraftModDevelopmentMods/PowerAdvantage
55-
# Local-only Power source; publish upstream before hosted builds.
56-
ref: bcb75bfa91c14751ebf1e31865e1ec0ffa82c0b7
54+
repository: MinecraftModDevelopmentMods/basePower
55+
ref: ${{ steps.pins.outputs.power_ref }}
5756
path: .ci-dependencies/PowerAdvantage
5857
- name: Install pinned Java 25 Mavenizer runtime
5958
uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5
@@ -95,7 +94,7 @@ jobs:
9594
(cd "$power" && ./gradlew $MMD_GRADLE_TOOLCHAINS jar verifyReleaseDependencies \
9695
-PbaseMetalsDeobfJar="$bmjar" -PoreSpawnDeobfJar="$osjar" \
9796
--no-daemon --stacktrace)
98-
powerjar="$power/build/libs-dev/PowerAdvantage-2.4.7.116051-deobf.jar"
97+
powerjar="$power/build/libs-dev/basePower-2.4.8.116051-deobf.jar"
9998
test -f "$osjar" && test -f "$bmjar" && test -f "$powerjar"
10099
echo "orespawn=$osjar" >> "$GITHUB_OUTPUT"
101100
echo "basemetals=$bmjar" >> "$GITHUB_OUTPUT"
@@ -117,9 +116,9 @@ jobs:
117116
if-no-files-found: error
118117
retention-days: 30
119118
path: |
120-
build/libs/ElectricAdvantage-2.2.8.116051.jar
121-
build/libs/ElectricAdvantage-2.2.8.116051-sources.jar
122-
build/libs/ElectricAdvantage-2.2.8.116051-javadoc.jar
119+
build/libs/baseElectric-2.2.9.116051.jar
120+
build/libs/baseElectric-2.2.9.116051-sources.jar
121+
build/libs/baseElectric-2.2.9.116051-javadoc.jar
123122
build/release/SHA256SUMS
124123
CHANGELOG.txt
125124
- name: Upload diagnostics on failure

‎.github/workflows/codeql-analysis.yml‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
set -euo pipefail
3232
power_ref="$(sed -n 's/^poweradvantage_source_ref=//p' gradle.properties | tr -d '\r')"
3333
power_sha="$(sed -n 's/^poweradvantage_deobf_sha256=//p' gradle.properties | tr -d '\r')"
34-
if [[ "$power_ref" != "bcb75bfa91c14751ebf1e31865e1ec0ffa82c0b7" || "$power_sha" != "2FB923944A456B4F26AB2F9212C646469CE3F49BFD4DAE894C15559B48908386" ]]; then
34+
if [[ ! "$power_ref" =~ ^[a-f0-9]{40}$ || ! "$power_sha" =~ ^[A-F0-9]{64}$ ]]; then
3535
echo "PowerAdvantage 1.16.5 source/deobf pin differs from the audited candidate" >&2
3636
exit 1
3737
fi
@@ -51,9 +51,8 @@ jobs:
5151
- name: Check out PowerAdvantage 1.16.5
5252
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
5353
with:
54-
repository: MinecraftModDevelopmentMods/PowerAdvantage
55-
# Local-only Power source; publish upstream before hosted builds.
56-
ref: bcb75bfa91c14751ebf1e31865e1ec0ffa82c0b7
54+
repository: MinecraftModDevelopmentMods/basePower
55+
ref: ${{ steps.pins.outputs.power_ref }}
5756
path: .ci-dependencies/PowerAdvantage
5857
- name: Install pinned Java 25 Mavenizer runtime
5958
uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5
@@ -95,7 +94,7 @@ jobs:
9594
(cd "$power" && ./gradlew $MMD_GRADLE_TOOLCHAINS jar verifyReleaseDependencies \
9695
-PbaseMetalsDeobfJar="$bmjar" -PoreSpawnDeobfJar="$osjar" \
9796
--no-daemon --stacktrace)
98-
powerjar="$power/build/libs-dev/PowerAdvantage-2.4.7.116051-deobf.jar"
97+
powerjar="$power/build/libs-dev/basePower-2.4.8.116051-deobf.jar"
9998
test -f "$osjar" && test -f "$bmjar" && test -f "$powerjar"
10099
echo "orespawn=$osjar" >> "$GITHUB_OUTPUT"
101100
echo "basemetals=$bmjar" >> "$GITHUB_OUTPUT"

‎.github/workflows/release-on-tag.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ permissions:
1010
contents: read
1111

1212
concurrency:
13-
group: electricadvantage-release-tag-${{ github.ref_name }}
13+
group: baseelectric-release-tag-${{ github.ref_name }}
1414
cancel-in-progress: false
1515

1616
jobs:
1717
validate-release-tag:
1818
name: Validate tag for manual release confirmation
19-
if: github.repository == 'MinecraftModDevelopmentMods/ElectricAdvantage'
19+
if: github.repository == 'MinecraftModDevelopmentMods/baseElectric'
2020
runs-on: ubuntu-latest
2121
timeout-minutes: 10
2222

‎CHANGELOG.txt‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
baseElectric 2.2.9.116051 (Minecraft 1.16.5)
2+
3+
- Bring baseElectric to Minecraft 1.16.5 and use the shared basePower creative tab.
4+
- Map legacy Electric Advantage blocks, items and saved machine state to baseElectric when upgrading.
5+
- Fix Eclipse refreshes when ForgeGradle reuses an existing client or server launch.
6+
17
Electric Advantage 2.2.8.116051 (local port candidate)
28

39
- Check generator redstone before the first power pulse so a disabled solar panel cannot produce a startup burst.

‎README.md‎

Lines changed: 18 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,15 @@
1-
# Electric Advantage
2-
3-
**Minecraft 1.16.5 source port candidate, version 2.2.8.116051.**
4-
The follow-up checks measure finite machine jobs, energy and fluid conservation,
5-
blocked routes, real turret hits and full-process restarts. Rendered GUI checks
6-
require the correct labels as well as correctly placed controls. The shared
7-
record below identifies the current jars and each completed run; earlier
8-
results are retained separately rather than counted again. Broader player/entity
9-
checks retain a separately controlled vanilla wolf-health difference.
10-
Manual acceptance is pending. This is not a published release.
11-
See [the native port checklist](docs/NATIVE116.md).
12-
The [shared test record](https://github.com/MinecraftModDevelopmentMods/PowerAdvantage/blob/master-1.16.5/docs/1.16/CURRENT-QUALIFICATION.md)
13-
records the exact jars, completed checks and remaining limits.
14-
The [accepted 1.15 record](https://github.com/MinecraftModDevelopmentMods/PowerAdvantage/blob/master-1.15.2/docs/1.15/CURRENT-QUALIFICATION.md)
15-
is a behavior reference, not evidence that this target passes.
16-
17-
Electric Advantage adds electric machines, generation, storage, automation,
18-
and defence to Power Advantage for Minecraft 1.16.5.
1+
# baseElectric
2+
3+
**Minecraft 1.16.5, version 2.2.9.116051.**
4+
5+
Use [basePower 2.4.8.116051](https://www.curseforge.com/minecraft/mc-mods/basepower/files/9501921)
6+
and [Base Metals 3.1.1.116051](https://www.curseforge.com/minecraft/mc-mods/base-metals/files/9501458). The
7+
[shared test record](https://github.com/MinecraftModDevelopmentMods/basePower/blob/master-1.16.5/docs/1.16/BASE-RELEASE-CANDIDATE.md)
8+
covers machine operation, world upgrades and full restarts.
9+
10+
baseElectric continues DrCyano's Electric Advantage. It adds electric
11+
generation, storage, machinery and defence to basePower. Back up your world
12+
before upgrading; the port maps legacy Electric Advantage blocks and saved state.
1913

2014
## Build Target
2115

@@ -28,12 +22,12 @@ inference and downloads.
2822

2923
Build inputs are separate, non-embedded deobfuscated jars:
3024

31-
- Power Advantage `2.4.7.116051`: source `bcb75bfa91c14751ebf1e31865e1ec0ffa82c0b7`.
25+
- basePower `2.4.8.116051`.
3226
- Base Metals `3.1.1.116051`: source `995f6cc4dd2d5eecc628a42e5c43fa5390c24bca`.
3327
- OreSpawn `4.1.0.116051`: source `a113e5d767169189f0e35ade1e173a12d550b00e`.
3428

3529
Exact checksums are recorded in `gradle.properties`. Power deobf SHA-256 is
36-
`2FB923944A456B4F26AB2F9212C646469CE3F49BFD4DAE894C15559B48908386`.
30+
`156674F6DF6007D351AD419416344356F6586452077FCAE2E9BC9404EE14A14B`.
3731
The pinned Power source is available upstream. Do not bypass the release audits
3832
or substitute a preliminary jar.
3933
Use immutable copies for verification, not a sibling's output that another
@@ -82,10 +76,9 @@ launching. Do not add raw source metadata to the production classpath.
8276

8377
## Compatibility
8478

85-
The implementation namespace remains `zone.moddev.mc.electricadvantage`.
86-
Runtime registries, legacy aliases, tile/entity IDs, NBT keys, recipe IDs,
87-
ratios, tags, OreSpawn provider IDs and assets are retained. Electric uses
88-
Power Advantage's shared migration hook, dimension-key network registry,
79+
New saves use `baseelectric:*`. The shared upgrade code maps older
80+
`electricadvantage:*` IDs to their baseElectric equivalents and retains saved
81+
machine data. Electric uses basePower's shared migration hook, dimension-key network registry,
8982
capability adapters and native lifecycle contracts. It does not create
9083
synthetic numeric dimension IDs or a second capability implementation.
9184

@@ -102,13 +95,12 @@ The RF- and Tech Reborn-labelled converters belong to Power Advantage and use
10295
Forge Energy. Check live rendering, GUI interaction, sound, weapons,
10396
hydroturbine orientation and animation, multiplayer and real player login in
10497
game. Automated tag, machine and upgrade checks do not replace that walkthrough.
105-
No 1.16 publication is included before manual acceptance.
10698

10799
Always back up a whole world before upgrading and test only disposable copies.
108100
Keep migration backups and failed evidence. Bounded Advantage results never
109101
qualify unrelated mods or an arbitrary existing modpack.
110102

111-
The shared [machine operating checks](https://github.com/MinecraftModDevelopmentMods/PowerAdvantage/blob/master-1.16.5/docs/1.16/OPERATING-TESTS.md)
103+
The shared [machine operating checks](https://github.com/MinecraftModDevelopmentMods/basePower/blob/master-1.16.5/docs/1.16/OPERATING-TESTS.md)
112104
exercise finite processing, fabrication, growth, pumping, lighting, generation,
113105
battery and turret jobs. They check real output, damage and resource use, with
114106
blocked and starved controls and complete server restarts.

0 commit comments

Comments
 (0)