From 43bc0d23291a647f951bacea16aa9320933ffaf3 Mon Sep 17 00:00:00 2001 From: hieu-w Date: Wed, 21 Oct 2026 21:56:38 +0700 Subject: [PATCH] Clarify that swap commands do not use --wait and should not default to --yes. Agents were applying the global async --wait preference and unattended --yes to quote/execute/status even though swaps poll via status and the default flow is quote, review, then execute by ID. --- skills/metamask-agent-wallet/SKILL.md | 1 + skills/metamask-agent-wallet/references/swap.md | 2 ++ skills/metamask-agent-wallet/workflows/bridge.md | 1 + skills/metamask-agent-wallet/workflows/swap.md | 1 + 4 files changed, 5 insertions(+) diff --git a/skills/metamask-agent-wallet/SKILL.md b/skills/metamask-agent-wallet/SKILL.md index b68a36a..5ad19a9 100644 --- a/skills/metamask-agent-wallet/SKILL.md +++ b/skills/metamask-agent-wallet/SKILL.md @@ -312,6 +312,7 @@ When raw calldata is unfamiliar or was not constructed by you, run `mm decode -- In both server-wallet and BYOK mode, signing and transaction commands go through a job-polling loop and return a `pollingId`. Handle this consistently: 1. Prefer `--wait` to block until complete. + Swap commands (`swap quote`, `swap execute`, `swap status`) do not support `--wait`; use `swap status --quote-id` to poll progress instead. 2. If not using `--wait`, inform the user of the `pollingId` and how to track it: - `mm wallet requests list` - `mm wallet requests watch ` diff --git a/skills/metamask-agent-wallet/references/swap.md b/skills/metamask-agent-wallet/references/swap.md index 22b6b88..04a9f04 100644 --- a/skills/metamask-agent-wallet/references/swap.md +++ b/skills/metamask-agent-wallet/references/swap.md @@ -191,6 +191,8 @@ When the user has chosen a specific route, such as "use Across", and the origina ## Notes +- Swap commands do not support `--wait`. Track progress with `mm swap status --quote-id ` after execution. +- Don't add `--yes` unless the user explicitly asked for unattended execution. The default flow is quote → user review → execute by quote ID. - If the chain is not mentioned by the user, ask for the chain. - Use `mm chains list` to discover supported chain IDs. - Same-chain swap: omit `--to-chain-id`, which defaults to `--from-chain-id`. diff --git a/skills/metamask-agent-wallet/workflows/bridge.md b/skills/metamask-agent-wallet/workflows/bridge.md index e369b43..295f242 100644 --- a/skills/metamask-agent-wallet/workflows/bridge.md +++ b/skills/metamask-agent-wallet/workflows/bridge.md @@ -11,6 +11,7 @@ Reference command syntax in `references/swap.md`. The CLI uses the same `swap` c 3. Execute and track status. Don't skip the quote review step. The user needs to see output amount, fees, route, and slippage before executing. +Don't add `--yes` unless the user explicitly asked for unattended execution. ## Quote diff --git a/skills/metamask-agent-wallet/workflows/swap.md b/skills/metamask-agent-wallet/workflows/swap.md index 644846d..36bdb07 100644 --- a/skills/metamask-agent-wallet/workflows/swap.md +++ b/skills/metamask-agent-wallet/workflows/swap.md @@ -11,6 +11,7 @@ Reference command syntax in `references/swap.md`. 3. Execute and track status. Don't skip the quote review step. The user needs to see output amount, fees, route, and slippage before executing. +Don't add `--yes` unless the user explicitly asked for unattended execution. ## Quote