refactor: unify deposit constants for DRep and staking functionality

- Replaced hardcoded deposit values with constants from `protocol-deposit-constants` for DRep deregistration in `offchain.ts` and `retire.tsx`.
- Updated transaction handling logic in `useTransaction` to account for DRep deposit adjustments.
- Refactored `getTxBuilder` to use the new deposit constant for staking.
- Removed the deprecated `staking-constants.ts` file to streamline codebase and improve maintainability.

Author: Andre-Diamond

src/components/multisig/proxy/offchain.ts

@@ -7,6 +7,7 @@ import {
 } from "@meshsdk/core";
 import type { UTxO, MeshTxBuilder } from "@meshsdk/core";
 // import { parseDatumCbor } from "@meshsdk/core-cst";
+import { DREP_DEPOSIT_STRING } from "@/utils/protocol-deposit-constants";
 
 import { MeshTxInitiator } from "./common";
 import type { MeshTxInitiatorInput } from "./common";
@@ -501,7 +502,7 @@ export class MeshProxyContract extends MeshTxInitiator {
         anchorDataHash: anchorHash!,
       });
     } else if (action === "deregister") {
-      txHex.drepDeregistrationCertificate(drepId, "500000000");
+      txHex.drepDeregistrationCertificate(drepId, DREP_DEPOSIT_STRING);
     } else if (action === "update") {
       txHex.drepUpdateCertificate(drepId, {
         anchorUrl: anchorUrl!,

src/components/pages/wallet/governance/drep/retire.tsx

@@ -14,6 +14,7 @@ import { MeshProxyContract } from "@/components/multisig/proxy/offchain";
 import { api } from "@/utils/api";
 import { useCallback } from "react";
 import { useToast } from "@/hooks/use-toast";
+import { DREP_DEPOSIT_STRING } from "@/utils/protocol-deposit-constants";
 
 export default function Retire({ appWallet, manualUtxos }: { appWallet: Wallet; manualUtxos: UTxO[] }) {
   const network = useSiteStore((state) => state.network);
@@ -250,7 +251,7 @@ export default function Retire({ appWallet, manualUtxos }: { appWallet: Wallet;
       txBuilder
         .txInScript(scriptCbor)
         .changeAddress(changeAddress)
-        .drepDeregistrationCertificate(dRepId, "500000000");
+        .drepDeregistrationCertificate(dRepId, DREP_DEPOSIT_STRING);
 
       // Only add certificateScript if it's different from the spending script
       // to avoid "extraneous scripts" error

src/components/pages/wallet/staking/StakingActions/stake.tsx

@@ -8,7 +8,7 @@ import { MultisigWallet } from "@/utils/multisigSDK";
 import { ToastAction } from "@radix-ui/react-toast";
 import { toast } from "@/hooks/use-toast";
 import { getTxBuilder } from "@/utils/get-tx-builder";
-import { STAKE_KEY_DEPOSIT } from "@/utils/staking-constants";
+import { STAKE_KEY_DEPOSIT } from "@/utils/protocol-deposit-constants";
 import useTransaction from "@/hooks/useTransaction";
 
 type StakingAction = "register" | "deregister" | "delegate" | "withdrawal" | "registerAndDelegate";

src/components/pages/wallet/transactions/all-transactions.tsx

@@ -29,6 +29,7 @@ import useTransaction from "@/hooks/useTransaction";
 import React, { useEffect, useMemo, useState } from "react";
 import ResponsiveTransactionsTable from "./responsive-transactions-table";
 import type { LucideIcon } from "lucide-react";
+import { DREP_DEPOSIT } from "@/utils/protocol-deposit-constants";
 
 type CertificateInfo = {
   type: string;
@@ -290,12 +291,12 @@ function TransactionRow({
           <>
             {dbTransaction.description == "DRep registration" && (
                 <div className="text-red-400 font-medium text-sm">
-                  -{lovelaceToAda(500000000)} ₳
+                  -{lovelaceToAda(DREP_DEPOSIT)} ₳
               </div>
             )}
             {dbTransaction.description == "DRep retirement" && (
                 <div className="text-green-400 font-medium text-sm">
-                  +{lovelaceToAda(500000000)} ₳
+                  +{lovelaceToAda(DREP_DEPOSIT)} ₳
               </div>
             )}
           </>

src/hooks/useTransaction.ts

@@ -12,29 +12,65 @@ import {
   submitTxWithScriptRecovery,
 } from "@/utils/txSignUtils";
 import { getProvider } from "@/utils/get-provider";
-import { STAKE_KEY_DEPOSIT_LOVELACE } from "@/utils/staking-constants";
+import {
+  DREP_DEPOSIT_LOVELACE,
+  STAKE_KEY_DEPOSIT_LOVELACE,
+} from "@/utils/protocol-deposit-constants";
+
+function parseCoinToBigInt(value: unknown, fallback: bigint): bigint {
+  if (typeof value === "bigint") return value;
+  if (typeof value === "number" && Number.isFinite(value)) {
+    return BigInt(Math.trunc(value));
+  }
+  if (typeof value === "string" && value.trim().length > 0) {
+    try {
+      return BigInt(value);
+    } catch {
+      return fallback;
+    }
+  }
+  return fallback;
+}
 
-function getStakeKeyDepositDelta(txBuilder: MeshTxBuilder): bigint {
+function getCertificateCoinDelta(txBuilder: MeshTxBuilder): bigint {
   const body = txBuilder.meshTxBuilderBody as {
-    certificates?: Array<{ certType?: { type?: string } }>;
+    certificates?: Array<{
+      certType?: {
+        type?: string;
+        coin?: string | number | bigint;
+        deposit?: string | number | bigint;
+      };
+    }>;
   };
   const certs = body.certificates ?? [];
 
   let delta = 0n;
   for (const cert of certs) {
     const certType = cert?.certType?.type ?? "";
     const normalized = certType.toLowerCase();
-    const isDeregister =
-      normalized.includes("deregister") || normalized.includes("unregister");
-    const isRegister =
-      !isDeregister &&
-      (normalized.includes("registerstake") || normalized.includes("registration"));
+    const certCoin = cert?.certType?.coin ?? cert?.certType?.deposit;
+
+    if (normalized.includes("drepregistration")) {
+      delta -= parseCoinToBigInt(certCoin, DREP_DEPOSIT_LOVELACE);
+      continue;
+    }
+    if (normalized.includes("drepderegistration")) {
+      delta += parseCoinToBigInt(certCoin, DREP_DEPOSIT_LOVELACE);
+      continue;
+    }
+
+    const isStakeRegister =
+      normalized.includes("registerstake") || normalized.includes("stakeregistration");
+    const isStakeDeregister =
+      normalized.includes("deregisterstake") ||
+      normalized.includes("unregisterstake") ||
+      normalized.includes("stakederegistration");
 
-    if (isRegister) {
+    if (isStakeRegister) {
       delta -= STAKE_KEY_DEPOSIT_LOVELACE;
       continue;
     }
-    if (isDeregister) {
+    if (isStakeDeregister) {
       delta += STAKE_KEY_DEPOSIT_LOVELACE;
     }
   }
@@ -190,13 +226,13 @@ export default function useTransaction() {
 
       let unsignedTx = await data.txBuilder.complete();
 
-      // Workaround for stake cert txs where builder-produced change may not
-      // fully account for stake key deposit charge/refund in downstream validation.
-      const stakeDepositDelta = getStakeKeyDepositDelta(data.txBuilder);
-      if (stakeDepositDelta !== 0n) {
+      // Workaround for certificate txs where builder-produced change may not
+      // fully account for deposit charge/refund in downstream validation.
+      const certificateCoinDelta = getCertificateCoinDelta(data.txBuilder);
+      if (certificateCoinDelta !== 0n) {
         unsignedTx = adjustTxForStakeKeyDeposit(
           unsignedTx,
-          stakeDepositDelta,
+          certificateCoinDelta,
           appWallet.address,
         );
       }

src/utils/get-tx-builder.ts

@@ -1,6 +1,6 @@
 import { MeshTxBuilder } from "@meshsdk/core";
 import { getProvider } from "@/utils/get-provider";
-import { STAKE_KEY_DEPOSIT } from "@/utils/staking-constants";
+import { STAKE_KEY_DEPOSIT } from "@/utils/protocol-deposit-constants";
 // import { CSLSerializer } from "@meshsdk/core-csl";
 
 export function getTxBuilder(network: number) {

src/utils/protocol-deposit-constants.ts

@@ -0,0 +1,5 @@
+export const STAKE_KEY_DEPOSIT = 2_000_000;
+export const STAKE_KEY_DEPOSIT_LOVELACE = 2_000_000n;
+export const DREP_DEPOSIT = 500_000_000;
+export const DREP_DEPOSIT_LOVELACE = 500_000_000n;
+export const DREP_DEPOSIT_STRING = "500000000";