Skip to content

Commit 726cbfc

Browse files
jcfrjamesobutler
authored andcommitted
cmake: Set PYTHONQT_USE_RELEASE_PYTHON_FALLBACK as target compile property
This converts the `PYTHONQT_USE_RELEASE_PYTHON_FALLBACK` definition from a global add_definition to a target-specific compile definition and adds the CMake option `PythonQt_USE_RELEASE_PYTHON_FALLBACK` set to ON by default.
1 parent a6e735b commit 726cbfc

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,12 @@ endif()
5555

5656
find_package(PythonLibs REQUIRED)
5757
include_directories("${PYTHON_INCLUDE_DIR}")
58-
add_definitions(
59-
-DPYTHONQT_USE_RELEASE_PYTHON_FALLBACK
60-
)
6158

6259
#-----------------------------------------------------------------------------
6360
# Build options
6461

6562
option(PythonQt_SUPPORT_NAME_PROPERTY "Enable PythonQt name-property support" ON)
63+
option(PythonQt_USE_RELEASE_PYTHON_FALLBACK "Fallback to Release python when Debug missing" ON)
6664

6765
if(NOT DEFINED PythonQt_INSTALL_RUNTIME_DIR)
6866
set(PythonQt_INSTALL_RUNTIME_DIR bin)
@@ -321,6 +319,8 @@ set_target_properties(PythonQt PROPERTIES DEFINE_SYMBOL PYTHONQT_EXPORTS)
321319
target_compile_definitions(PythonQt
322320
PRIVATE
323321
$<$<BOOL:${PythonQt_SUPPORT_NAME_PROPERTY}>:PYTHONQT_SUPPORT_NAME_PROPERTY>
322+
PUBLIC
323+
$<$<BOOL:${PythonQt_USE_RELEASE_PYTHON_FALLBACK}>:PYTHONQT_USE_RELEASE_PYTHON_FALLBACK>
324324
)
325325

326326
target_compile_options(PythonQt PRIVATE

0 commit comments

Comments
 (0)