A few teething issues

[pallaswept]

Hi!

New release is very nice! I think I found some small bugs. I have a set of 'global conditions' at the top of my config, as well as conditions for each gesture. This is the top of my config:

mouse:
  gestures:

    - conditions:
        - $window_fullscreen == false
        - $plasma_overview_active == false
        - none:
            - window_class: FreeCAD

      gestures:
        - type: press
          mouse_buttons:
            - right
            - left
          mouse_buttons_exact_order: true
          instant: true
          conditions:
            - $cursor_shape == pointer

          actions:
            - on: begin
              input:
              - mouse: [ middle ]

        - type: press
          mouse_buttons:
            - right
            - left
          mouse_buttons_exact_order: true
          instant: true
          conditions:
            - all:
                - !$cursor_shape == pointer
                - window_class: firefox

          actions:
            - on: begin
              input:
                - keyboard: [ leftctrl+t ]

(And so on with more gestures)

I trimmed it down to just the above, started the GUI and just swapped the order of the mouse buttons and saved it.

The editor moves the conditions from the top and copies them into each gesture, which is functionally the same but means a lot of duplication in the config. I'm not sure if this is intentional but it's a bit unfortunate.

Also the config is then corrupted:

> inputactions config issues
27:17: error: Invalid condition.
24 |           - all:
25 |               - $window_fullscreen == false
26 |               - $plasma_overview_active == false
27 |               - "{window_class: FreeCAD}"
   |               ~~^~~~~~~~~~~~~~~~~~~~~~~~~
28 |           - $cursor_shape == pointer
29 |       actions:
30 |         - on: begin

Turns out that is my old config using the deprecated syntax for window_class conditions. I fixed that, which fixed the above, and then I got this:

> inputactions config issues
47:17: error: Invalid condition.
44 |               - $plasma_overview_active == false
45 |               - $window_class == FreeCAD
46 |           - all:
47 |               - _shape == pointer
   |               ~~^~~~~~~~~~~~~~~~~
48 |               - $window_class == firefox
49 |       actions:
50 |         - on: begin

It just kinda 'ate' the beginning of that variable. Maybe it didn't like negation?

Anyway, the UI is coming along really nicely! AppImage is working well here. Thanks!

[Luwx]

Currently the editor does not support nested gesture groups in yaml, so any config you put in the root gesture group (conditions, rules etc) will be either lost or merged in a possibly wrong way with the children gestures.

I've implemented a secondary group gesture feature in the editor but it has no nesting and shared properties, just a name for display. I'll implement the real gesture groups with nesting in the future (it will be a pain to make nested gesture groups in the ui). In the meanwhile it would be nice if input actions supported custom group properties like name/title/etc.

About the condition, apparently the '!' is for tags in yaml, you'll have to put the condition quotes for it to be correctly recognized like "!$cursor_shape == pointer", this is how the editor write negated conditions.

[pallaswept]

Look forward to it :) Thanks for the tip about my bad yaml. It's working but that's all luck and no skill :)

[taj-ny]

it would be nice if input actions supported custom group properties like name/title/etc.

Put any extra information not used by InputActions in _extra properties anywhere (value must be a map), I'll suppress the unused property warnings for them.

touchpad:
  gestures:
    - type: click
      fingers: 2
      _extra:
        title: Click 2

[Luwx]

it would be nice if input actions supported custom group properties like name/title/etc.

Put any extra information not used by InputActions in _extra properties anywhere (value must be a map), I'll suppress the unused property warnings for them.

touchpad:
gestures:
- type: click
fingers: 2
_extra:
title: Click 2

I've noticed that it is not giving a warning anymore for a config like this

mouse:
  gestures:
    - name: Right
      gestures:

        - type: stroke
          strokes:
            - "'ADEAAGQyZAA='"
          name: Delete
          mouse_buttons:
            - right
          actions:
            - input:
                - keyboard:
                    - delete

Do you recommend putting the title in _extra still?