From 7e3cfb4dfdb58f9283c48fb4985d7a331a7efc06 Mon Sep 17 00:00:00 2001 From: lojhan Date: Tue, 27 Oct 2026 19:30:16 -0300 Subject: [PATCH] chore: update Go setup and govern Node type majors --- .github/dependabot.yml | 4 ++++ .github/workflows/ci.yml | 26 +++++++++++------------ .github/workflows/editor-marketplaces.yml | 2 +- .github/workflows/pages.yml | 2 +- .github/workflows/release.yml | 4 ++-- CONTRIBUTING.md | 10 ++++++++- 6 files changed, 30 insertions(+), 18 deletions(-) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 3d15cfeb..80e05cfb 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -11,6 +11,10 @@ updates: open-pull-requests-limit: 10 commit-message: prefix: deps + # Node type majors are reviewed with the supported runtime matrix. + ignore: + - dependency-name: "@types/node" + update-types: ["version-update:semver-major"] - package-ecosystem: github-actions directory: / diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4bd0904f..30bca8cc 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -53,7 +53,7 @@ jobs: # Node 22.11 compatibility floor. node-version: 22.13 cache: pnpm - - uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6 + - uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 with: go-version: 1.27.3 cache: false @@ -97,7 +97,7 @@ jobs: with: node-version: ${{ matrix.node }} cache: pnpm - - uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6 + - uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 with: go-version: 1.27.3 cache: false @@ -152,7 +152,7 @@ jobs: with: node-version: 22.11 cache: pnpm - - uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6 + - uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 with: go-version: 1.27.3 cache: false @@ -192,7 +192,7 @@ jobs: with: node-version: 22.11 cache: pnpm - - uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6 + - uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 with: go-version: 1.27.3 cache: false @@ -282,7 +282,7 @@ jobs: with: node-version: 22.11 cache: pnpm - - uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6 + - uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 with: go-version: 1.27.3 cache: false @@ -324,7 +324,7 @@ jobs: with: node-version: 22.11 cache: pnpm - - uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6 + - uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 with: go-version: 1.27.3 cache: false @@ -358,7 +358,7 @@ jobs: with: node-version: 22.13 cache: pnpm - - uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6 + - uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 with: go-version: 1.27.3 cache: false @@ -392,7 +392,7 @@ jobs: with: node-version: ${{ matrix.node }} cache: pnpm - - uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6 + - uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 with: go-version: 1.27.3 cache: false @@ -434,7 +434,7 @@ jobs: with: node-version: ${{ matrix.node }} cache: pnpm - - uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6 + - uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 with: go-version: 1.27.3 cache: false @@ -521,7 +521,7 @@ jobs: with: node-version: 24 cache: pnpm - - uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6 + - uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 with: go-version: 1.27.3 cache: false @@ -551,7 +551,7 @@ jobs: with: node-version: 22.13 cache: pnpm - - uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6 + - uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 with: go-version: 1.27.3 cache: false @@ -588,7 +588,7 @@ jobs: with: node-version: 22.13 cache: pnpm - - uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6 + - uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 with: go-version: 1.27.3 cache: false @@ -618,7 +618,7 @@ jobs: with: node-version: 24 cache: pnpm - - uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6 + - uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 with: go-version: 1.27.3 cache: false diff --git a/.github/workflows/editor-marketplaces.yml b/.github/workflows/editor-marketplaces.yml index e1ed9bf5..ec98632f 100644 --- a/.github/workflows/editor-marketplaces.yml +++ b/.github/workflows/editor-marketplaces.yml @@ -42,7 +42,7 @@ jobs: with: node-version: 24 cache: pnpm - - uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6 + - uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 with: go-version: 1.27.3 cache: false diff --git a/.github/workflows/pages.yml b/.github/workflows/pages.yml index 31f103da..4c9bf87a 100644 --- a/.github/workflows/pages.yml +++ b/.github/workflows/pages.yml @@ -33,7 +33,7 @@ jobs: with: node-version: 22.14 cache: pnpm - - uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6 + - uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 with: go-version: 1.27.3 cache: false diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 563534c9..57ab86c2 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -41,7 +41,7 @@ jobs: with: node-version: 22.14 cache: pnpm - - uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6 + - uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 with: go-version: 1.27.3 cache: false @@ -75,7 +75,7 @@ jobs: node-version: 24 package-manager-cache: false - run: npm install --global npm@12.2.1 - - uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6 + - uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 with: go-version: 1.27.3 cache: false diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 940e13c3..dadc6476 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -35,6 +35,14 @@ TYPED_SQL_CONTAINER_ENGINE=podman pnpm e2e:packed Replace `podman` with `docker` when appropriate. +## Maintain dependencies + +The development baseline uses Node.js 24 type declarations while runtime compatibility is +verified separately at the documented Node.js minimum and current supported versions. Review +major `@types/node` upgrades explicitly against that runtime matrix; Dependabot continues to +propose compatible updates within the current major. Do not treat a newer type declaration +package as evidence that newer Node.js APIs are available at the runtime minimum. + ## Add tests where behavior lives Tests use [Poku](https://poku.io/) and are ordinary TypeScript programs. Put a test in the package @@ -59,7 +67,7 @@ pnpm --filter ./editors/vscode package:vsix pnpm --filter ./editors/vscode test:host ``` -The suite downloads VS Code 1.134.0 and installs the VSIX into separate extension/profile +The suite downloads VS Code 1.140.0 and installs the VSIX into separate extension/profile directories for trusted, Restricted Mode, virtual-workspace and real-overlay scenarios. The first three use a controlled server probe to assert whether the client executes workspace code. The overlay matrix uses PostgreSQL, MySQL, SQLite and the synthetic third-party grammar, built workspace