Skip to content

Commit f05f12a

Browse files
Refactor away from factory implementation for data conversion (including test + demo updates)
1 parent f0189dc commit f05f12a

10 files changed

Lines changed: 320 additions & 2388 deletions

File tree

examples/gssha_demo.ipynb

Lines changed: 86 additions & 1958 deletions
Large diffs are not rendered by default.

src/xarray_data_accessor/__init__.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,9 @@
1717
from xarray_data_accessor.data_accessors.factory import (
1818
DataAccessorFactory,
1919
)
20-
from xarray_data_accessor.data_converters.factory import (
21-
DataConversionFactory,
22-
DataConversionFunctions,
23-
)
2420
import xarray_data_accessor.shared_types as shared_types
25-
21+
from xarray_data_accessor.data_converters import (
22+
ConvertToTable,
23+
ConvertToGSSHA,
24+
)
2625
from xarray_data_accessor.multi_threading import get_multithread
Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,3 @@
1-
"""Stores concrete implementations of base.ConverterBase.
2-
3-
Each python file stores a separate converter class that can be used convert a
4-
xarray dataset to some other format.
5-
6-
Each DataAccessor is registered with the DataConverterFactory.
7-
"""
8-
# import all the data converters (this updates the factory class)
1+
"""Init file for data_converters module"""
92
from xarray_data_accessor.data_converters.to_tables import ConvertToTable
103
from xarray_data_accessor.data_converters.to_gssha import ConvertToGSSHA
11-
12-
# init the wrapper class (updates class attributes)
13-
from xarray_data_accessor.data_converters.factory import (
14-
DataConversionFunctions,
15-
)
16-
DataConversionFunctions.add_functions()

src/xarray_data_accessor/data_converters/base.py

Lines changed: 0 additions & 17 deletions
This file was deleted.

src/xarray_data_accessor/data_converters/factory.py

Lines changed: 0 additions & 123 deletions
This file was deleted.

0 commit comments

Comments
 (0)