Core (Benchmarks): Use std::string_view for string arguments.

Author: kaixiong

libvisual/tools/benchmarks/actor_bench.cpp

@@ -3,24 +3,28 @@
 #include <iostream>
 #include <memory>
 #include <stdexcept>
+#include <string>
+#include <string_view>
 #include <cstdlib>
 
+using namespace std::string_literals;
+
 namespace {
 
   class ActorBench
       : public LV::Tools::Benchmark
   {
   public:
 
-      ActorBench (std::string const& actor_name, unsigned int width, unsigned height, VisVideoDepth depth, bool forced_depth)
+      ActorBench (std::string_view actor_name, unsigned int width, unsigned height, VisVideoDepth depth, bool forced_depth)
           : Benchmark { "ActorBench" }
           , m_actor { LV::Actor::load (actor_name) }
       {
           (void)width;
           (void)height;
 
           if (!m_actor) {
-              throw std::invalid_argument ("Cannot load actor '" + actor_name);
+              throw std::invalid_argument {"Cannot load actor '"s + std::string {actor_name}};
           }
 
           m_actor->realize ();

libvisual/tools/benchmarks/benchmark.hpp

@@ -2,6 +2,7 @@
 #define _LV_TOOLS_BENCHMARK_HPP
 
 #include <string>
+#include <string_view>
 
 namespace LV {
   namespace Tools {
@@ -22,8 +23,8 @@ namespace LV {
 
     protected:
 
-        explicit Benchmark (std::string const& name)
-            : m_name (name)
+        explicit Benchmark (std::string_view name)
+            : m_name {name}
         {}
 
     private:

libvisual/tools/benchmarks/morph_bench.cpp

@@ -3,21 +3,25 @@
 #include <iostream>
 #include <memory>
 #include <stdexcept>
+#include <string>
+#include <string_view>
 #include <cstdlib>
 
 namespace {
 
+  using namespace std::string_literals;
+
   class MorphBench
       : public LV::Tools::Benchmark
   {
   public:
 
-      MorphBench (std::string const& morph_name, unsigned int width, unsigned int height, VisVideoDepth depth)
+      MorphBench (std::string_view morph_name, unsigned int width, unsigned int height, VisVideoDepth depth)
           : Benchmark { "MorphBench" }
           , m_morph { LV::Morph::load (morph_name) }
       {
           if (!m_morph) {
-              throw std::invalid_argument ("Cannot load morph " + morph_name);
+              throw std::invalid_argument {"Cannot load morph "s + std::string {morph_name}};
           }
 
           m_morph->realize ();