From 8066c976dcad6a6e352bafa26c10341c5bb20d09 Mon Sep 17 00:00:00 2001 From: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> Date: Fri, 13 Nov 2026 17:14:58 +0000 Subject: [PATCH 1/4] fix(openapi): declare optional sign-request headers Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> --- lib/Controller/IdDocsController.php | 4 ++++ lib/Controller/SignatureElementsController.php | 3 +++ 2 files changed, 7 insertions(+) diff --git a/lib/Controller/IdDocsController.php b/lib/Controller/IdDocsController.php index 66357ccf40..523978732e 100644 --- a/lib/Controller/IdDocsController.php +++ b/lib/Controller/IdDocsController.php @@ -20,6 +20,7 @@ use OCP\AppFramework\Http\Attribute\NoAdminRequired; use OCP\AppFramework\Http\Attribute\NoCSRFRequired; use OCP\AppFramework\Http\Attribute\PublicPage; +use OCP\AppFramework\Http\Attribute\RequestHeader; use OCP\AppFramework\Http\DataResponse; use OCP\IL10N; use OCP\IRequest; @@ -62,6 +63,7 @@ public function __construct( #[AnonRateLimit(limit: 30, period: 60)] #[NoAdminRequired] #[NoCSRFRequired] + #[RequestHeader(name: 'libresign-sign-request-uuid', description: 'The UUID of the sign request, used to identify the request', indirect: true)] #[RequireSignRequestUuid(skipIfAuthenticated: true)] #[ApiRoute(verb: 'POST', url: '/api/{apiVersion}/id-docs', requirements: ['apiVersion' => '(v1)'])] public function addFiles(array $files): DataResponse { @@ -111,6 +113,7 @@ public function addFiles(array $files): DataResponse { #[AnonRateLimit(limit: 30, period: 60)] #[NoAdminRequired] #[NoCSRFRequired] + #[RequestHeader(name: 'libresign-sign-request-uuid', description: 'The UUID of the sign request, used to identify the request', indirect: true)] #[RequireSignRequestUuid(skipIfAuthenticated: true)] #[ApiRoute(verb: 'DELETE', url: '/api/{apiVersion}/id-docs/{nodeId}', requirements: ['apiVersion' => '(v1)'])] public function delete(int $nodeId, ?string $uuid = null): DataResponse { @@ -150,6 +153,7 @@ public function delete(int $nodeId, ?string $uuid = null): DataResponse { #[PublicPage] #[AnonRateLimit(limit: 30, period: 60)] #[NoCSRFRequired] + #[RequestHeader(name: 'libresign-sign-request-uuid', description: 'The UUID of the sign request, used to identify the request', indirect: true)] #[RequireSignRequestUuid(skipIfAuthenticated: true)] #[ApiRoute(verb: 'GET', url: '/api/{apiVersion}/id-docs', requirements: ['apiVersion' => '(v1)'])] public function listOfUnauthenticatedSigner( diff --git a/lib/Controller/SignatureElementsController.php b/lib/Controller/SignatureElementsController.php index 7fd14de4ac..b5aed45bc4 100644 --- a/lib/Controller/SignatureElementsController.php +++ b/lib/Controller/SignatureElementsController.php @@ -159,6 +159,7 @@ public function getSignatureElements(): DataResponse { #[NoAdminRequired] #[PublicPage] #[NoCSRFRequired] + #[RequestHeader(name: 'libresign-sign-request-uuid', description: 'The UUID of the sign request, used to identify the request', indirect: true)] #[RequireSignRequestUuid(skipIfAuthenticated: true)] #[ApiRoute(verb: 'GET', url: '/api/{apiVersion}/signature/elements/preview/{nodeId}', requirements: ['apiVersion' => '(v1)'])] public function getSignatureElementPreview(int $nodeId) { @@ -239,6 +240,7 @@ public function getSignatureElement(int $nodeId): DataResponse { #[NoAdminRequired] #[PublicPage] #[NoCSRFRequired] + #[RequestHeader(name: 'libresign-sign-request-uuid', description: 'The UUID of the sign request, used to identify the request', indirect: true)] #[RequireSignRequestUuid(skipIfAuthenticated: true)] #[ApiRoute(verb: 'PATCH', url: '/api/{apiVersion}/signature/elements/{nodeId}', requirements: ['apiVersion' => '(v1)'])] public function patchSignatureElement(int $nodeId, string $type = '', array $file = []): DataResponse { @@ -295,6 +297,7 @@ public function patchSignatureElement(int $nodeId, string $type = '', array $fil #[NoAdminRequired] #[NoCSRFRequired] #[PublicPage] + #[RequestHeader(name: 'libresign-sign-request-uuid', description: 'The UUID of the sign request, used to identify the request', indirect: true)] #[RequireSignRequestUuid(skipIfAuthenticated: true)] #[ApiRoute(verb: 'DELETE', url: '/api/{apiVersion}/signature/elements/{nodeId}', requirements: ['apiVersion' => '(v1)'])] public function deleteSignatureElement(int $nodeId): DataResponse { From dd0b3d7120cdefd474767e8630c99b248d051a7e Mon Sep 17 00:00:00 2001 From: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> Date: Sat, 14 Nov 2026 13:14:35 +0000 Subject: [PATCH 2/4] fix(signing): require signer context when requesting verification code Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> --- .../_partials/ModalVerificationCode.spec.ts | 20 +++++++++++++++++++ .../_partials/ModalVerificationCode.vue | 1 + 2 files changed, 21 insertions(+) diff --git a/src/tests/views/SignPDF/_partials/ModalVerificationCode.spec.ts b/src/tests/views/SignPDF/_partials/ModalVerificationCode.spec.ts index d205f438c3..16152b5afd 100644 --- a/src/tests/views/SignPDF/_partials/ModalVerificationCode.spec.ts +++ b/src/tests/views/SignPDF/_partials/ModalVerificationCode.spec.ts @@ -530,6 +530,7 @@ describe('ModalVerificationCode requestCode route (#8365)', () => { signStore.document = { ...signStore.document, uuid: 'id-doc-file-uuid', + fileId: 42, signers: [{ me: false, sign_request_uuid: 'external-signer-uuid', email: 'external@example.com' }], settings: { isApprover: true }, } as typeof signStore.document @@ -549,6 +550,7 @@ describe('ModalVerificationCode requestCode route (#8365)', () => { signStore.document = { ...signStore.document, uuid: 'file-uuid', + fileId: 42, signers: [{ me: true, sign_request_uuid: 'my-signer-uuid' }], settings: { isApprover: false }, } as typeof signStore.document @@ -565,6 +567,7 @@ describe('ModalVerificationCode requestCode route (#8365)', () => { signStore.document = { ...signStore.document, uuid: 'file-uuid', + fileId: 42, signers: [{ me: true, sign_request_uuid: 'my-signer-uuid' }], settings: { isApprover: true }, } as typeof signStore.document @@ -575,4 +578,21 @@ describe('ModalVerificationCode requestCode route (#8365)', () => { const [url] = vi.mocked(axios.post).mock.calls[0] expect(url).toBe('/ocs/v2.php/apps/libresign/api/v1/sign/uuid/my-signer-uuid/code') }) + it('does not request a code with fileId alone when signer UUID is unavailable', async () => { + const signStore = useSignStore() + signStore.document = { + ...signStore.document, + fileId: 42, + uuid: 'file-uuid', + signers: [], + settings: { isApprover: false }, + } as typeof signStore.document + + const wrapper = mountToken() + await wrapper.vm.requestCode() + + expect(axios.post).not.toHaveBeenCalled() + expect(wrapper.vm.tokenRequested).toBe(false) + expect(wrapper.vm.loading).toBe(false) + }) }) diff --git a/src/views/SignPDF/_partials/ModalVerificationCode.vue b/src/views/SignPDF/_partials/ModalVerificationCode.vue index 45399870aa..3bf324dd4e 100644 --- a/src/views/SignPDF/_partials/ModalVerificationCode.vue +++ b/src/views/SignPDF/_partials/ModalVerificationCode.vue @@ -402,6 +402,7 @@ async function requestCode() { } await axios.post(signStore.buildRequestCodeUrl(signRequestUuid), params) } + await axios.post(signStore.buildRequestCodeUrl(signRequestUuid), params) if (props.mode === 'email') { signMethodsStore.setHasEmailConfirmCode(true) From f1c0e6cc5f9964260a67238226fc46826e8f422e Mon Sep 17 00:00:00 2001 From: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> Date: Sat, 14 Nov 2026 13:16:31 +0000 Subject: [PATCH 3/4] chore(signing): remove obsolete route helper import chore(signing): remove obsolete route helper import Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> [skip ci] --- src/views/SignPDF/_partials/ModalVerificationCode.vue | 1 - 1 file changed, 1 deletion(-) diff --git a/src/views/SignPDF/_partials/ModalVerificationCode.vue b/src/views/SignPDF/_partials/ModalVerificationCode.vue index 3bf324dd4e..81029715d0 100644 --- a/src/views/SignPDF/_partials/ModalVerificationCode.vue +++ b/src/views/SignPDF/_partials/ModalVerificationCode.vue @@ -147,7 +147,6 @@ import md5 from 'blueimp-md5' import axios from '@nextcloud/axios' import { showError } from '@nextcloud/dialogs' import { loadState } from '@nextcloud/initial-state' -import { generateOcsUrl } from '@nextcloud/router' import NcButton from '@nextcloud/vue/components/NcButton' import NcDialog from '@nextcloud/vue/components/NcDialog' From 2f479387595bc311ea177fe9083d70ed51ca43f4 Mon Sep 17 00:00:00 2001 From: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> Date: Sat, 14 Nov 2026 18:19:11 +0000 Subject: [PATCH 4/4] fix(signing): use UUID context for verification code on stable33 Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> --- .../_partials/ModalVerificationCode.vue | 20 ++++++------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/src/views/SignPDF/_partials/ModalVerificationCode.vue b/src/views/SignPDF/_partials/ModalVerificationCode.vue index 81029715d0..66b7bf1a8c 100644 --- a/src/views/SignPDF/_partials/ModalVerificationCode.vue +++ b/src/views/SignPDF/_partials/ModalVerificationCode.vue @@ -386,20 +386,12 @@ async function requestCode() { signMethod: activeTokenMethod.value, } - if (signStore.document.fileId) { - await axios.post( - generateOcsUrl('/apps/libresign/api/v1/sign/file_id/{fileId}/code', { - fileId: signStore.document.fileId, - }), - params, - ) - } else { - // Same route/context decision as signing (Sign.vue). - const signRequestUuid = getSigningRouteUuid(signStore.document) - if (!signRequestUuid) { - throw new Error(t('libresign', 'Document not found')) - } - await axios.post(signStore.buildRequestCodeUrl(signRequestUuid), params) + // Resolve signer or approver context even when a fileId is available. + // Both verification code routes require a UUID in the signing middleware. + const signRequestUuid = getSigningRouteUuid(signStore.document) + if (!signRequestUuid) { + // TRANSLATORS Error when the document has no usable signing context. + throw new Error(t('libresign', 'Document not found')) } await axios.post(signStore.buildRequestCodeUrl(signRequestUuid), params)