diff --git a/lib/Listener/SignedCallbackListener.php b/lib/Listener/SignedCallbackListener.php index d3f54339d2..b9cfad5ee6 100644 --- a/lib/Listener/SignedCallbackListener.php +++ b/lib/Listener/SignedCallbackListener.php @@ -8,6 +8,7 @@ namespace OCA\Libresign\Listener; +use OCA\Libresign\Enum\FileStatus; use OCA\Libresign\Events\SignedEvent; use OCA\Libresign\Service\SignFileService; use OCP\EventDispatcher\Event; @@ -27,9 +28,10 @@ public function handle(Event $event): void { return; } - $updatedFields = $event->getLibreSignFile()->getUpdatedFields(); - if (isset($updatedFields['signed']) && $updatedFields['signed'] === true) { - $this->signFileService->notifyCallback($event->getSignedFile()); + if ($event->getLibreSignFile()->getStatus() !== FileStatus::SIGNED->value) { + return; } + + $this->signFileService->notifyCallback($event->getSignedFile()); } } diff --git a/tests/php/Unit/Listener/SignedCallbackListenerTest.php b/tests/php/Unit/Listener/SignedCallbackListenerTest.php new file mode 100644 index 0000000000..de48b2306d --- /dev/null +++ b/tests/php/Unit/Listener/SignedCallbackListenerTest.php @@ -0,0 +1,53 @@ + [FileStatus::ABLE_TO_SIGN, false], + 'partially signed' => [FileStatus::PARTIAL_SIGNED, false], + 'completed' => [FileStatus::SIGNED, true], + ]; + } + + #[DataProvider('completionStatuses')] + public function testLegacyCallbackOnlyFiresOnDocumentCompletion(FileStatus $status, bool $expected): void { + $document = new FileEntity(); + $document->setStatus($status->value); + $signedFile = $this->createMock(File::class); + $event = $this->createMock(SignedEvent::class); + $event->method('getLibreSignFile')->willReturn($document); + $event->method('getSignedFile')->willReturn($signedFile); + + $service = $this->createMock(SignFileService::class); + $service->expects($expected ? $this->once() : $this->never()) + ->method('notifyCallback') + ->with($signedFile); + + (new SignedCallbackListener($service))->handle($event); + } + + public function testIgnoresUnrelatedEvents(): void { + $service = $this->createMock(SignFileService::class); + $service->expects($this->never())->method('notifyCallback'); + + (new SignedCallbackListener($service))->handle(new Event()); + } +}