LB_UPLOADS_IMAGE_UPLOAD_URL should remove Web/ ?

[ikke-t]

Hi,

while testing the move of logo and favicon location to /Web/upload/images path I noticed I get double Web in URL in browser while it fails to show the uploaded images. Also now someone in support channel is experiencing the same. I removed the Web/ from:

LB_UPLOADS_IMAGE_UPLOAD_URL=Web/uploads/images

and it fixed the error. Also it fixed the error from the person in chat. I haven't dig into code why there is Web there and why shouldn't it be, but I know removing it fixes the problem. So perhaps we should remove it from both podman and docker examples?

What do you think? I dunno why it is ok in reservations, but I assume the logo code actually writes the script_url part in there, where as the reservations don't.

[colisee]

If I set LB_UPLOADS_IMAGE_UPLOAD_URL=uploads/images, then the picture I assign to the resource is no longer displayed (see screenshot below) and I can see the following error in the web browser console log: manage_resources.php:683 GET http://localhost:8080/uploads/images/resource41782811835.jpg 403 (Forbidden).

[colisee]

@ikke-t : I didn't follow the whole discussion on custom favicons in the upstream github repo. Could you please tell me:

1. Where you put your custom favicon (full path)
2. Which php code looks for your custom favicon

[ikke-t]

╰─⠠⠵ podman exec -ti librebooking-app ls -la Web/uploads/images
total 24
drwxr-xr-x. 1 10034    root    86 Jun 28 09:11 .
drwxrwxr-x. 1 www-data root    22 Jun 17 08:19 ..
-rw-r--r--. 1 10034    root 15406 Jun 28 09:11 custom-favicon.ico
-rw-r--r--. 1 10034    root  8070 Jun 28 09:11 custom-logo.png
-rwxrwxr-x. 1 10034    root     0 Jun 17 08:17 index.html

This is where they go now. Actually it's rewritten by John now.

I believe you can see here from his commit how it handles upload now: LibreBooking/librebooking@99b8409#diff-57e9b7cab301698cafc4c0af2837c4bcf2291b16a8437044316de5a89ead9519

            $imageUploadDirectory = new ImageUploadDirectory();
            $uploadDir = $imageUploadDirectory->GetDirectory();
            $target = $uploadDir . '/custom-logo.' . $logoFile->Extension();

Presenters/Admin/ManageThemePresenter.php, in my git fork.

I had to wipe my db, so I don't have any resource images, so I didn't notice the problem you get.