[ONEM-41930]: Avoid crashing with null answers during session load

hridhya-narayanan-infosys · marcin-mielczarczyk-red · commit 5e3487ea360f · 2025-08-14T12:32:08.000+02:00
OpenCDM/Thunder can answer with a null message when loading a wrong session.
diff --git a/Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp b/Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp
@@ -624,7 +624,7 @@ void CDMInstanceSessionThunder::loadSession(LicenseType, const String& sessionID
             }
         } else {
             GST_ERROR("session %s not loaded", m_sessionID.utf8().data());
-            if (responseMessage->isEmpty())
+            if (!responseMessage || responseMessage->isEmpty())
                 callback(std::nullopt, std::nullopt, std::nullopt, SuccessValue::Failed, sessionLoadFailureFromThunder({ }));
             else {
                 auto responseData = responseMessage->extractData();
@@ -634,8 +634,10 @@ void CDMInstanceSessionThunder::loadSession(LicenseType, const String& sessionID
             }
         }
     });
-    if (!m_session || m_sessionID.isEmpty() || opencdm_session_load(m_session->get()))
+    if (!m_session || m_sessionID.isEmpty() || opencdm_session_load(m_session->get())) {
+        GST_DEBUG("loading failed");
         sessionFailure();
+    }
 }
 
 void CDMInstanceSessionThunder::closeSession(const String& sessionID, CloseSessionCallback&& callback)

Original file line number	Diff line number	Diff line change
`@@ -624,7 +624,7 @@ void CDMInstanceSessionThunder::loadSession(LicenseType, const String& sessionID`
`624`	`624`	`}`
`625`	`625`	`} else {`
`626`	`626`	`GST_ERROR("session %s not loaded", m_sessionID.utf8().data());`
`627`		`- if (responseMessage->isEmpty())`
	`627`	`+ if (!responseMessage \|\| responseMessage->isEmpty())`
`628`	`628`	`callback(std::nullopt, std::nullopt, std::nullopt, SuccessValue::Failed, sessionLoadFailureFromThunder({ }));`
`629`	`629`	`else {`
`630`	`630`	`auto responseData = responseMessage->extractData();`
`@@ -634,8 +634,10 @@ void CDMInstanceSessionThunder::loadSession(LicenseType, const String& sessionID`
`634`	`634`	`}`
`635`	`635`	`}`
`636`	`636`	`});`
`637`		`- if (!m_session \|\| m_sessionID.isEmpty() \|\| opencdm_session_load(m_session->get()))`
	`637`	`+ if (!m_session \|\| m_sessionID.isEmpty() \|\| opencdm_session_load(m_session->get())) {`
	`638`	`+ GST_DEBUG("loading failed");`
`638`	`639`	`sessionFailure();`
	`640`	`+ }`
`639`	`641`	`}`
`640`	`642`
`641`	`643`	`void CDMInstanceSessionThunder::closeSession(const String& sessionID, CloseSessionCallback&& callback)`