Skip to content

Commit 40fa12f

Browse files
committed
Cleanup logging dependencies
removed the global test dependency on slf4j-nop, because it clutters the dependency information and is in many cases just wrong (e.g. the build-tools module has no such dependency). As a consequence, the maven tests now log error messages about missing slf4j implementations again. For now however, this seems to be the best solution, since none of the LearnLib modules actually require a logging implementation as it is merely a dependency for the end-user, who will use LearnLib. The best example is the 'examples' module, for which a logback runtime dependency was added.
1 parent 2e49865 commit 40fa12f

2 files changed

Lines changed: 6 additions & 15 deletions

File tree

examples/pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,5 +110,11 @@ limitations under the License.
110110
<groupId>net.automatalib</groupId>
111111
<artifactId>automata-commons-dotutil</artifactId>
112112
</dependency>
113+
114+
<dependency>
115+
<groupId>ch.qos.logback</groupId>
116+
<artifactId>logback-classic</artifactId>
117+
<scope>runtime</scope>
118+
</dependency>
113119
</dependencies>
114120
</project>

pom.xml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1096,12 +1096,6 @@ limitations under the License.
10961096
<version>${slf4j.version}</version>
10971097
</dependency>
10981098

1099-
<dependency>
1100-
<groupId>org.slf4j</groupId>
1101-
<artifactId>slf4j-nop</artifactId>
1102-
<version>${slf4j.version}</version>
1103-
</dependency>
1104-
11051099
<dependency>
11061100
<groupId>ch.qos.logback</groupId>
11071101
<artifactId>logback-core</artifactId>
@@ -1117,15 +1111,6 @@ limitations under the License.
11171111
</dependencies>
11181112
</dependencyManagement>
11191113

1120-
<dependencies>
1121-
<!-- prevent error messages about missing slf4j implementation during test executions -->
1122-
<dependency>
1123-
<groupId>org.slf4j</groupId>
1124-
<artifactId>slf4j-nop</artifactId>
1125-
<scope>test</scope>
1126-
</dependency>
1127-
</dependencies>
1128-
11291114
<pluginRepositories>
11301115
<!-- Ensure preference over the atlassian plugin repository -->
11311116
<pluginRepository>

0 commit comments

Comments
 (0)