Improve config parser resiliency, closes #216

Author: Pyrofab

cardinal-components-base/src/main/java/org/ladysnake/cca/internal/base/ComponentsInternals.java

@@ -54,13 +54,19 @@ public static void init() {
         try(Reader reader = Files.newBufferedReader(path)) {
             Properties cfg = new Properties();
             cfg.load(reader);
-            if (Integer.parseInt(cfg.getProperty("config-version")) < configVersion) {
+            try {
+                if (Integer.parseInt(cfg.getProperty("config-version")) < configVersion) {
+                    writeConfigFile(path);
+                    cfg.clear();
+                }
+                logDeserializationWarnings = Boolean.parseBoolean(cfg.getProperty("log-deserialization-warnings", String.valueOf(DEFAULT_LOG_DESERIALIZATION_WARNINGS)));
+                maxWarningsPerComponent = Integer.parseInt(cfg.getProperty("max-deserialization-warnings", String.valueOf(DEFAULT_MAX_WARNINGS_PER_COMPONENT)));
+            } catch (NumberFormatException e) {
+                LOGGER.error("Config file at {} contains invalid values, resetting", path, e);
                 writeConfigFile(path);
-                cfg.clear();
             }
-            logDeserializationWarnings = Boolean.parseBoolean(cfg.getProperty("log-deserialization-warnings", String.valueOf(DEFAULT_LOG_DESERIALIZATION_WARNINGS)));
-            maxWarningsPerComponent = Integer.parseInt(cfg.getProperty("max-deserialization-warnings", String.valueOf(DEFAULT_MAX_WARNINGS_PER_COMPONENT)));
-        } catch (IOException e) {
+        } catch (IOException | IllegalArgumentException e) {
+            LOGGER.error("Invalid config file at {}, resetting", path, e);
             writeConfigFile(path);
         }
     }

changelog.md

@@ -18,6 +18,9 @@ Starting with alpha-5, world data from previous minecraft versions should be mig
 - Components attached to a `LevelData` object (using the `cardinal-components-leveldata` module) can no longer use dynamic registries in serialization (vanilla limitation)
 - `ComponentContainer.Builder#build(String)` (had been deprecated for removal for a couple years now)
 
+**Fixes**
+- Fixed game crashing when CCA's config file was invalid
+
 ------------------------------------------------------
 Version 7.3.1
 ------------------------------------------------------