Skip to content

Commit caf4a4c

Browse files
committed
hprasing
1 parent 3772223 commit caf4a4c

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎.claude/commands/tdd-review.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ For each test file, check against these criteria:
5959
|--------------|-------------------|
6060
| **The Liar** | `expect(true).toBe(true)`, empty test bodies, tests with no assertions |
6161
| **Excessive Setup** | >20 lines of arrange code, >5 mocks, deep nested object construction |
62-
| **The One** | Assertions covering unrelated behaviors in a single test, or several Acts strung together under one name - count alone is not the signal, since one Arrange and Act can warrant many assertions |
62+
| **The One** | Multiple Acts in a unit test, Acts from unrelated scenarios strung together under one name, or assertions that don't trace back to one of the test's Acts - assertion count alone is not the signal, since a single Act can warrant many assertions, and E2E or other multi-step flows legitimately chain several sequential Acts within one scenario |
6363
| **The Peeping Tom** | Testing private methods, asserting on internal state, tests that break on any refactor |
6464
| **The Slow Poke** | Real database/network calls, file I/O, hard-coded timeouts |
6565

‎.config/.copier-answers.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Changes here will be overwritten by Copier
2-
_commit: v0.0.151-17-g7f4ed3c9
2+
_commit: v0.0.151-19-g09bc4e1a
33
_src_path: gh:LabAutomationAndScreening/copier-base-template.git
44
copier_answers_directory: .config
55
description: Copier template for creating Python libraries and executables

‎template/.claude/commands/tdd-review.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ For each test file, check against these criteria:
5959
|--------------|-------------------|
6060
| **The Liar** | `expect(true).toBe(true)`, empty test bodies, tests with no assertions |
6161
| **Excessive Setup** | >20 lines of arrange code, >5 mocks, deep nested object construction |
62-
| **The One** | Assertions covering unrelated behaviors in a single test, or several Acts strung together under one name - count alone is not the signal, since one Arrange and Act can warrant many assertions |
62+
| **The One** | Multiple Acts in a unit test, Acts from unrelated scenarios strung together under one name, or assertions that don't trace back to one of the test's Acts - assertion count alone is not the signal, since a single Act can warrant many assertions, and E2E or other multi-step flows legitimately chain several sequential Acts within one scenario |
6363
| **The Peeping Tom** | Testing private methods, asserting on internal state, tests that break on any refactor |
6464
| **The Slow Poke** | Real database/network calls, file I/O, hard-coded timeouts |
6565

0 commit comments

Comments
 (0)