You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 657352c
Browse filesBrowse the repository at this point in the historyBrowse files
Copier update: prepare for the prek migration (#113)
Pull in upstream template changes, tested in downstream repo
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Developer Tooling**
* Updated pinned versions of Python and JavaScript tooling and added
installation of `prek`.
* Improved lock-file-only setup for JavaScript projects and refined
validation output and CI failure reporting.
* SHA tags are now limited to builds on the default branch.
* **Configuration**
* Updated template-managed settings and guidance to reflect current CI
checks.
* Restricted validation commands from selecting alternate configurations
or repository locations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Copy file name to clipboardExpand all lines: .claude/settings/permissions/bash.jsonc
+11Lines changed: 11 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -19,6 +19,7 @@
19
19
"Bash(aws sts get*)",
20
20
// Code Quality & Formatting
21
21
"Bash(pre-commit run *)",
22
+
"Bash(prek run *)",
22
23
// Core Shell Commands
23
24
"Bash(COMMAND *)", // used in slash commands
24
25
"Bash(kill *)",
@@ -165,6 +166,16 @@
165
166
"Bash(task --dir=*)",
166
167
"Bash(task -g *)",
167
168
"Bash(task --global *)",
169
+
// Same reasoning for the hook runners: they must run the repo's own reviewed .pre-commit-config.yaml, and these flags are how to point them at another config or another repo
Copy file name to clipboardExpand all lines: .coderabbit.yaml
+4-4Lines changed: 4 additions & 4 deletions
Original file line number
Diff line number
Diff line change
@@ -13,7 +13,7 @@ reviews:
13
13
- path: "**/vendor_files/**"
14
14
instructions: "These files came from a vendor and we're not allowed to change them. Refer to it if you need to understand how the main code interacts with it, but do not make comments about it."
15
15
- path: "**/*.py"
16
-
instructions: "Never express concerns about potential ruff rule violations, even those rules mentioned in other agent instructions; a pre-commit hook already runs a ruff check. Do not warn about unnecessary super().__init__() calls; pyrefly prefers those to be present. Do not warn about missing type hints; a pre-commit hook already checks for that."
16
+
instructions: "Never express concerns about potential ruff rule violations, even those rules mentioned in other agent instructions; the CI pipeline already runs a ruff check. Do not warn about unnecessary super().__init__() calls; pyrefly prefers those to be present. Do not warn about missing type hints; the CI pipeline already checks for that."
17
17
- path: "**/.copier-answers.yml"
18
18
instructions: "Do not comment about the `_commit` value needing to be a clean release tag. A CI job will fail if that is not the case."
19
19
- path: ".config/.copier-managed-files.json"
@@ -26,11 +26,11 @@ reviews:
26
26
appears in multiple entries, the last entry is the authoritative owner; use parent_src to
27
27
trace the full chain and identify the correct template repo for backporting.
28
28
tools:
29
-
eslint: # when the code contains typescript, eslint will be run by pre-commit, and coderabbit often generates false positives
29
+
eslint: # when the code contains typescript, eslint will be run in the CI pipeline, and coderabbit often generates false positives
30
30
enabled: false
31
-
ruff: # when the code contains python, ruff will be run by pre-commit, and coderabbit often generates false positives
31
+
ruff: # when the code contains python, ruff will be run in the CI pipeline, and coderabbit often generates false positives
32
32
enabled: false
33
-
pylint: # when the code contains python, pylint will be run by pre-commit, and coderabbit often generates false positives
33
+
pylint: # when the code contains python, pylint will be run in the CI pipeline, and coderabbit often generates false positives
34
34
enabled: false
35
35
flake8: # we use ruff instead (when we use Python)
# Task is installed outside the --no-node branch because CI always passes --no-node (pnpm/setup handles pnpm there), and every job still needs the task runner
Copy file name to clipboardExpand all lines: .github/actions/install_deps/action.yml
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -92,7 +92,7 @@ runs:
92
92
uses: pnpm/setup@v2.1.0
93
93
with:
94
94
# an empty version makes pnpm/setup read it from the manifest in working-directory instead. Passing both a version and a package.json with a conflicting `packageManager` field is a hard error in pnpm/setup.
0 commit comments