From e95e568d4b733d7dcb90569fd55ec4bf470abee0 Mon Sep 17 00:00:00 2001
From: Zerui Ge <gezerui1997@gmail.com>
Date: Sat, 7 Nov 2026 21:50:12 +0800
Subject: [PATCH] Fix @grad for qualified function names

---
 src/macros.jl       |  2 +-
 test/MacrosTests.jl | 44 +++++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 44 insertions(+), 2 deletions(-)

diff --git a/src/macros.jl b/src/macros.jl
index 0fe3d96..884fbdf 100644
--- a/src/macros.jl
+++ b/src/macros.jl
@@ -180,7 +180,7 @@ The `@grad` macro provides a way for the users to define custom adjoints for sin
 macro grad(expr)
     d = MacroTools.splitdef(expr)
     f = d[:name]
-    closure = gensym(f)
+    closure = gensym(:grad)
     d[:name] = closure
     closure_ex = MacroTools.combinedef(d)
 
diff --git a/test/MacrosTests.jl b/test/MacrosTests.jl
index 082f394..e6cdfd3 100644
--- a/test/MacrosTests.jl
+++ b/test/MacrosTests.jl
@@ -1,4 +1,4 @@
-using ReverseDiff, ForwardDiff, Test, StaticArrays
+using ReverseDiff, ForwardDiff, Test, StaticArrays, DiffResults
 using ForwardDiff: Dual, Partials, partials
 
 include(joinpath(dirname(@__FILE__), "utils.jl"))
@@ -342,3 +342,45 @@ using ReverseDiff: @grad, TrackedReal, TrackedVector, TrackedMatrix, TrackedArra
     @test g1 == g2
     @test custom_grad_called
 end
+
+module GradFunctionNames
+    using ReverseDiff
+
+    qualified(x) = sum(abs2, x)
+    qualified(x::ReverseDiff.TrackedArray) = ReverseDiff.track(qualified, x)
+
+    unqualified(x) = sum(abs2, x)
+    unqualified(x::ReverseDiff.TrackedArray) = ReverseDiff.track(unqualified, x)
+    ReverseDiff.@grad function unqualified(x)
+        xv = ReverseDiff.value(x)
+        return unqualified(xv), Δ -> (2 .* Δ .* xv,)
+    end
+end
+
+ReverseDiff.@grad function GradFunctionNames.qualified(x)
+    xv = ReverseDiff.value(x)
+    return GradFunctionNames.qualified(xv), Δ -> (2 .* Δ .* xv,)
+end
+
+@testset "@grad function names" begin
+    for f in (GradFunctionNames.qualified, GradFunctionNames.unqualified)
+        x = [1.0, 2.0, 3.0]
+        y = [-2.0, 0.5, 4.0]
+        @test ReverseDiff.gradient(f, x) == [2.0, 4.0, 6.0]
+        @test ReverseDiff.gradient(f, y) == [-4.0, 1.0, 8.0]
+
+        tape = ReverseDiff.GradientTape(f, x)
+        for t in (tape, ReverseDiff.compile(tape))
+            for (input, value, gradient) in (
+                    (x, 14.0, [2.0, 4.0, 6.0]),
+                    (y, 20.25, [-4.0, 1.0, 8.0]),
+                    (x, 14.0, [2.0, 4.0, 6.0]),
+                )
+                result = DiffResults.GradientResult(copy(input))
+                ReverseDiff.gradient!(result, t, input)
+                @test DiffResults.value(result) == value
+                @test DiffResults.gradient(result) == gradient
+            end
+        end
+    end
+end