Skip to content

[access-dev-tunnel-cutover] - Remove OAuth and management Connect token providers #1571

Description

@JoshuaRowePhantom

Part of #1513 and master #1505

Parent

Dependencies

Summary

Delete the two stateful legacy providers after their behavior resides in typed identity and Connect executors.

Current Limitation / Root Cause

OAuthDevTunnelAuthProvider and ManagementApiDevTunnelConnectTokenProvider retain parallel caches, refresh, raw string material, and provider interfaces.

Affected Files

Path Change
Phantom.Workspaces/Services/DevTunnel/OAuthDevTunnelAuthProvider.cs Remove or update only the named bounded production surface.
Phantom.Workspaces/Services/DevTunnel/ManagementApiDevTunnelConnectTokenProvider.cs Remove or update only the named bounded production surface.
Focused test file Add only the tests listed below.

Design / Fix

// Remove OAuthDevTunnelAuthProvider.
// Remove ManagementApiDevTunnelConnectTokenProvider.

OAuth identity and Connect mint/cache behavior must already be covered by #1557 and #1558 focused tests.

Security and Privacy Invariants

  • No credential material, provider artifact, unsafe identifier, or raw provider output is introduced or copied during removal.
  • Replacement callers already use typed broker requests and caller-owned leases.
  • Removal fails the build if an undeclared production reference remains; it does not leave a fallback.

Exclusions

  • No unrelated provider, UI, persistence-format, or behavioral redesign.
  • No bridge, migration reader, or dual production path.

Commit Plan

Commit 1 — [access-dev-tunnel-cutover] - Remove OAuth and management Connect token providers

Production types: OAuthDevTunnelAuthProvider, ManagementApiDevTunnelConnectTokenProvider.

Acceptance: one independently buildable commit affecting only the files above plus AccessMigrationTests.

Expected Tests

Test Name Class What It Verifies
AccessMigration_DevTunnelTree_HasNoOAuthTokenProvider AccessMigrationTests Verifies the bounded cutover with no remaining production reference.
AccessMigration_DevTunnelTree_HasNoManagementConnectTokenProvider AccessMigrationTests Verifies the bounded cutover with no remaining production reference.
AccessMigration_DevTunnelExecutors_RetainRequiredOAuthAndMintTests AccessMigrationTests Verifies the bounded cutover with no remaining production reference.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    diagnosedRoot cause identifiedenhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions