Part of #1513 and master #1505
Parent
Dependencies
Summary
Delete the old identity/Connect provider interfaces and raw OAuth delegate factory.
Current Limitation / Root Cause
Keeping these interfaces would allow callers to bypass broker release, renewal, and lease rules.
Affected Files
| Path |
Change |
Phantom.Workspaces/Services/DevTunnel/IDevTunnelAuthTokenProvider.cs |
Implement the bounded production change owned by this issue. |
Phantom.Workspaces/Services/DevTunnel/IDevTunnelConnectTokenProvider.cs |
Implement the bounded production change owned by this issue. |
Phantom.Workspaces/Services/DevTunnel/DevTunnelAuthTokenProviderFactory.cs |
Implement the bounded production change owned by this issue. |
| Focused test file |
Add only the tests listed below. |
Design / Fix
This slice implements the following exact contract:
// Remove:
// IDevTunnelAuthTokenProvider
// IDevTunnelConnectTokenProvider
// DevTunnelAuthTokenProviderFactory raw acquisition delegates
Delete only the two interfaces and raw factory after #1570 and #1571 remove every implementation. Update the remaining construction reference to typed executors; no alternate path remains.
Use required-init properties and named object initializers. The commit must build and its focused tests must pass without relying on a second implementation slice landing in the same commit.
Security and Privacy Invariants
- Release/use authorization occurs before material access or provider interaction whenever this slice can reach either boundary.
- No token, secret value, OAuth state, verifier, authorization URL, signed URL, device code, callback, account name, unsafe identifier, or credential-bearing result enters UI-safe state, logs, notifications, entities, or persistence.
- Typed results remain caller-owned and disposable; provider/cache artifacts remain executor-owned.
- Errors are typed and sanitized; no broad catch or success-shaped fallback is introduced.
Exclusions
- No batch API, compatibility bridge, legacy-data migration, silent interactive renewal, or unrelated provider work.
- No production types beyond the bounded files/classes named here.
- No UI work unless this issue is explicitly a UI slice.
Commit Plan
Commit 1 — [access-dev-tunnel-cutover] - Remove parallel Dev Tunnel token providers
Production scope: Phantom.Workspaces/Services/DevTunnel/IDevTunnelAuthTokenProvider.cs, Phantom.Workspaces/Services/DevTunnel/IDevTunnelConnectTokenProvider.cs, Phantom.Workspaces/Services/DevTunnel/DevTunnelAuthTokenProviderFactory.cs.
Tests: AccessMigrationTests methods listed below.
Acceptance: one small coherent commit; no opportunistic adjacent migration.
Expected Tests
| Test Name |
Class |
What It Verifies |
AccessMigration_DevTunnelTree_HasNoIdentityTokenProviderInterface |
AccessMigrationTests |
Verifies the named contract and leaves adjacent slices independently testable. |
AccessMigration_DevTunnelTree_HasNoConnectTokenProviderInterface |
AccessMigrationTests |
Verifies the named contract and leaves adjacent slices independently testable. |
AccessMigration_DevTunnelTree_HasNoRawOAuthTokenDelegate |
AccessMigrationTests |
Verifies the named contract and leaves adjacent slices independently testable. |
Part of #1513 and master #1505
Parent
Dependencies
Summary
Delete the old identity/Connect provider interfaces and raw OAuth delegate factory.
Current Limitation / Root Cause
Keeping these interfaces would allow callers to bypass broker release, renewal, and lease rules.
Affected Files
Phantom.Workspaces/Services/DevTunnel/IDevTunnelAuthTokenProvider.csPhantom.Workspaces/Services/DevTunnel/IDevTunnelConnectTokenProvider.csPhantom.Workspaces/Services/DevTunnel/DevTunnelAuthTokenProviderFactory.csDesign / Fix
This slice implements the following exact contract:
Delete only the two interfaces and raw factory after #1570 and #1571 remove every implementation. Update the remaining construction reference to typed executors; no alternate path remains.
Use required-init properties and named object initializers. The commit must build and its focused tests must pass without relying on a second implementation slice landing in the same commit.
Security and Privacy Invariants
Exclusions
Commit Plan
Commit 1 — [access-dev-tunnel-cutover] - Remove parallel Dev Tunnel token providers
Production scope:
Phantom.Workspaces/Services/DevTunnel/IDevTunnelAuthTokenProvider.cs,Phantom.Workspaces/Services/DevTunnel/IDevTunnelConnectTokenProvider.cs,Phantom.Workspaces/Services/DevTunnel/DevTunnelAuthTokenProviderFactory.cs.Tests:
AccessMigrationTestsmethods listed below.Acceptance: one small coherent commit; no opportunistic adjacent migration.
Expected Tests
AccessMigration_DevTunnelTree_HasNoIdentityTokenProviderInterfaceAccessMigrationTestsAccessMigration_DevTunnelTree_HasNoConnectTokenProviderInterfaceAccessMigrationTestsAccessMigration_DevTunnelTree_HasNoRawOAuthTokenDelegateAccessMigrationTests