Merge pull request #12 from vasilievip/master

Additional fixes for violations found by code analysis

Author: wumpz

src/main/java/net/sf/jsqlparser/expression/CastExpression.java

@@ -31,7 +31,7 @@ public class CastExpression implements Expression {
 
 	private Expression leftExpression;
 	private ColDataType type;
-	boolean useCastKeyword;
+	private boolean useCastKeyword;
 
 	public ColDataType getType() {
 		return type;

src/main/java/net/sf/jsqlparser/expression/Expression.java

@@ -23,5 +23,5 @@
 
 public interface Expression {
 
-	public void accept(ExpressionVisitor expressionVisitor);
+	void accept(ExpressionVisitor expressionVisitor);
 }

src/main/java/net/sf/jsqlparser/expression/ExpressionVisitor.java

@@ -49,91 +49,91 @@
 
 public interface ExpressionVisitor {
 
-	public void visit(NullValue nullValue);
+	void visit(NullValue nullValue);
 
-	public void visit(Function function);
+	void visit(Function function);
 
-	public void visit(InverseExpression inverseExpression);
+	void visit(InverseExpression inverseExpression);
 
-	public void visit(JdbcParameter jdbcParameter);
+	void visit(JdbcParameter jdbcParameter);
 
-	public void visit(DoubleValue doubleValue);
+	void visit(DoubleValue doubleValue);
 
-	public void visit(LongValue longValue);
+	void visit(LongValue longValue);
 
-	public void visit(DateValue dateValue);
+	void visit(DateValue dateValue);
 
-	public void visit(TimeValue timeValue);
+	void visit(TimeValue timeValue);
 
-	public void visit(TimestampValue timestampValue);
+	void visit(TimestampValue timestampValue);
 
-	public void visit(Parenthesis parenthesis);
+	void visit(Parenthesis parenthesis);
 
-	public void visit(StringValue stringValue);
+	void visit(StringValue stringValue);
 
-	public void visit(Addition addition);
+	void visit(Addition addition);
 
-	public void visit(Division division);
+	void visit(Division division);
 
-	public void visit(Multiplication multiplication);
+	void visit(Multiplication multiplication);
 
-	public void visit(Subtraction subtraction);
+	void visit(Subtraction subtraction);
 
-	public void visit(AndExpression andExpression);
+	void visit(AndExpression andExpression);
 
-	public void visit(OrExpression orExpression);
+	void visit(OrExpression orExpression);
 
-	public void visit(Between between);
+	void visit(Between between);
 
-	public void visit(EqualsTo equalsTo);
+	void visit(EqualsTo equalsTo);
 
-	public void visit(GreaterThan greaterThan);
+	void visit(GreaterThan greaterThan);
 
-	public void visit(GreaterThanEquals greaterThanEquals);
+	void visit(GreaterThanEquals greaterThanEquals);
 
-	public void visit(InExpression inExpression);
+	void visit(InExpression inExpression);
 
-	public void visit(IsNullExpression isNullExpression);
+	void visit(IsNullExpression isNullExpression);
 
-	public void visit(LikeExpression likeExpression);
+	void visit(LikeExpression likeExpression);
 
-	public void visit(MinorThan minorThan);
+	void visit(MinorThan minorThan);
 
-	public void visit(MinorThanEquals minorThanEquals);
+	void visit(MinorThanEquals minorThanEquals);
 
-	public void visit(NotEqualsTo notEqualsTo);
+	void visit(NotEqualsTo notEqualsTo);
 
-	public void visit(Column tableColumn);
+	void visit(Column tableColumn);
 
-	public void visit(SubSelect subSelect);
+	void visit(SubSelect subSelect);
 
-	public void visit(CaseExpression caseExpression);
+	void visit(CaseExpression caseExpression);
 
-	public void visit(WhenClause whenClause);
+	void visit(WhenClause whenClause);
 
-	public void visit(ExistsExpression existsExpression);
+	void visit(ExistsExpression existsExpression);
 
-	public void visit(AllComparisonExpression allComparisonExpression);
+	void visit(AllComparisonExpression allComparisonExpression);
 
-	public void visit(AnyComparisonExpression anyComparisonExpression);
+	void visit(AnyComparisonExpression anyComparisonExpression);
 
-	public void visit(Concat concat);
+	void visit(Concat concat);
 
-	public void visit(Matches matches);
+	void visit(Matches matches);
 
-	public void visit(BitwiseAnd bitwiseAnd);
+	void visit(BitwiseAnd bitwiseAnd);
 
-	public void visit(BitwiseOr bitwiseOr);
+	void visit(BitwiseOr bitwiseOr);
 
-	public void visit(BitwiseXor bitwiseXor);
+	void visit(BitwiseXor bitwiseXor);
 
-	public void visit(CastExpression cast);
+	void visit(CastExpression cast);
 
-	public void visit(Modulo modulo);
+	void visit(Modulo modulo);
 
-	public void visit(AnalyticExpression aexpr);
+	void visit(AnalyticExpression aexpr);
 
-	public void visit(ExtractExpression eexpr);
+	void visit(ExtractExpression eexpr);
 
-	public void visit(IntervalExpression iexpr);
+	void visit(IntervalExpression iexpr);
 }

src/main/java/net/sf/jsqlparser/expression/LongValue.java

@@ -34,7 +34,7 @@ public LongValue(String value) {
 			value = value.substring(1);
 		}
 		this.value = Long.parseLong(value);
-		setStringValue(value);
+        this.stringValue = value;
 	}
 
 	@Override

src/main/java/net/sf/jsqlparser/expression/operators/relational/ItemsList.java

@@ -27,5 +27,5 @@
  */
 public interface ItemsList {
 
-	public void accept(ItemsListVisitor itemsListVisitor);
+	void accept(ItemsListVisitor itemsListVisitor);
 }

src/main/java/net/sf/jsqlparser/expression/operators/relational/ItemsListVisitor.java

@@ -25,9 +25,9 @@
 
 public interface ItemsListVisitor {
 
-	public void visit(SubSelect subSelect);
+	void visit(SubSelect subSelect);
 
-	public void visit(ExpressionList expressionList);
+	void visit(ExpressionList expressionList);
 
-	public void visit(MultiExpressionList multiExprList);
+	void visit(MultiExpressionList multiExprList);
 }

src/main/java/net/sf/jsqlparser/expression/operators/relational/MultiExpressionList.java

@@ -44,8 +44,6 @@
 import java.util.Iterator;
 import java.util.List;
 import net.sf.jsqlparser.expression.Expression;
-import net.sf.jsqlparser.statement.select.FromItem;
-import net.sf.jsqlparser.statement.select.FromItemVisitor;
 
 /**
  * A list of ExpressionList items. e.g. multi values of insert statements. This
@@ -55,7 +53,7 @@
  */
 public class MultiExpressionList implements ItemsList {
 
-	List<ExpressionList> exprList;
+	private List<ExpressionList> exprList;
 
 	public MultiExpressionList() {
 		this.exprList = new ArrayList<ExpressionList>();

src/main/java/net/sf/jsqlparser/parser/CCJSqlParserManager.java

@@ -21,9 +21,7 @@
  */
 package net.sf.jsqlparser.parser;
 
-import java.io.InputStream;
 import java.io.Reader;
-import java.io.StringReader;
 
 import net.sf.jsqlparser.JSQLParserException;
 import net.sf.jsqlparser.statement.Statement;

src/main/java/net/sf/jsqlparser/parser/CCJSqlParserUtil.java

@@ -24,16 +24,14 @@
 import java.io.InputStream;
 import java.io.Reader;
 import java.io.StringReader;
-import java.util.logging.Level;
-import java.util.logging.Logger;
 import net.sf.jsqlparser.JSQLParserException;
 import net.sf.jsqlparser.statement.Statement;
 
 /**
  * Toolfunctions to start and use JSqlParser.
  * @author toben
  */
-public class CCJSqlParserUtil {
+public final class CCJSqlParserUtil {
 	public static Statement parse(Reader statementReader) throws JSQLParserException {
 		CCJSqlParser parser = new CCJSqlParser(statementReader);
 		try {

src/main/java/net/sf/jsqlparser/parser/JSqlParser.java

@@ -31,5 +31,5 @@
  */
 public interface JSqlParser {
 
-	public Statement parse(Reader statementReader) throws JSQLParserException;
+	Statement parse(Reader statementReader) throws JSQLParserException;
 }