Move inline_threshold value checks into setter.

Author: Diptorup Deb

numba_dpex/core/codegen.py

@@ -48,6 +48,12 @@ def inline_threshold(self, value: int):
             )
             self._inline_threshold = 0
         else:
+            if value == 3:
+                warnings.warn(
+                    "Due to an existing compiler bug, setting INLINE_THRESHOLD "
+                    f"to {value} can lead to incorrect code generation on "
+                    "certain devices."
+                )
             self._inline_threshold = value
 
     def _optimize_final_module(self):
@@ -64,15 +70,7 @@ def _optimize_final_module(self):
             )
 
         pmb.disable_unit_at_a_time = False
-
-        if hasattr(self, "_inline_threshold") and self._inline_threshold > 0:
-            if self._inline_threshold >= 3:
-                warnings.warn(
-                    "Due to an existing compiler bug, setting INLINE_THRESHOLD "
-                    f"to {self._inline_threshold} can lead to incorrect "
-                    "code generation on certain devices."
-                )
-            pmb.inlining_threshold = self._inline_threshold
+        pmb.inlining_threshold = self.inline_threshold
 
         pmb.disable_unroll_loops = True
         pmb.loop_vectorize = False

numba_dpex/tests/misc/test_warnings.py

@@ -12,7 +12,7 @@ def foo(a):
     a[dpex.get_global_id(0)] = 0
 
 
-def test_opt_warning(caplog):
+def test_opt_warning():
     bkp = config.DPEX_OPT
     config.DPEX_OPT = 3
 
@@ -22,7 +22,7 @@ def test_opt_warning(caplog):
     config.DPEX_OPT = bkp
 
 
-def test_inline_warning(caplog):
+def test_inline_threshold_eq_3_warning():
     bkp = config.INLINE_THRESHOLD
     config.INLINE_THRESHOLD = 3
 
@@ -32,7 +32,27 @@ def test_inline_warning(caplog):
     config.INLINE_THRESHOLD = bkp
 
 
-def test_no_warning(caplog):
+def test_inline_threshold_negative_val_warning_():
+    bkp = config.INLINE_THRESHOLD
+    config.INLINE_THRESHOLD = -1
+
+    with pytest.warns(UserWarning):
+        foo[dpex.Range(10)](dpnp.arange(10))
+
+    config.INLINE_THRESHOLD = bkp
+
+
+def test_inline_threshold_gt_3_warning():
+    bkp = config.INLINE_THRESHOLD
+    config.INLINE_THRESHOLD = 4
+
+    with pytest.warns(UserWarning):
+        foo[dpex.Range(10)](dpnp.arange(10))
+
+    config.INLINE_THRESHOLD = bkp
+
+
+def test_no_warning():
     with warnings.catch_warnings():
         warnings.simplefilter("error")
         foo[dpex.Range(10)](dpnp.arange(10))