From 1953c143268be878f3376b3eda0fe0152572022a Mon Sep 17 00:00:00 2001 From: kerthcet Date: Mon, 17 Aug 2026 09:04:56 +0100 Subject: [PATCH 1/2] support benchmark Signed-off-by: kerthcet --- Makefile | 8 +- config/manager/kustomization.yaml | 4 +- config/samples/deployment.yaml | 2 +- test/e2e/e2e_test.go | 18 + test/e2e/perf_report_test.go | 685 +++++++++++++++++++++++++++++ test/e2e/perf_test.go | 702 ++++++++++++++++++++++++++++++ test/utils/utils.go | 14 +- 7 files changed, 1428 insertions(+), 5 deletions(-) create mode 100644 test/e2e/perf_report_test.go create mode 100644 test/e2e/perf_test.go diff --git a/Makefile b/Makefile index f00d05d..0585110 100644 --- a/Makefile +++ b/Makefile @@ -115,7 +115,13 @@ setup-test-e2e: ## Set up a Kind cluster for e2e tests if it does not exist .PHONY: test-e2e test-e2e: setup-test-e2e manifests generate fmt vet ## Run the e2e tests. Expected an isolated environment using Kind. - KIND_CLUSTER=$(KIND_CLUSTER) go test -tags e2e ./test/e2e/ -v -ginkgo.v + KIND_CLUSTER=$(KIND_CLUSTER) go test -tags e2e ./test/e2e/ -v -ginkgo.v -ginkgo.label-filter='!perf' + $(MAKE) cleanup-test-e2e + +.PHONY: test-perf +test-perf: setup-test-e2e manifests generate fmt vet ## Run the workload-sync benchmark (Kind, PERF_WORKLOADS replicas). + KIND_CLUSTER=$(KIND_CLUSTER) \ + go test -tags e2e ./test/e2e/ -v -ginkgo.v -ginkgo.label-filter=perf -timeout 40m $(MAKE) cleanup-test-e2e .PHONY: cleanup-test-e2e diff --git a/config/manager/kustomization.yaml b/config/manager/kustomization.yaml index 086bc1e..547a445 100644 --- a/config/manager/kustomization.yaml +++ b/config/manager/kustomization.yaml @@ -4,5 +4,5 @@ apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization images: - name: controller - newName: inftyai/nebula-controller - newTag: latest + newName: example.com/nebula + newTag: v0.0.1 diff --git a/config/samples/deployment.yaml b/config/samples/deployment.yaml index 73b34d7..931e5ee 100644 --- a/config/samples/deployment.yaml +++ b/config/samples/deployment.yaml @@ -29,7 +29,7 @@ metadata: labels: app.kubernetes.io/managed-by: nebula spec: - replicas: 1 + replicas: 30 selector: matchLabels: app: gpu-workload-sample diff --git a/test/e2e/e2e_test.go b/test/e2e/e2e_test.go index 67a0bc4..72552b1 100644 --- a/test/e2e/e2e_test.go +++ b/test/e2e/e2e_test.go @@ -127,6 +127,13 @@ var _ = Describe("Manager", Ordered, func() { _, _ = utils.Run(exec.Command("kubectl", "delete", "nodepool", fakePoolName, "--ignore-not-found=true")) _, _ = utils.Run(exec.Command("kubectl", "delete", "ns", fakeWorkloadNS, "--ignore-not-found=true")) + By("cleaning up the sync-benchmark batch, pool, and namespace") + // The benchmark deletes its own batch, so this only covers the spec failing + // part-way — a leftover Pod here would keep a claim alive and block the drain + // below. Pods go with the namespace; the pool is cluster-scoped. + _, _ = utils.Run(exec.Command("kubectl", "delete", "ns", perfWorkloadNS, "--ignore-not-found=true")) + _, _ = utils.Run(exec.Command("kubectl", "delete", "nodepool", perfPoolName, "--ignore-not-found=true")) + By("waiting for NodeClaims to drain while the manager can still terminate instances") drained := waitForNodeClaimsGone(2 * time.Minute) @@ -428,6 +435,17 @@ spec: _, _ = utils.Run(exec.Command("kubectl", "delete", "-f", manifestFile, "--ignore-not-found=true")) }) + It("should sync a batch of workloads within the time budget", Label("perf"), func() { + // A benchmark, not a latency SLO: it scales one Deployment to N replicas and + // reports how long the whole sync path takes per workload, asserting only a + // loose ceiling so it catches a stalled path without flaking on a busy node. + // + // The perf label keeps it OUT of `make test-e2e` (which filters '!perf') and + // is what `make test-perf` selects, since the batch is slow enough that it + // does not belong in every e2e run. See perf_test.go. + benchmarkWorkloadSync() + }) + // +kubebuilder:scaffold:e2e-webhooks-checks // TODO: Customize the e2e test suite with scenarios specific to your project. diff --git a/test/e2e/perf_report_test.go b/test/e2e/perf_report_test.go new file mode 100644 index 0000000..ffb8d6f --- /dev/null +++ b/test/e2e/perf_report_test.go @@ -0,0 +1,685 @@ +//go:build e2e + +/* +Copyright 2026. + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package e2e + +import ( + "fmt" + "html/template" + "os" + "path/filepath" + "strings" + "time" + + . "github.com/onsi/ginkgo/v2" + + "github.com/InftyAI/Nebula/test/utils" +) + +// The HTML report is deliberately ONE self-contained file: no CDN, no JavaScript, and +// the chart is inline SVG computed here. A perf report gets opened from a laptop with no +// network, mailed around, and attached to CI artifacts, and any of those breaks the +// moment it needs to fetch a charting library. +const ( + // perfReportDir sits under the repo root, which .gitignore already covers + // ("artifacts"), so reports cannot be committed by accident. + perfReportDir = "artifacts" + perfReportFile = "perf-report.html" +) + +// Stage colours are shared by the table swatches and the chart curves, so a row and its +// curve are the same colour and the eye can move between them. Two colours do double duty, +// once per section, so they never share a chart: colourCreated for "Pods creation" and "Pods +// gone" (the Pod object moving at Kubernetes' own pace) and colourSync for the two derived +// per-workload rows, which are the only rows that isolate Nebula's own cost. +const ( + colourCreated = "#94a3b8" + colourClaims = "#f59e0b" + colourBound = "#3b82f6" + colourSync = "#10b981" + colourGone = "#ef4444" +) + +// perfReportPath is where the report lands, overridable so concurrent runs (or CI +// artifact collection) do not overwrite each other's report. +func perfReportPath() string { + if p := os.Getenv("NEBULA_E2E_PERF_REPORT"); p != "" { + return p + } + // Falls back to the working directory (test/e2e) if the project root cannot be + // resolved — a report in an odd place beats losing it. + if root, err := utils.GetProjectDir(); err == nil { + return filepath.Join(root, perfReportDir, perfReportFile) + } + return perfReportFile +} + +// writeHTMLReport renders the run and returns the path, or "" if it could not be +// written. Never fails the spec: losing the report is not a result, and this runs from a +// DeferCleanup where an assertion would mask the real failure. +func writeHTMLReport(n int, s syncSamples, total, drainTotal time.Duration, d drainSamples) string { + path := perfReportPath() + if dir := filepath.Dir(path); dir != "." { + if err := os.MkdirAll(dir, 0o755); err != nil { + _, _ = fmt.Fprintf(GinkgoWriter, " (could not create the report directory: %v)\n", err) + return "" + } + } + + page, err := renderHTMLReport(n, s, total, drainTotal, d) + if err != nil { + _, _ = fmt.Fprintf(GinkgoWriter, " (could not render the HTML report: %v)\n", err) + return "" + } + if err := os.WriteFile(path, []byte(page), 0o644); err != nil { + _, _ = fmt.Fprintf(GinkgoWriter, " (could not write the HTML report: %v)\n", err) + return "" + } + + _, _ = fmt.Fprintf(GinkgoWriter, "\n HTML report: file://%s\n", path) + return path +} + +// stage is one measured stage: the single source for both its table row and its curve, +// so the two can never disagree about colour, label, or samples. +type stage struct { + Label string + Colour string + Note string + Samples []time.Duration // ascending + Total int // denominator for the count column; 0 hides it + Curve bool // false for a derived stage with no meaningful timeline +} + +// reportRow is one line of a stage table. +type reportRow struct { + Label string + Colour string + Note string + Count string + P50 string + P95 string + Max string + P50Pct float64 // solid part of the spread bar + MaxPct float64 // translucent extension to max + Muted bool // a stage with nothing to show +} + +// reportSeries is one curve: cumulative workloads past a stage over time. +type reportSeries struct { + Label string + Colour string + Points string // SVG polyline "x,y x,y ..." + // Dash makes an exactly-covered curve visible without moving or fattening anything. + // Two stages CAN be identical, point for point — a Pod already bound the first time the + // poller sees it stamps "created" and "bound" from one timestamp — and the curve drawn + // first would otherwise vanish completely, which reads as missing data rather than as + // agreement. So the curve on TOP is dashed and the one underneath shows through the + // gaps: same width, same path, just interrupted. + // + // Drawing the covered curve as a wide translucent band was the previous attempt. These + // curves are staircases, and a 9px stroke on a near-vertical run protrudes to both + // sides of the 2.25px line on top of it, which reads as a second line offset sideways — + // the width itself became a misleading signal. Nudging a curve off its real position was + // never an option: that would be a lie about the numbers. + Dash string // stroke-dasharray; empty for a solid curve + // Same names the curve this one duplicates, for the legend. + Same string +} + +// chart is a fully precomputed plot, so the template does no arithmetic at all. +type chart struct { + W, H int + PadL, PadT int + PlotR, PlotB int // right and bottom edges of the plot area + XLabel string + XTicks []axisTick + YTicks []axisTick + Series []reportSeries +} + +type axisTick struct { + Pos float64 + Label string +} + +type reportPage struct { + Replicas int + Generated string + Verdict string + VerdictBad bool + Cards []reportCard + SyncRows []reportRow + DrainRows []reportRow + SyncChart *chart + DrainChart *chart + Summary string // the plain-text table, for copy-paste and diffing between runs + PollNote string +} + +type reportCard struct { + Key string + Value string + // Note becomes the card's tooltip. A six-card strip has no room for prose, but a + // two-word key does not say what the number covers — "total" alone does not reveal + // that cluster setup is outside it — so the definition has to live somewhere. + Note string +} + +func renderHTMLReport( + n int, s syncSamples, total, drainTotal time.Duration, d drainSamples, +) (string, error) { + // Measured from the apply. Ordered as the path runs, not by duration. + syncStages := []stage{{ + Label: "Pods creation", Colour: colourCreated, Samples: s.created, Total: n, Curve: true, + Note: "Kubernetes' own cost: how fast the Pods are created.", + }, { + Label: "Pods bound to " + fakeVirtualNode, Colour: colourBound, Samples: s.bound, Total: n, Curve: true, + Note: "Ungated and scheduled onto the virtual node — the workload is live.", + }, { + Label: "NodeClaims Bound", Colour: colourClaims, Samples: s.claims, Total: n, Curve: true, + Note: "The claim ledger catching up: placement decided and recorded.", + }, { + Label: "Per-Pod sync (created → bound)", Colour: colourSync, Samples: s.sync, + Note: "Nebula's own contribution, with the creation rate factored out.", + }} + // Measured from the delete, so these get their own clock — and their own chart. Pods + // first because the delete lands on the workload first, not because they finish first: + // which curve trails is the result, and it has gone both ways. + drainStages := []stage{{ + Label: "Pods gone", Colour: colourCreated, Samples: d.podsGone, Total: d.podsKnown, Curve: true, + Note: "Graceful termination through the virtual kubelet.", + }, { + Label: "NodeClaims gone", Colour: colourGone, Samples: d.gone, Total: d.known, Curve: true, + Note: "Self-deleted once the served Pod is gone, then the terminate finalizer releases " + + "the instance. Both rows count against the batch the sync watch observed; anything " + + "already gone at the first drain poll is stamped there, an upper bound.", + }, { + Label: "Per-claim release (pod → claim gone)", Colour: colourSync, Samples: d.release, + Total: d.podsKnown, + Note: "Nebula's own contribution to teardown, with the Pod deletion rate factored out. " + + "The two curves above cannot show this: their percentiles are over different objects. " + + "Both stamps come from one snapshot, so most pairs land inside a single poll and read " + + "as 0. A count below the batch is pairs with no end yet, or a claim seen gone first.", + }} + + page := reportPage{ + Replicas: n, + Generated: time.Now().Format("Mon, 02 Jan 2006 15:04:05 MST"), + Cards: []reportCard{ + {Key: "total", Value: fmtDuration(total), + Note: "The whole benchmark: apply until the last NodeClaim was gone, so sync plus " + + "teardown plus the short gap where the sync numbers are reported and asserted. " + + "Cluster setup and the manager's deploy are outside it."}, + {Key: "all synced", Value: lastOf(s.bound, n), + Note: "From the apply until the last Pod was bound to the virtual node. The apply " + + "itself is not reported: its round trip is the client's cost, not Nebula's."}, + {Key: "teardown", Value: fmtDuration(drainTotal), + Note: "From the delete until every NodeClaim in the batch was gone."}, + {Key: "replicas", Value: fmt.Sprintf("%d", n), + Note: "Batch size. Override with NEBULA_E2E_PERF_WORKLOADS."}, + {Key: "sync throughput", Value: rate(len(s.bound), n, lastSample(s.bound), "workloads/s"), + Note: "Replicas bound per second across that window."}, + {Key: "drain rate", Value: rate(len(d.gone), len(d.gone), drainTotal, "claims/s"), + Note: "NodeClaims removed per second, finalizers included."}, + }, + SyncRows: buildRows(syncStages), + DrainRows: buildRows(drainStages), + Summary: plainSummary(n, s, total, drainTotal, d), + PollNote: fmt.Sprintf( + "Every sample is attributed to the first %s poll that observed it, so all of them "+ + "overstate slightly; two list calls per sync poll and one per drain poll, whatever "+ + "the batch size.", + perfPollInterval), + } + + page.SyncChart = buildChart(syncStages, n, "elapsed since apply") + // The two drain stages share one y scale, so the Pods curve and the claims curve are + // read against the same count — that is the whole reason to plot them together. + page.DrainChart = buildChart(drainStages, max(d.known, d.podsKnown), "elapsed since delete") + + switch { + case len(s.bound) < n || len(s.claims) < n: + page.Verdict = fmt.Sprintf("INCOMPLETE — %d/%d pods bound, %d/%d claims Bound%s", + len(s.bound), n, len(s.claims), n, stalledSuffix(s.stalled)) + page.VerdictBad = true + case d.remaining > 0: + page.Verdict = fmt.Sprintf("Synced, but %d claim(s) never drained%s", + d.remaining, stalledSuffix(d.stalled)) + page.VerdictBad = true + default: + page.Verdict = fmt.Sprintf("All %d workloads synced and drained.", n) + } + + var b strings.Builder + if err := reportTemplate.Execute(&b, page); err != nil { + return "", err + } + return b.String(), nil +} + +func stalledSuffix(stalled bool) string { + if stalled { + return fmt.Sprintf(" — stalled: nothing advanced for %s", perfStallTimeout) + } + return "" +} + +// lastSample is when the final workload cleared a stage, or 0 if none did. +func lastSample(sorted []time.Duration) time.Duration { + if len(sorted) == 0 { + return 0 + } + return sorted[len(sorted)-1] +} + +// lastOf reports the whole batch's wall time for a stage, and says so only if the +// stage actually completed — a partial run's last sample is not a completion time. +func lastOf(sorted []time.Duration, n int) string { + if len(sorted) < n || n == 0 { + return "—" + } + return fmtDuration(lastSample(sorted)) +} + +func rate(count, want int, over time.Duration, unit string) string { + if count == 0 || count < want || over <= 0 { + return "—" + } + return fmt.Sprintf("%.1f %s", float64(count)/over.Seconds(), unit) +} + +func buildRows(stages []stage) []reportRow { + // Bars are scaled within a table, never across the two: the sync stages and the + // drain are measured from different starts, so a shared scale would invite a + // comparison that means nothing. + scale := time.Duration(0) + for _, st := range stages { + if v := lastSample(st.Samples); v > scale { + scale = v + } + } + + rows := make([]reportRow, 0, len(stages)) + for _, st := range stages { + row := reportRow{Label: st.Label, Colour: st.Colour, Note: st.Note} + switch { + case len(st.Samples) == 0: + row.Count, row.P50, row.P95, row.Max, row.Muted = "—", "—", "—", "—", true + case lastSample(st.Samples) == 0: + // Same guard as the terminal report: all-zero means faster than one poll, and + // printing 0s would claim precision this measurement does not have. + row.P50, row.P95, row.Max = "< 1 poll", "< 1 poll", "< 1 poll" + default: + row.P50 = fmtDuration(percentile(st.Samples, 50)) + row.P95 = fmtDuration(percentile(st.Samples, 95)) + row.Max = fmtDuration(lastSample(st.Samples)) + if scale > 0 { + row.P50Pct = percentile(st.Samples, 50).Seconds() / scale.Seconds() * 100 + row.MaxPct = lastSample(st.Samples).Seconds()/scale.Seconds()*100 - row.P50Pct + } + } + if st.Total > 0 { + row.Count = fmt.Sprintf("%d/%d", len(st.Samples), st.Total) + } else if len(st.Samples) > 0 { + row.Count = fmt.Sprintf("%d", len(st.Samples)) + } + rows = append(rows, row) + } + return rows +} + +func fmtDuration(d time.Duration) string { + switch { + case d == 0: + return "—" + case d < time.Second: + return d.Round(time.Millisecond).String() + case d < time.Minute: + return fmt.Sprintf("%.2fs", d.Seconds()) + default: + return d.Round(100 * time.Millisecond).String() + } +} + +// buildChart turns the samples into cumulative-completion curves, or returns nil if +// there is nothing to draw. Sorted ascending, sample i IS the moment the (i+1)-th +// workload cleared that stage, so no bucketing is needed: steepness is the rate, a flat +// stretch is a stall, and a curve hugging another means that stage is keeping up. +func buildChart(stages []stage, want int, xLabel string) *chart { + const w, h, padL, padR, padT, padB = 880, 300, 54, 24, 16, 44 + c := &chart{ + W: w, H: h, PadL: padL, PadT: padT, + PlotR: w - padR, PlotB: h - padB, XLabel: xLabel, + } + + maxSeconds, maxCount := 0.0, want + for _, st := range stages { + if !st.Curve { + continue + } + if v := lastSample(st.Samples).Seconds(); v > maxSeconds { + maxSeconds = v + } + if len(st.Samples) > maxCount { + maxCount = len(st.Samples) + } + } + if maxCount <= 0 || maxSeconds <= 0 { + return nil // nothing measurable: no axes worth drawing + } + + plotW := float64(c.PlotR - c.PadL) + plotH := float64(c.PlotB - c.PadT) + x := func(sec float64) float64 { return float64(c.PadL) + sec/maxSeconds*plotW } + y := func(count int) float64 { return float64(c.PlotB) - float64(count)/float64(maxCount)*plotH } + + for _, st := range stages { + if !st.Curve || len(st.Samples) == 0 { + continue + } + // Start at (first sample, 0) so a curve that begins late reads as beginning late + // rather than as rising out of the origin. + pts := make([]string, 0, len(st.Samples)+1) + pts = append(pts, fmt.Sprintf("%.1f,%.1f", x(st.Samples[0].Seconds()), y(0))) + for i, at := range st.Samples { + pts = append(pts, fmt.Sprintf("%.1f,%.1f", x(at.Seconds()), y(i+1))) + } + c.Series = append(c.Series, reportSeries{ + Label: st.Label, Colour: st.Colour, Points: strings.Join(pts, " "), + }) + } + if len(c.Series) == 0 { + return nil + } + + // Mark exact overlaps: dash the curve on top so the one beneath shows through it, and + // name the pairing in the legend, so "one line is missing" reads as "these two are the + // same line". Both curves keep the same width and position — see reportSeries.Dash. + for i := range c.Series { + for j := 0; j < i; j++ { + if c.Series[i].Points == c.Series[j].Points { + c.Series[i].Dash, c.Series[i].Same = "7 5", c.Series[j].Label + break + } + } + } + + for i := 0; i <= 4; i++ { + sec := maxSeconds * float64(i) / 4 + c.XTicks = append(c.XTicks, axisTick{Pos: x(sec), Label: fmt.Sprintf("%.1fs", sec)}) + count := maxCount * i / 4 + c.YTicks = append(c.YTicks, axisTick{Pos: y(count), Label: fmt.Sprintf("%d", count)}) + } + return c +} + +// plainSummary is the same table the terminal prints, embedded so one report can be +// diffed against another run without re-deriving anything. +func plainSummary(n int, s syncSamples, total, drainTotal time.Duration, d drainSamples) string { + var b strings.Builder + fmt.Fprintf(&b, "replicas %d\n", n) + fmt.Fprintf(&b, "Pods created %s\n", stageLine(s.created, n)) + fmt.Fprintf(&b, "NodeClaims Bound %s\n", stageLine(s.claims, n)) + fmt.Fprintf(&b, "Pods bound to %-18s %s\n", fakeVirtualNode, stageLine(s.bound, n)) + fmt.Fprintf(&b, "per-Pod sync (created → bound) %s\n", spreadLine(s.sync)) + fmt.Fprintf(&b, "teardown total %s\n", fmtDuration(drainTotal)) + fmt.Fprintf(&b, "Pods gone %s\n", stageLine(d.podsGone, d.podsKnown)) + fmt.Fprintf(&b, "NodeClaims gone %s\n", stageLine(d.gone, d.known)) + fmt.Fprintf(&b, "per-claim release (pod → claim) %s\n", releaseLine(d)) + fmt.Fprintf(&b, "total (apply → drained) %s\n", fmtDuration(total)) + fmt.Fprintf(&b, "poll interval %s\n", perfPollInterval) + fmt.Fprintf(&b, "stall timeout %s\n", perfStallTimeout) + fmt.Fprintf(&b, "sync budget %s\n", perfBudget(n)) + fmt.Fprintf(&b, "teardown budget %s\n", perfTeardownBudget(n)) + return b.String() +} + +// html/template escapes every interpolation, so nothing computed above can break the +// page even if a label or provider name ever carries markup. Two template blocks are +// shared by the sync and teardown sections, which is what keeps the two honest about +// being the same measurement on different clocks. +var reportTemplate = template.Must(template.New("perf").Parse(` + + + + +Nebula workload sync — {{.Replicas}} replicas + + + +
+
+

Workload sync benchmark

+ {{.Generated}} +
+

Fake provider on Kind, so this is control-plane cost only: Pods bind to a + virtual node and no container is ever started.

+ +
{{.Verdict}}
+ +
+ {{range .Cards}}
{{.Key}}
{{.Value}}
{{end}} +
+ +

Sync · from the apply

+
+ {{template "stageTable" .SyncRows}} + {{with .SyncChart}}
{{template "chart" .}}
{{end}} +
+

{{.PollNote}}

+ + {{if .DrainChart}} +

Teardown · from the delete

+
+ {{template "stageTable" .DrainRows}} +
{{template "chart" .DrainChart}}
+
+ {{end}} + +
+ Plain-text summary (for diffing runs) + 
{{.Summary}}
+
+ +
+ Generated by make test-perf (test/e2e/perf_test.go). + Set NEBULA_E2E_PERF_WORKLOADS to change the batch size and + NEBULA_E2E_PERF_REPORT to move this file — two runs sharing the + default path overwrite each other. +
+
+ + + +{{define "stageTable"}} + + + + + + + + + + {{range .}} + + + + + + + {{end}} + +
stagedonep50p95maxspread
+
+ {{.Label}}
+
{{.Note}}
+ 		{{if .Count}}{{.Count}}{{else}}—{{end}}{{.P50}}{{.P95}}{{.Max}}{{if .MaxPct}}
{{end}}
+{{end}} + +{{define "chart"}} +
+ + {{range .YTicks}} + + {{.Label}} + {{end}} + {{range .XTicks}} + {{.Label}} + {{end}} + + {{.XLabel}} + + workloads + + {{range .Series}} + + {{end}} + +
+
+ {{range .Series}}{{.Label}}{{if + .Same}}{{end}}{{end}} +
+{{end}} +`)) diff --git a/test/e2e/perf_test.go b/test/e2e/perf_test.go new file mode 100644 index 0000000..45a7ffd --- /dev/null +++ b/test/e2e/perf_test.go @@ -0,0 +1,702 @@ +//go:build e2e + +/* +Copyright 2026. + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package e2e + +import ( + "fmt" + "os" + "os/exec" + "sort" + "strconv" + "strings" + "time" + + . "github.com/onsi/ginkgo/v2" + . "github.com/onsi/gomega" + + // Aliased: "util" and "utils" one letter apart in the same file is a trap. This is the + // production helper, used so the benchmark derives claim names exactly as the controller + // does; utils below is the e2e test helper. + nebulautil "github.com/InftyAI/Nebula/pkg/util" + "github.com/InftyAI/Nebula/test/utils" +) + +// Sync-benchmark fixtures. Own namespace and pool, so the numbers are not perturbed +// by the placement spec's leftovers. +const ( + perfPoolName = "e2e-perf-pool" + perfWorkloadNS = "nebula-e2e-perf" + // perfDeployName is also the prefix every replica's Pod name carries, which is how + // the poller below picks this batch out of a cluster-wide list. + perfDeployName = "e2e-perf-workload" + perfManifestFile = "/tmp/nebula-perf-workloads.yaml" + + // defaultPerfReplicas is the batch size when NEBULA_E2E_PERF_WORKLOADS is unset. + // Cheap at this size — the replicas bind to a VIRTUAL node, so the Kind kubelet + // never runs a container and the cost is control-plane only. `make test-perf` + // passes a larger default. + defaultPerfReplicas = 500 + + // perfPollInterval is the sleep between polls. Latencies are quantized by it plus + // the two list calls each poll makes, because an event is attributed to the first + // poll that OBSERVES it — so every sample overstates a little. It has to stay well + // under the times being measured: at 500ms the whole distribution collapsed into + // one bucket and p50 read the same as p95. + // + // Note this is unrelated to Gomega's polling interval (this loop is not an + // Eventually: it stamps a first-seen time per object, and reports before it + // asserts) and to the provider poll interval in Capabilities(), which paces status + // refresh rather than placement. + perfPollInterval = 100 * time.Millisecond + + // perfStallTimeout is the real tripwire: a batch that stops advancing entirely for + // this long is wedged (a stuck queue, a lost watch, a provider call that never + // returns), and the spec should say so at once rather than sit out an absolute + // deadline that has to be sized for the largest N anyone runs. A healthy 500-replica + // run advances every poll, and even its slowest stage moved every 10s, so a full + // minute of total silence is not slowness — it is a stop. + // + // Failing on the STALL rather than on total time is what lets the budgets below + // stay loose without making a wedged run cost minutes to report. + perfStallTimeout = time.Minute +) + +// perfReplicas is the batch size, overridable for a bigger run. +func perfReplicas() int { + raw := os.Getenv("NEBULA_E2E_PERF_WORKLOADS") + if raw == "" { + return defaultPerfReplicas + } + n, err := strconv.Atoi(raw) + Expect(err).NotTo(HaveOccurred(), "NEBULA_E2E_PERF_WORKLOADS must be an integer") + Expect(n).To(BeNumerically(">", 0), "NEBULA_E2E_PERF_WORKLOADS must be positive") + return n +} + +// perfBudget and perfTeardownBudget are absolute BACKSTOPS, not the primary check: +// perfStallTimeout is what actually catches a wedged path, and it does so in about a +// minute whatever N is. So these only need to be generous enough not to flake on a +// loaded machine while still bounding a run that crawls forever — measured at 500 +// replicas, the sync took 65s against a 3m ceiling and the drain 103s against 3m30s. +// +// Neither is a latency SLO. Read the reported percentiles for that. +func perfBudget(n int) time.Duration { + return 30*time.Second + time.Duration(n)*300*time.Millisecond +} + +// perfTeardownBudget is separate, and larger, because draining is measurably the +// slowest stage: every claim carries the terminate finalizer, so N deletes plus N +// finalizer removals go through the same client the controllers are already using. +// Sharing one budget with the sync above is what forced that ceiling to be absurd. +func perfTeardownBudget(n int) time.Duration { + return time.Minute + time.Duration(n)*300*time.Millisecond +} + +// benchmarkWorkloadSync creates ONE Deployment of N gated replicas and measures how +// long the control plane takes to sync all of them: webhook gate → placement → +// NodeClaim Bound → Pod bound to the virtual node. +// +// A Deployment rather than N Pod manifests, for two reasons: it is the shape a user +// actually scales, and the replicas are then created in-cluster by the ReplicaSet +// controller instead of one-at-a-time by kubectl — so the measurement is not dominated +// by the client's serial creates. The cost of creation is still visible, as its own +// stage, and the per-Pod "created → bound" column isolates Nebula's own contribution +// from how fast the replicas arrived. +// +// Lives in the Manager container's ordered run because the manager is deployed by its +// BeforeAll and undeployed by its AfterAll. Labelled perf so it is excluded from +// `make test-e2e` and selected by `make test-perf`. +func benchmarkWorkloadSync() { + n := perfReplicas() + + // Written from a DeferCleanup, and the values are filled in as the spec proceeds, so + // a run that fails half way still leaves a report of how far it got — which is when + // the numbers are most worth reading. + var ( + s syncSamples + // total is the whole benchmark: apply until the last claim is gone. It is not + // drainTotal + the sync window — the gap where the sync numbers are reported and + // asserted falls inside it too, which is exactly why it is measured rather than + // added up. + total time.Duration + drainTotal time.Duration + d drainSamples + ) + DeferCleanup(func() { + writeHTMLReport(n, s, total, drainTotal, d) + }) + + By("waiting for the fake provider's virtual node to register") + Eventually(func(g Gomega) { + _, err := utils.Run(exec.Command("kubectl", "get", "node", fakeVirtualNode)) + g.Expect(err).NotTo(HaveOccurred(), "fake virtual node not registered") + }).Should(Succeed()) + + // A claim left over from the placement spec would land in the teardown timing + // below, which waits on claims cluster-wide. + By("waiting for prior NodeClaims to drain so the batch starts from a clean ledger") + Expect(waitForNodeClaimsGone(time.Minute)).To(BeTrue(), "prior NodeClaims did not drain") + + By("creating the perf namespace (webhook-eligible, restricted policy)") + _, _ = utils.Run(exec.Command("kubectl", "create", "ns", perfWorkloadNS)) + _, err := utils.Run(exec.Command("kubectl", "label", "--overwrite", "ns", perfWorkloadNS, + "pod-security.kubernetes.io/enforce=restricted")) + Expect(err).NotTo(HaveOccurred(), "Failed to label the perf namespace") + + Expect(os.WriteFile(perfManifestFile, []byte(perfManifest(n)), 0o644)).To(Succeed()) + + By(fmt.Sprintf("creating a NodePool and a Deployment of %d gated replicas", n)) + // The clock starts before the create, so every sample includes the whole path from + // "the user asked" onward. + start := time.Now() + _, err = utils.Run(exec.Command("kubectl", "apply", "-f", perfManifestFile)) + Expect(err).NotTo(HaveOccurred(), "Failed to apply the perf Deployment") + // The apply's own round trip is deliberately not reported: it is the client's cost, + // and nothing Nebula does can move it. What matters is that it is t0. + + budget := perfBudget(n) + By(fmt.Sprintf("waiting for all %d replicas to sync (budget %s)", n, budget)) + s = watchBatchSync(n, start, budget) + + reportBatchSync(n, s) + + // Name which of the two failure modes this was, since they lead different places. + gaveUp := fmt.Sprintf("within the %s budget", budget) + if s.stalled { + gaveUp = fmt.Sprintf("before stalling (nothing advanced for %s)", perfStallTimeout) + } + Expect(s.bound).To(HaveLen(n), fmt.Sprintf( + "only %d/%d Pods bound to %s %s (%d/%d created, %d/%d claims Bound)", + len(s.bound), n, fakeVirtualNode, gaveUp, len(s.created), n, len(s.claims), n)) + Expect(s.claims).To(HaveLen(n), fmt.Sprintf( + "only %d/%d NodeClaims reached Bound %s", len(s.claims), n, gaveUp)) + + By("deleting the batch and timing the teardown") + teardownBudget := perfTeardownBudget(n) + teardown := time.Now() + _, _ = utils.Run(exec.Command("kubectl", "delete", "-f", perfManifestFile, + "--ignore-not-found=true", "--wait=false")) + d = drainPerfClaims(teardownBudget, s.podNames) + drainTotal = time.Since(teardown) + total = time.Since(start) + + reportDrain(total, drainTotal, d) + + drainGaveUp := fmt.Sprintf("within the %s budget", teardownBudget) + if d.stalled { + drainGaveUp = fmt.Sprintf("and the count stopped falling for %s", perfStallTimeout) + } + Expect(d.remaining).To(BeZero(), fmt.Sprintf( + "%d/%d NodeClaims still present after deleting the batch %s", d.remaining, n, drainGaveUp)) +} + +// syncSamples holds the per-workload latencies of each stage, ascending. All are +// measured from the moment the Deployment was created, except sync — see below. A +// slice shorter than n means the watch gave up — stalled, or out of budget — before +// that stage finished. +type syncSamples struct { + created []time.Duration // Pod object exists + claims []time.Duration // NodeClaim reached Bound + bound []time.Duration // Pod bound to the virtual node + // sync is per Pod: bound − created, i.e. Nebula's own contribution, with the + // ReplicaSet's creation rate factored out. + sync []time.Duration + // podNames is every Pod this batch was OBSERVED to have, which the teardown poll needs: + // deletion is fast at the head of the queue, so a Pod (and its claim) can be gone before + // the drain's first list, and an object discovered only by that list is invisible to it. + // Seeded from here, the drain knows the whole batch up front and counts against it. + // + // Observed, never assumed to be n: if the sync gave up early this is short, and the + // teardown then reports against what provably existed rather than against a replica count + // nothing confirmed. + podNames []string + // stalled distinguishes the two ways of giving up: nothing advanced for + // perfStallTimeout (wedged), versus the budget running out while still making + // progress (merely slow). Only the failure message differs, but that is the + // difference between "go find the stuck queue" and "the numbers regressed". + stalled bool +} + +// watchBatchSync polls until every replica has synced, nothing advances for +// perfStallTimeout, or the budget runs out — in that order of preference, since the +// stall is the diagnosis and the budget is only the backstop. +// +// Two list calls per poll, whatever N is, so the measurement's own cost does not grow +// with the batch and inflate what it is measuring. +func watchBatchSync(n int, start time.Time, budget time.Duration) syncSamples { + createdSeen := map[string]time.Duration{} + boundSeen := map[string]time.Duration{} + claimSeen := map[string]time.Duration{} + claimPrefix := perfWorkloadNS + "-" + perfDeployName + + deadline := start.Add(budget) + nextLog := start.Add(10 * time.Second) + + // Progress is the sum of the three stage counts, which only ever rises (first-seen + // stamps are never dropped), so "did anything at all happen" is one comparison. + progress := 0 + lastProgress := start + stalled := false + + for { + // util.ClaimName(namespace, name) == "-", so this batch's + // claims are the ones under that prefix. + out, err := utils.RunQuiet(exec.Command("kubectl", "get", "nodeclaims", + "-o", "go-template={{range .items}}{{.metadata.name}} {{.status.phase}}{{\"\\n\"}}{{end}}")) + if err == nil { + at := time.Since(start) + for name, phase := range batchRows(out, claimPrefix) { + if phase == "Bound" { + firstSeen(claimSeen, name, at) + } + } + } + + out, err = utils.RunQuiet(exec.Command("kubectl", "get", "pods", "-n", perfWorkloadNS, + "-o", "go-template={{range .items}}{{.metadata.name}} {{.spec.nodeName}}{{\"\\n\"}}{{end}}")) + if err == nil { + at := time.Since(start) + for name, node := range batchRows(out, perfDeployName) { + firstSeen(createdSeen, name, at) + if node == fakeVirtualNode { + firstSeen(boundSeen, name, at) + } + } + } + + if len(createdSeen) >= n && len(claimSeen) >= n && len(boundSeen) >= n { + break + } + if got := len(createdSeen) + len(claimSeen) + len(boundSeen); got > progress { + progress, lastProgress = got, time.Now() + } + if time.Since(lastProgress) > perfStallTimeout { + stalled = true + break + } + if time.Now().After(deadline) { + break + } + if time.Now().After(nextLog) { + // Naming the node rather than saying "bound" twice: the NodeClaim's phase and + // the Pod's .spec.nodeName are different objects reaching different states, and + // one line carrying "bound" for both reads as a single stage counted twice. + _, _ = fmt.Fprintf(GinkgoWriter, + " t=%s pods created %d/%d claims Bound %d/%d pods on %s %d/%d\n", + time.Since(start).Round(time.Second), len(createdSeen), n, len(claimSeen), n, + fakeVirtualNode, len(boundSeen), n) + nextLog = time.Now().Add(10 * time.Second) + } + time.Sleep(perfPollInterval) + } + + // Only Pods observed at both ends contribute a sync sample; a Pod still unbound + // has no end yet, and counting it as zero would flatter the result. + sync := make([]time.Duration, 0, len(boundSeen)) + for name, at := range boundSeen { + if c, ok := createdSeen[name]; ok { + sync = append(sync, at-c) + } + } + + names := make([]string, 0, len(createdSeen)) + for name := range createdSeen { + names = append(names, name) + } + + return syncSamples{ + created: ascending(createdSeen), + claims: ascending(claimSeen), + bound: ascending(boundSeen), + sync: sortDurations(sync), + podNames: names, + stalled: stalled, + } +} + +// drainSamples is what the teardown poll observed. +type drainSamples struct { + // gone is one latency per claim that DISAPPEARED, measured from the delete, ascending, + // counted against known — the batch the sync watch observed, seeded in up front, plus + // anything the drain poll discovered on its own. + // + // A claim already gone at the first poll is stamped at that poll rather than dropped: + // the fact is "gone by T", an upper bound in the same direction every other sample here + // leans, and dropping it instead made the count read 496/496 while 500 claims provably + // existed — a blind spot that looked like a smaller batch. + gone []time.Duration + known int + // podsGone is the same measurement for this batch's Pods, on the same clock. It is what + // says how much of the teardown is Kubernetes' own: the Pod waits on graceful termination + // through the virtual kubelet, and the claim cannot go until that finishes, so this curve + // is the floor under the one above. Do not read the ORDER off the two curves — see + // release for that. + // + // Counted against podsKnown, seeded and stamped exactly as gone is. + podsGone []time.Duration + podsKnown int + // release pairs each Pod with its OWN claim: claim gone − pod gone, ascending, both stamped + // from the same snapshot. This is the teardown twin of syncSamples.sync, and the only number + // here that isolates Nebula: the two curves above are dominated by however fast the virtual + // kubelet processes 500 pod deletions, while this one says what the claim path costs on top + // of that. Expect most of it to read as 0 — the claim follows well inside one poll. + // + // Comparing the two distributions cannot answer that — their percentiles are over + // different objects, so a claim at p50 and a Pod at p50 are not the same workload, and a + // few missing Pod samples can make the claims look like they went first. + release []time.Duration + // releaseOutOfOrder counts pairs left OUT of release because the claim was seen absent while + // its Pod was still listed. With one snapshot per poll that is a genuine inversion rather + // than a sampling artifact, so it should read 0; anything else means a claim outran the Pod + // it serves. Dropped rather than kept as a negative sample, and counted rather than dropped + // quietly, because an inversion needs somewhere to show up. + releaseOutOfOrder int + // remaining is how many of this batch's claims were still present when the poll + // gave up; 0 means drained. + remaining int + // stalled means the count stopped falling (a finalizer that will never run) as + // opposed to the budget expiring while it was still falling. + stalled bool +} + +// drainPerfClaims polls until none of this batch's NodeClaims are left. Like the watch +// above it fails fast on a stall — a count falling steadily is progress however slow, +// while a count that stops falling is wedged. +// +// ONE list call per poll, covering Pods and claims together, unlike the sync watch. Two +// calls made the per-workload pairing unmeasurable: a claim follows its Pod in tens of +// milliseconds (see NodeClaimReconciler.Reconcile — it self-deletes once the served Pod +// reads absent), which is no bigger than the gap between two kubectl invocations, so every +// retained delta was measuring the harness rather than Nebula and roughly a third of the +// batch came out inverted and dropped. One snapshot stamps a Pod and its claim from the same +// instant. See pairRelease. +// +// podNames is the batch the sync watch observed (syncSamples.podNames). Both ledgers are +// seeded from it so the counts are against the batch that provably existed, not against +// whatever survived long enough for the first list to catch it — deletion is quickest at the +// head of the queue, so the objects most likely to be missed are the fastest ones. +// +// Deliberately separate from waitForNodeClaimsGone: that one is shared with AfterAll, +// where a plain cluster-wide poll with no stall logic is the right thing, and it must +// keep working even when the CRD is already gone. +func drainPerfClaims(budget time.Duration, podNames []string) drainSamples { + claimPrefix := perfWorkloadNS + "-" + perfDeployName + start := time.Now() + deadline := start.Add(budget) + + known := map[string]struct{}{} + goneSeen := map[string]time.Duration{} + podsKnown := map[string]struct{}{} + podsGoneSeen := map[string]time.Duration{} + // Seeding only asserts these objects EXISTED. The Pods were observed directly by the sync + // watch, and the claims are derived from them — sound because the spec asserts all N + // claims reached Bound before the delete, so it never gets here with a claim that was + // never real. It does not assert they are still here: one already gone is stamped by the + // first poll that fails to see it, the same rule every other name follows. + for _, pod := range podNames { + podsKnown[pod] = struct{}{} + known[nebulautil.ClaimName(perfWorkloadNS, pod)] = struct{}{} + } + remaining := -1 // no observation yet, so the first one always counts as progress + lastProgress := start + + // observeBatch stamps whichever of this batch's Pods and claims have gone, both from ONE + // list call and against ONE clock reading, and returns how many claims are left. The Pods + // do not gate the loop: only the claim count decides drained, stalled, or out of budget, + // because that is what the spec asserts on — hence the second return, which reports + // whether the list itself succeeded. A list that errors is skipped rather than read as + // "they are all gone": a transient failure would otherwise stamp the whole batch at once. + // + // Cluster-scoped nodeclaims ignore -n, so one call covers both kinds. + observeBatch := func() (int, bool) { + out, err := utils.RunQuiet(exec.Command("kubectl", "get", "pods,nodeclaims", "-n", perfWorkloadNS, + "-o", "go-template={{range .items}}{{.metadata.name}} {{.status.phase}}{{\"\\n\"}}{{end}}")) + if err != nil { + return 0, false + } + at := time.Since(start) + observeGone(podsKnown, podsGoneSeen, batchRows(out, perfDeployName), at) + claims := batchRows(out, claimPrefix) + observeGone(known, goneSeen, claims, at) + return len(claims), true + } + + result := func(remaining int, stalled bool) drainSamples { + release, outOfOrder := pairRelease(podsGoneSeen, goneSeen) + return drainSamples{ + gone: ascending(goneSeen), + known: len(known), + podsGone: ascending(podsGoneSeen), + podsKnown: len(podsKnown), + release: release, + releaseOutOfOrder: outOfOrder, + remaining: remaining, + stalled: stalled, + } + } + + for { + left, ok := observeBatch() + // A failed list says nothing about what is left, so it is neither progress nor a stall + // by itself: keep polling, and let the stall timeout below catch a failure that persists. + if ok { + if remaining < 0 || left < remaining { + remaining, lastProgress = left, time.Now() + } + if remaining == 0 { + return result(0, false) + } + } + if time.Since(lastProgress) > perfStallTimeout { + return result(remaining, true) + } + if time.Now().After(deadline) { + return result(remaining, false) + } + time.Sleep(perfPollInterval) + } +} + +// pairRelease derives one sample per workload: how long after its Pod vanished the claim +// serving it followed. Only workloads with BOTH stamps contribute — a claim still holding +// its finalizer has no end yet, and counting it as zero would flatter the result, the same +// rule syncSamples.sync follows at the other end. +// +// Keyed through ClaimName rather than a hand-rolled join so this matches whatever the +// controller derived, including the truncate-and-hash case for long names. +// +// On sign: both stamps come from the same snapshot (see drainPerfClaims), so a pair that +// vanishes inside one poll reads as 0 rather than as the gap between two list calls, and +// claimAt < podAt can only mean a genuine inversion — the claim was seen absent while its +// Pod was still listed. Those are returned as a count instead of as negative samples, so the +// distribution stays interpretable while nothing is silently discarded. Nothing is clamped: a +// clamp would make a real inversion look like 0. +func pairRelease(podsGoneSeen, goneSeen map[string]time.Duration) ([]time.Duration, int) { + out := make([]time.Duration, 0, len(podsGoneSeen)) + outOfOrder := 0 + for pod, podAt := range podsGoneSeen { + claimAt, ok := goneSeen[nebulautil.ClaimName(perfWorkloadNS, pod)] + switch { + case !ok: + // The claim has no end yet: still holding its finalizer, or the poll gave up first. + // Counting it as zero would flatter the result, the same rule syncSamples.sync follows. + case claimAt < podAt: + outOfOrder++ + default: + out = append(out, claimAt-podAt) + } + } + return sortDurations(out), outOfOrder +} + +// batchRows parses " " lines, keeping those whose name carries prefix. An +// unset field renders as "", which simply never matches a caller's wanted +// value. +func batchRows(out, prefix string) map[string]string { + rows := map[string]string{} + for _, line := range utils.GetNonEmptyLines(out) { + fields := strings.Fields(line) + if len(fields) != 2 || !strings.HasPrefix(fields[0], prefix) { + continue + } + rows[fields[0]] = fields[1] + } + return rows +} + +// firstSeen keeps the earliest observation of a name; later polls are ignored. +func firstSeen(seen map[string]time.Duration, name string, at time.Duration) { + if _, dup := seen[name]; !dup { + seen[name] = at + } +} + +// observeGone records what is present and stamps at against every name known from an +// earlier poll but absent from this one — that name's teardown is done. Both maps are +// updated in place; known only ever grows, so an object that reappears (it cannot, once +// deleted) would keep its first disappearance. +func observeGone( + known map[string]struct{}, goneSeen map[string]time.Duration, + present map[string]string, at time.Duration, +) { + for name := range present { + known[name] = struct{}{} + } + for name := range known { + if _, still := present[name]; !still { + firstSeen(goneSeen, name, at) + } + } +} + +func ascending(seen map[string]time.Duration) []time.Duration { + out := make([]time.Duration, 0, len(seen)) + for _, d := range seen { + out = append(out, d) + } + return sortDurations(out) +} + +func sortDurations(ds []time.Duration) []time.Duration { + sort.Slice(ds, func(i, j int) bool { return ds[i] < ds[j] }) + return ds +} + +// reportBatchSync writes the numbers to the Ginkgo output. Reporting is most of this +// spec's value: the assertion only catches a stall, while the table is what shows a +// path getting slower. +func reportBatchSync(n int, s syncSamples) { + _, _ = fmt.Fprintf(GinkgoWriter, + "\nworkload sync benchmark: Deployment %s, %d replicas (NEBULA_E2E_PERF_WORKLOADS)\n", + perfDeployName, n) + // Not "by the ReplicaSet": that is only true while the batch is a Deployment, and the + // stage means the same thing for any workload shape. + _, _ = fmt.Fprintf(GinkgoWriter, " Pods created %s\n", stageLine(s.created, n)) + _, _ = fmt.Fprintf(GinkgoWriter, " NodeClaims Bound %s\n", stageLine(s.claims, n)) + _, _ = fmt.Fprintf(GinkgoWriter, " Pods bound to %-22s %s\n", fakeVirtualNode, stageLine(s.bound, n)) + // The one column that does not move with how fast the replicas were created. + _, _ = fmt.Fprintf(GinkgoWriter, " per-Pod sync (created → bound) %s\n", spreadLine(s.sync)) + if len(s.bound) == n && s.bound[n-1] > 0 { + _, _ = fmt.Fprintf(GinkgoWriter, " throughput %.1f workloads/s\n", + float64(n)/s.bound[n-1].Seconds()) + } + _, _ = fmt.Fprintf(GinkgoWriter, + " (samples quantized by the %s poll interval plus the two list calls per poll)\n", perfPollInterval) +} + +// reportDrain prints teardown with the same spread the sync stages get. The wall clock +// alone cannot separate a steady trickle (a throughput ceiling) from most claims going +// fast plus one finalizer hanging — same total, different bug. +func reportDrain(total, drainTotal time.Duration, d drainSamples) { + _, _ = fmt.Fprintf(GinkgoWriter, " teardown (delete → all claims gone) %s\n", fmtDuration(drainTotal)) + // Both against known, not n: see drainSamples.gone. + _, _ = fmt.Fprintf(GinkgoWriter, " Pods gone %s\n", + stageLine(d.podsGone, d.podsKnown)) + _, _ = fmt.Fprintf(GinkgoWriter, " NodeClaims gone %s\n", + stageLine(d.gone, d.known)) + // The one column here that is not dominated by how fast the virtual kubelet deletes Pods. + _, _ = fmt.Fprintf(GinkgoWriter, " per-claim release (pod → claim gone) %s\n", releaseLine(d)) + if len(d.gone) > 0 && drainTotal > 0 { + _, _ = fmt.Fprintf(GinkgoWriter, " drain rate %.1f claims/s\n", + float64(len(d.gone))/drainTotal.Seconds()) + } + // Measured, not summed: see the note on total in benchmarkWorkloadSync. + _, _ = fmt.Fprintf(GinkgoWriter, " total (apply → all claims gone) %s\n", fmtDuration(total)) +} + +// releaseLine is the per-claim spread plus the pairs left out of it, so a run never presents +// the distribution without saying what is missing from it. +func releaseLine(d drainSamples) string { + line := fmt.Sprintf("%d/%d %s", len(d.release), d.podsKnown, spreadLine(d.release)) + if d.releaseOutOfOrder > 0 { + line += fmt.Sprintf(" (%d dropped: claim seen gone before its Pod)", d.releaseOutOfOrder) + } + return line +} + +// stageLine formats one stage: how many got there, and the spread of when. +func stageLine(sorted []time.Duration, n int) string { + if len(sorted) == 0 { + return fmt.Sprintf("0/%d", n) + } + return fmt.Sprintf("%d/%d %s", len(sorted), n, spreadLine(sorted)) +} + +func spreadLine(sorted []time.Duration) string { + if len(sorted) == 0 { + return "no samples" + } + // Every sample landed inside one poll. Printing "p50 0s" would claim a precision + // this loop does not have: all it knows is that the stage finished faster than it + // can look, which at 500 replicas is a list call, not the interval. + if sorted[len(sorted)-1] == 0 { + return "under one poll (too fast to resolve)" + } + // fmtDuration, the same formatter the HTML report uses, so the two never print the same + // number two ways: Go's own String() trims trailing zeros, which is what made 10.58s and + // 10.717s sit in one column at different precisions. + return fmt.Sprintf("p50 %s p95 %s max %s", + fmtDuration(percentile(sorted, 50)), + fmtDuration(percentile(sorted, 95)), + fmtDuration(lastSample(sorted))) +} + +// percentile is nearest-rank on an ascending slice: index ceil(p/100 * len) - 1, so +// p95 of 20 samples is the 19th. No interpolation — against a poll interval this +// coarse it would only invent precision. +func percentile(sorted []time.Duration, p int) time.Duration { + if len(sorted) == 0 { + return 0 + } + rank := (p*len(sorted) + 99) / 100 + if rank < 1 { + rank = 1 + } + if rank > len(sorted) { + rank = len(sorted) + } + return sorted[rank-1] +} + +// perfManifest is the pool plus one Deployment of n replicas. The Pod template carries +// the same labels and shape as the placement spec's Pod, so the two specs measure the +// same path at different widths. +func perfManifest(n int) string { + return fmt.Sprintf(`apiVersion: nebula.inftyai.com/v1alpha1 +kind: NodePool +metadata: + name: %[1]s +spec: + providers: + - name: %[2]s + capacityTypes: + - OnDemand + strategy: Ordered +--- +apiVersion: apps/v1 +kind: Deployment +metadata: + name: %[3]s + namespace: %[4]s +spec: + replicas: %[5]d + selector: + matchLabels: + app: %[3]s + template: + metadata: + labels: + app: %[3]s + nebula.inftyai.com/enabled: "true" + nebula.inftyai.com/nodepool: %[1]s + spec: + securityContext: + runAsNonRoot: true + seccompProfile: + type: RuntimeDefault + containers: + - name: main + image: registry.k8s.io/pause:3.10 + securityContext: + allowPrivilegeEscalation: false + capabilities: + drop: + - ALL +`, perfPoolName, fakeProviderName, perfDeployName, perfWorkloadNS, n) +} diff --git a/test/utils/utils.go b/test/utils/utils.go index 2477e90..858df47 100644 --- a/test/utils/utils.go +++ b/test/utils/utils.go @@ -39,6 +39,16 @@ func warnError(err error) { // Run executes the provided command within this context func Run(cmd *exec.Cmd) (string, error) { + return run(cmd, true) +} + +// RunQuiet is Run without the "running: …" trace. For commands issued from a poll +// loop, where echoing every invocation buries the output the test is there to show. +func RunQuiet(cmd *exec.Cmd) (string, error) { + return run(cmd, false) +} + +func run(cmd *exec.Cmd, trace bool) (string, error) { // Isolate the working directory to the command via cmd.Dir rather than // os.Chdir: os.Chdir mutates the process-wide cwd, which is not goroutine-safe // and would corrupt parallel commands (and anything else relying on cwd). @@ -55,7 +65,9 @@ func Run(cmd *exec.Cmd) (string, error) { cmd.Env = append(cmd.Env, "KUBECONFIG="+kubeconfigPath) } command := strings.Join(cmd.Args, " ") - _, _ = fmt.Fprintf(GinkgoWriter, "running: %q\n", command) + if trace { + _, _ = fmt.Fprintf(GinkgoWriter, "running: %q\n", command) + } output, err := cmd.CombinedOutput() if err != nil { return string(output), fmt.Errorf("%q failed with error %q: %w", command, string(output), err) From c46e66365b656a708052c94fe44e22577812df57 Mon Sep 17 00:00:00 2001 From: kerthcet Date: Mon, 17 Aug 2026 09:05:23 +0100 Subject: [PATCH 2/2] fix lint Signed-off-by: kerthcet --- config/manager/kustomization.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config/manager/kustomization.yaml b/config/manager/kustomization.yaml index 547a445..086bc1e 100644 --- a/config/manager/kustomization.yaml +++ b/config/manager/kustomization.yaml @@ -4,5 +4,5 @@ apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization images: - name: controller - newName: example.com/nebula - newTag: v0.0.1 + newName: inftyai/nebula-controller + newTag: latest